Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1425538 > unrolled thread
| Started by | Pali Rohár <pali.rohar@gmail.com> |
|---|---|
| First post | 2016-06-18 01:00 +0200 |
| Last post | 2016-06-22 10:10 +0200 |
| Articles | 4 on this page of 24 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH 0/6] dell-smm-hwmon fixes Pali Rohár <pali.rohar@gmail.com> - 2016-06-18 01:00 +0200
[PATCH 5/6] hwmon: (dell-smm) Detect fan with index=2 Pali Rohár <pali.rohar@gmail.com> - 2016-06-18 01:00 +0200
Re: [PATCH 5/6] hwmon: (dell-smm) Detect fan with index=2 Tolga Cakir <cevelnet@gmail.com> - 2016-06-19 02:10 +0200
[PATCH 4/6] hwmon: (dell-smm) Cache fan_type() calls and change fan detection Pali Rohár <pali.rohar@gmail.com> - 2016-06-18 01:00 +0200
Re: [PATCH 4/6] hwmon: (dell-smm) Cache fan_type() calls and change fan detection Tolga Cakir <cevelnet@gmail.com> - 2016-06-19 02:10 +0200
[PATCH 1/6] hwmon: (dell-smm) Fail in ioctl I8K_BIOS_VERSION when bios version is not a number Pali Rohár <pali.rohar@gmail.com> - 2016-06-18 01:00 +0200
Re: [PATCH 1/6] hwmon: (dell-smm) Fail in ioctl I8K_BIOS_VERSION when bios version is not a number Guenter Roeck <linux@roeck-us.net> - 2016-06-18 22:10 +0200
[PATCH 3/6] hwmon: (dell-smm) Disallow fan_type() calls on broken machines Pali Rohár <pali.rohar@gmail.com> - 2016-06-18 01:00 +0200
Re: [PATCH 3/6] hwmon: (dell-smm) Disallow fan_type() calls on broken machines Guenter Roeck <linux@roeck-us.net> - 2016-06-18 22:10 +0200
Re: [PATCH 3/6] hwmon: (dell-smm) Disallow fan_type() calls on broken machines Pali Rohár <pali.rohar@gmail.com> - 2016-06-19 00:50 +0200
[PATCH 2/6] hwmon: (dell-smm) Restrict fan control and serial number to CAP_SYS_ADMIN by default Pali Rohár <pali.rohar@gmail.com> - 2016-06-18 01:00 +0200
Re: [PATCH 2/6] hwmon: (dell-smm) Restrict fan control and serial number to CAP_SYS_ADMIN by default Guenter Roeck <linux@roeck-us.net> - 2016-06-18 22:10 +0200
[PATCH 6/6] hwmon: (dell-smm) In debug mode log duration of SMM calls Pali Rohár <pali.rohar@gmail.com> - 2016-06-18 01:00 +0200
Re: [PATCH 0/6] dell-smm-hwmon fixes Pali Rohár <pali.rohar@gmail.com> - 2016-06-18 14:30 +0200
Re: [PATCH 0/6] dell-smm-hwmon fixes Guenter Roeck <linux@roeck-us.net> - 2016-06-18 17:20 +0200
Re: [PATCH 0/6] dell-smm-hwmon fixes Pali Rohár <pali.rohar@gmail.com> - 2016-06-18 17:30 +0200
Re: [PATCH 0/6] dell-smm-hwmon fixes Guenter Roeck <linux@roeck-us.net> - 2016-06-18 19:00 +0200
Re: [PATCH 0/6] dell-smm-hwmon fixes Pali Rohár <pali.rohar@gmail.com> - 2016-06-19 00:40 +0200
Re: [PATCH 0/6] dell-smm-hwmon fixes Pali Rohár <pali.rohar@gmail.com> - 2016-06-20 11:20 +0200
Re: [PATCH 0/6] dell-smm-hwmon fixes Guenter Roeck <linux@roeck-us.net> - 2016-06-20 15:30 +0200
Re: [PATCH 0/6] dell-smm-hwmon fixes Pali Rohár <pali.rohar@gmail.com> - 2016-06-23 14:20 +0200
Re: [PATCH 0/6] dell-smm-hwmon fixes Guenter Roeck <linux@roeck-us.net> - 2016-06-23 16:00 +0200
Re: [PATCH 0/6] dell-smm-hwmon fixes Pali Rohár <pali.rohar@gmail.com> - 2016-06-19 00:50 +0200
Re: [PATCH 0/6] dell-smm-hwmon fixes Michał Kępień <kernel@kempniu.pl> - 2016-06-22 10:10 +0200
Page 2 of 2 — ← Prev page 1 [2]
| From | Pali Rohár <pali.rohar@gmail.com> |
|---|---|
| Date | 2016-06-23 14:20 +0200 |
| Message-ID | <rNbLY-1pt-25@gated-at.bofh.it> |
| In reply to | #1426600 |
On Monday 20 June 2016 06:24:57 Guenter Roeck wrote: > On 06/20/2016 02:12 AM, Pali Rohár wrote: > >On Sunday 19 June 2016 00:39:47 Pali Rohár wrote: > >>On Saturday 18 June 2016 18:54:58 Guenter Roeck wrote: > >>>On 06/18/2016 08:26 AM, Pali Rohár wrote: > >>>>On Saturday 18 June 2016 17:13:59 Guenter Roeck wrote: > >>>>>On 06/17/2016 03:54 PM, Pali Rohár wrote: > >>>>>>I'm sending all my dell-smm-hwmon patches in one series, because > >>>>>>due to changes in code other patches depends on previous. > >>>>>> > >>>>>>First two patches fixes problem with old /proc/i8k file. Second > >>>>>>is security fix and should be backported to all stable kernels > >>>>>>(that problem was there always). I tested i8kctl tool (from > >>>>>>i8kutils package) that it still works with these patches. > >>>>>>Without root access for those security operations just showes > >>>>>>'?' or '-1'. > >>>>>> > >>>>>>Third and fourth patches try to fix problem on machines with > >>>>>>broken SMM/BIOS when calling function fan_type(). > >>>>>> > >>>>>>Fifth is new feature and last sixth useful for debugging. > >>>>>> > >>>>>>Pali Rohár (6): > >>>>>> hwmon: (dell-smm) Fail in ioctl I8K_BIOS_VERSION when bios > >>>>>> version is > >>>>>> > >>>>>> not a number > >>>>>> > >>>>>> hwmon: (dell-smm) Restrict fan control and serial number to > >>>>>> > >>>>>> CAP_SYS_ADMIN by default > >>>>>> > >>>>>> hwmon: (dell-smm) Disallow fan_type() calls on broken > >>>>>> machines hwmon: (dell-smm) Cache fan_type() calls and change > >>>>>> fan detection hwmon: (dell-smm) Detect fan with index=2 > >>>>>> hwmon: (dell-smm) In debug mode log duration of SMM calls > >>>>>> > >>>>>> drivers/hwmon/dell-smm-hwmon.c | 122 > >>>>>> ++++++++++++++++++++++++++++++++-------- 1 file changed, 99 > >>>>>> insertions(+), 23 deletions(-) > >>>>> > >>>>>Pali, > >>>>> > >>>>>You asked for additional testing, so I am not sure what you expect > >>>>>me to do. > >>>>> > >>>>>Which of the patches can/should I apply now ? > >>>>> > >>>>>Guenter > >>>> > >>>>Test 3/6 and 4/6 patches on affected Dell machines. I CCed all > >>>>people who tried to debug those bugs, so need confirmation from > >>>>them that after applying 3/6 and 4/6 patches, erratic fan > >>>>behaviour is not there... > >>>> > >>>>But because those two patches depends on previous, it is needed to > >>>>test whole series... > >>> > >>>This doesn't tell me which patches to apply now. The first two ? > >> > >>Yes, 1/6 and 2/6 are OK. > >> > > > >Guenter, now you can apply whole series + add all tested-by lines from > >email threads. Looks like it is OK now. > > > First three patches applied and sent to Linus last night. > > Remaining three patches applied to -next. Ok, are you going to send at least patch 4/6 to Linus too as it fixes next bug which should go to -stable too? -- Pali Rohár pali.rohar@gmail.com
[toc] | [prev] | [next] | [standalone]
| From | Guenter Roeck <linux@roeck-us.net> |
|---|---|
| Date | 2016-06-23 16:00 +0200 |
| Message-ID | <rNdkK-2nl-13@gated-at.bofh.it> |
| In reply to | #1429749 |
On 06/23/2016 05:16 AM, Pali Rohár wrote: > On Monday 20 June 2016 06:24:57 Guenter Roeck wrote: >> On 06/20/2016 02:12 AM, Pali Rohár wrote: >>> On Sunday 19 June 2016 00:39:47 Pali Rohár wrote: >>>> On Saturday 18 June 2016 18:54:58 Guenter Roeck wrote: >>>>> On 06/18/2016 08:26 AM, Pali Rohár wrote: >>>>>> On Saturday 18 June 2016 17:13:59 Guenter Roeck wrote: >>>>>>> On 06/17/2016 03:54 PM, Pali Rohár wrote: >>>>>>>> I'm sending all my dell-smm-hwmon patches in one series, because >>>>>>>> due to changes in code other patches depends on previous. >>>>>>>> >>>>>>>> First two patches fixes problem with old /proc/i8k file. Second >>>>>>>> is security fix and should be backported to all stable kernels >>>>>>>> (that problem was there always). I tested i8kctl tool (from >>>>>>>> i8kutils package) that it still works with these patches. >>>>>>>> Without root access for those security operations just showes >>>>>>>> '?' or '-1'. >>>>>>>> >>>>>>>> Third and fourth patches try to fix problem on machines with >>>>>>>> broken SMM/BIOS when calling function fan_type(). >>>>>>>> >>>>>>>> Fifth is new feature and last sixth useful for debugging. >>>>>>>> >>>>>>>> Pali Rohár (6): >>>>>>>> hwmon: (dell-smm) Fail in ioctl I8K_BIOS_VERSION when bios >>>>>>>> version is >>>>>>>> >>>>>>>> not a number >>>>>>>> >>>>>>>> hwmon: (dell-smm) Restrict fan control and serial number to >>>>>>>> >>>>>>>> CAP_SYS_ADMIN by default >>>>>>>> >>>>>>>> hwmon: (dell-smm) Disallow fan_type() calls on broken >>>>>>>> machines hwmon: (dell-smm) Cache fan_type() calls and change >>>>>>>> fan detection hwmon: (dell-smm) Detect fan with index=2 >>>>>>>> hwmon: (dell-smm) In debug mode log duration of SMM calls >>>>>>>> >>>>>>>> drivers/hwmon/dell-smm-hwmon.c | 122 >>>>>>>> ++++++++++++++++++++++++++++++++-------- 1 file changed, 99 >>>>>>>> insertions(+), 23 deletions(-) >>>>>>> >>>>>>> Pali, >>>>>>> >>>>>>> You asked for additional testing, so I am not sure what you expect >>>>>>> me to do. >>>>>>> >>>>>>> Which of the patches can/should I apply now ? >>>>>>> >>>>>>> Guenter >>>>>> >>>>>> Test 3/6 and 4/6 patches on affected Dell machines. I CCed all >>>>>> people who tried to debug those bugs, so need confirmation from >>>>>> them that after applying 3/6 and 4/6 patches, erratic fan >>>>>> behaviour is not there... >>>>>> >>>>>> But because those two patches depends on previous, it is needed to >>>>>> test whole series... >>>>> >>>>> This doesn't tell me which patches to apply now. The first two ? >>>> >>>> Yes, 1/6 and 2/6 are OK. >>>> >>> >>> Guenter, now you can apply whole series + add all tested-by lines from >>> email threads. Looks like it is OK now. >>> >> First three patches applied and sent to Linus last night. >> >> Remaining three patches applied to -next. > > Ok, are you going to send at least patch 4/6 to Linus too as it fixes > next bug which should go to -stable too? > Now queued. Guenter
[toc] | [prev] | [next] | [standalone]
| From | Pali Rohár <pali.rohar@gmail.com> |
|---|---|
| Date | 2016-06-19 00:50 +0200 |
| Message-ID | <rLxdU-1O2-5@gated-at.bofh.it> |
| In reply to | #1425798 |
[Multipart message — attachments visible in raw view] — view raw
Thanks for testing! It took too long, but bugs in vendor SMM code are hard to detect and probably impossible to fix. So I would call this patch just as "workaround" and not proper bug fix... On Saturday 18 June 2016 23:58:19 Leon Yu wrote: > Just installed on "Inspiron 580", appears to have fixed the problem. > > On Sat, Jun 18, 2016 at 12:54 PM, Guenter Roeck <linux@roeck-us.net> > wrote: > > On 06/18/2016 08:26 AM, Pali Rohár wrote: > >> On Saturday 18 June 2016 17:13:59 Guenter Roeck wrote: > >>> On 06/17/2016 03:54 PM, Pali Rohár wrote: > >>>> I'm sending all my dell-smm-hwmon patches in one series, because > >>>> due to changes in code other patches depends on previous. > >>>> > >>>> First two patches fixes problem with old /proc/i8k file. Second > >>>> is security fix and should be backported to all stable kernels > >>>> (that problem was there always). I tested i8kctl tool (from > >>>> i8kutils package) that it still works with these patches. > >>>> Without root access for those security operations just showes > >>>> '?' or '-1'. > >>>> > >>>> Third and fourth patches try to fix problem on machines with > >>>> broken SMM/BIOS when calling function fan_type(). > >>>> > >>>> Fifth is new feature and last sixth useful for debugging. > >>>> > >>>> Pali Rohár (6): > >>>> hwmon: (dell-smm) Fail in ioctl I8K_BIOS_VERSION when bios > >>>> version is > >>>> > >>>> not a number > >>>> > >>>> hwmon: (dell-smm) Restrict fan control and serial number to > >>>> > >>>> CAP_SYS_ADMIN by default > >>>> > >>>> hwmon: (dell-smm) Disallow fan_type() calls on broken > >>>> machines hwmon: (dell-smm) Cache fan_type() calls and > >>>> change fan detection hwmon: (dell-smm) Detect fan with > >>>> index=2 hwmon: (dell-smm) In debug mode log duration of SMM > >>>> calls > >>>> > >>>> drivers/hwmon/dell-smm-hwmon.c | 122 > >>>> ++++++++++++++++++++++++++++++++-------- 1 file changed, 99 > >>>> insertions(+), 23 deletions(-) > >>> > >>> Pali, > >>> > >>> You asked for additional testing, so I am not sure what you > >>> expect me to do. > >>> > >>> Which of the patches can/should I apply now ? > >>> > >>> Guenter > >> > >> Test 3/6 and 4/6 patches on affected Dell machines. I CCed all > >> people who tried to debug those bugs, so need confirmation from > >> them that after applying 3/6 and 4/6 patches, erratic fan > >> behaviour is not there... > >> > >> But because those two patches depends on previous, it is needed to > >> test whole series... > >> > >> This doesn't tell me which patches to apply now. The first two ? > > > > Guenter -- Pali Rohár pali.rohar@gmail.com
[toc] | [prev] | [next] | [standalone]
| From | Michał Kępień <kernel@kempniu.pl> |
|---|---|
| Date | 2016-06-22 10:10 +0200 |
| Message-ID | <rMLot-Tc-3@gated-at.bofh.it> |
| In reply to | #1425538 |
> I'm sending all my dell-smm-hwmon patches in one series, because due to > changes in code other patches depends on previous. > > First two patches fixes problem with old /proc/i8k file. Second is security > fix and should be backported to all stable kernels (that problem was there > always). I tested i8kctl tool (from i8kutils package) that it still works > with these patches. Without root access for those security operations just > showes '?' or '-1'. > > Third and fourth patches try to fix problem on machines with broken > SMM/BIOS when calling function fan_type(). > > Fifth is new feature and last sixth useful for debugging. > > Pali Rohár (6): > hwmon: (dell-smm) Fail in ioctl I8K_BIOS_VERSION when bios version is > not a number > hwmon: (dell-smm) Restrict fan control and serial number to > CAP_SYS_ADMIN by default > hwmon: (dell-smm) Disallow fan_type() calls on broken machines > hwmon: (dell-smm) Cache fan_type() calls and change fan detection > hwmon: (dell-smm) Detect fan with index=2 > hwmon: (dell-smm) In debug mode log duration of SMM calls > > drivers/hwmon/dell-smm-hwmon.c | 122 ++++++++++++++++++++++++++++++++-------- > 1 file changed, 99 insertions(+), 23 deletions(-) On a Vostro V131 (BIOS A04): Tested-by: Michał Kępień <kernel@kempniu.pl> -- Best regards, Michał Kępień
[toc] | [prev] | [standalone]
Page 2 of 2 — ← Prev page 1 [2]
Back to top | Article view | linux.kernel
csiph-web