Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1425680 > unrolled thread

[PATCH] selftests/lib: set printf.sh executable

Started bySeongJae Park <sj38.park@gmail.com>
First post2016-06-18 11:30 +0200
Last post2016-06-18 20:00 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] selftests/lib: set printf.sh executable SeongJae Park <sj38.park@gmail.com> - 2016-06-18 11:30 +0200
    Re: [PATCH] selftests/lib: set printf.sh executable Kees Cook <keescook@chromium.org> - 2016-06-18 20:00 +0200

#1425680 — [PATCH] selftests/lib: set printf.sh executable

FromSeongJae Park <sj38.park@gmail.com>
Date2016-06-18 11:30 +0200
Subject[PATCH] selftests/lib: set printf.sh executable
Message-ID<rLkJH-2cZ-1@gated-at.bofh.it>
Test for test_printf module fails always because the test program,
printf.sh, has no execution permission.  This commit adds execution
permission to it.

Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
 tools/testing/selftests/lib/printf.sh | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 mode change 100644 => 100755 tools/testing/selftests/lib/printf.sh

diff --git a/tools/testing/selftests/lib/printf.sh b/tools/testing/selftests/lib/printf.sh
old mode 100644
new mode 100755
-- 
1.9.1

[toc] | [next] | [standalone]


#1425805

FromKees Cook <keescook@chromium.org>
Date2016-06-18 20:00 +0200
Message-ID<rLsHf-7cS-1@gated-at.bofh.it>
In reply to#1425680
On Sat, Jun 18, 2016 at 2:28 AM, SeongJae Park <sj38.park@gmail.com> wrote:
> Test for test_printf module fails always because the test program,
> printf.sh, has no execution permission.  This commit adds execution
> permission to it.
>
> Signed-off-by: SeongJae Park <sj38.park@gmail.com>

Acked-by: Kees Cook <keescook@chromium.org>

(Is this mode change sufficient, or does the selftest infrastructure
need to explicitly set it executable when running?)

-Kees


> ---
>  tools/testing/selftests/lib/printf.sh | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  mode change 100644 => 100755 tools/testing/selftests/lib/printf.sh
>
> diff --git a/tools/testing/selftests/lib/printf.sh b/tools/testing/selftests/lib/printf.sh
> old mode 100644
> new mode 100755
> --
> 1.9.1
>



-- 
Kees Cook
Chrome OS & Brillo Security

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web