Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1426035 > unrolled thread

[PATCH] checkpatch: remove obsolete CONFIG_EXPERIMENTAL checks

Back to article view | Back to linux.kernel

Contents

  [PATCH] checkpatch: remove obsolete CONFIG_EXPERIMENTAL checks Ruslan Bilovol <ruslan.bilovol@gmail.com> - 2016-06-19 22:50 +0200
    Re: [PATCH] checkpatch: remove obsolete CONFIG_EXPERIMENTAL checks Joe Perches <joe@perches.com> - 2016-06-20 03:40 +0200
      Re: [PATCH] checkpatch: remove obsolete CONFIG_EXPERIMENTAL checks Ruslan Bilovol <ruslan.bilovol@gmail.com> - 2016-06-20 04:20 +0200

#1426035 — [PATCH] checkpatch: remove obsolete CONFIG_EXPERIMENTAL checks

Config EXPERIMENTAL has been removed from kernel in 2013
(see 3d374d0: "final removal of CONFIG_EXPERIMENTAL"),
there is no any reason to do these checks now.

Signed-off-by: Ruslan Bilovol <ruslan.bilovol@gmail.com>
---
 scripts/checkpatch.pl | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 4904ced..4ede92c 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2670,13 +2670,6 @@ sub process {
 			#print "is_start<$is_start> is_end<$is_end> length<$length>\n";
 		}
 
-# discourage the addition of CONFIG_EXPERIMENTAL in Kconfig.
-		if ($realfile =~ /Kconfig/ &&
-		    $line =~ /.\s*depends on\s+.*\bEXPERIMENTAL\b/) {
-			WARN("CONFIG_EXPERIMENTAL",
-			     "Use of CONFIG_EXPERIMENTAL is deprecated. For alternatives, see https://lkml.org/lkml/2012/10/23/580\n");
-		}
-
 # discourage the use of boolean for type definition attributes of Kconfig options
 		if ($realfile =~ /Kconfig/ &&
 		    $line =~ /^\+\s*\bboolean\b/) {
@@ -3042,12 +3035,6 @@ sub process {
 			}
 		}
 
-# discourage the addition of CONFIG_EXPERIMENTAL in #if(def).
-		if ($line =~ /^\+\s*\#\s*if.*\bCONFIG_EXPERIMENTAL\b/) {
-			WARN("CONFIG_EXPERIMENTAL",
-			     "Use of CONFIG_EXPERIMENTAL is deprecated. For alternatives, see https://lkml.org/lkml/2012/10/23/580\n");
-		}
-
 # check for RCS/CVS revision markers
 		if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|)/) {
 			WARN("CVS_KEYWORD",
-- 
1.9.1

[toc] | [next] | [standalone]

#1426106

On Sun, 2016-06-19 at 23:29 +0300, Ruslan Bilovol wrote:
> Config EXPERIMENTAL has been removed from kernel in 2013
> (see 3d374d0: "final removal of CONFIG_EXPERIMENTAL"),
> there is no any reason to do these checks now.

Not quite removed:

$ git grep CONFIG_EXPERIMENTAL -- "*configs*" | wc -l
217

No objection from me though.

[toc] | [prev] | [next] | [standalone]

#1426122

On Mon, Jun 20, 2016 at 4:30 AM, Joe Perches <joe@perches.com> wrote:
> On Sun, 2016-06-19 at 23:29 +0300, Ruslan Bilovol wrote:
>> Config EXPERIMENTAL has been removed from kernel in 2013
>> (see 3d374d0: "final removal of CONFIG_EXPERIMENTAL"),
>> there is no any reason to do these checks now.
>
> Not quite removed:
>
> $ git grep CONFIG_EXPERIMENTAL -- "*configs*" | wc -l
> 217

I just mean that config option is removed from Kconfig file.
These checkpatch checks have nothing to do with
"CONFIG_EXPERIMENTAL=y" lines that still live in many
defconfigs.

BTW, I can write quite simple script that will remove it from
defconfig as well and send to related maintainers in a
separate patch series, or alternatively you can do similar
thing proposed by you in RFC https://lkml.org/lkml/2015/7/16/725

>
> No objection from me though.

Thanks

Best regards,
Ruslan

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web