Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1424598 > unrolled thread

[PATCH v3] i2c: designware: Use transfer timeout from ioctl I2C_TIMEOUT

Started byWeifeng Voon <weifeng.voon@intel.com>
First post2016-06-17 03:50 +0200
Last post2016-06-19 19:00 +0200
Articles 4 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH v3] i2c: designware: Use transfer timeout from ioctl I2C_TIMEOUT Weifeng Voon <weifeng.voon@intel.com> - 2016-06-17 03:50 +0200
    Re: [PATCH v3] i2c: designware: Use transfer timeout from ioctl  I2C_TIMEOUT Jarkko Nikula <jarkko.nikula@linux.intel.com> - 2016-06-17 07:40 +0200
    Re: [PATCH v3] i2c: designware: Use transfer timeout from ioctl  I2C_TIMEOUT Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-06-17 09:20 +0200
    Re: [PATCH v3] i2c: designware: Use transfer timeout from ioctl  I2C_TIMEOUT Wolfram Sang <wsa@the-dreams.de> - 2016-06-19 19:00 +0200

#1424598 — [PATCH v3] i2c: designware: Use transfer timeout from ioctl I2C_TIMEOUT

FromWeifeng Voon <weifeng.voon@intel.com>
Date2016-06-17 03:50 +0200
Subject[PATCH v3] i2c: designware: Use transfer timeout from ioctl I2C_TIMEOUT
Message-ID<rKR50-8jh-7@gated-at.bofh.it>
This allows applications to set the transfer timeout in 10ms increments via
ioctl I2C_TIMEOUT.

Signed-off-by: Weifeng Voon <weifeng.voon@intel.com>
---
 changelog v2:
 * No code change, just change to a more suitable title

 changelog v3:
 * Move changelog out of commit log

 drivers/i2c/busses/i2c-designware-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-designware-core.c b/drivers/i2c/busses/i2c-designware-core.c
index 99b54be..c6922b8 100644
--- a/drivers/i2c/busses/i2c-designware-core.c
+++ b/drivers/i2c/busses/i2c-designware-core.c
@@ -663,7 +663,7 @@ i2c_dw_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[], int num)
 	i2c_dw_xfer_init(dev);
 
 	/* wait for tx to complete */
-	if (!wait_for_completion_timeout(&dev->cmd_complete, HZ)) {
+	if (!wait_for_completion_timeout(&dev->cmd_complete, adap->timeout)) {
 		dev_err(dev->dev, "controller timed out\n");
 		/* i2c_dw_init implicitly disables the adapter */
 		i2c_dw_init(dev);
-- 
1.9.1

[toc] | [next] | [standalone]

#1424681 — Re: [PATCH v3] i2c: designware: Use transfer timeout from ioctl I2C_TIMEOUT

FromJarkko Nikula <jarkko.nikula@linux.intel.com>
Date2016-06-17 07:40 +0200
SubjectRe: [PATCH v3] i2c: designware: Use transfer timeout from ioctl I2C_TIMEOUT
Message-ID<rKUFA-2px-41@gated-at.bofh.it>
In reply to#1424598
On 06/17/2016 04:46 AM, Weifeng Voon wrote:
> This allows applications to set the transfer timeout in 10ms increments via
> ioctl I2C_TIMEOUT.
>
> Signed-off-by: Weifeng Voon <weifeng.voon@intel.com>
> ---
>  changelog v2:
>  * No code change, just change to a more suitable title
>
>  changelog v3:
>  * Move changelog out of commit log
>
>  drivers/i2c/busses/i2c-designware-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-designware-core.c b/drivers/i2c/busses/i2c-designware-core.c
> index 99b54be..c6922b8 100644
> --- a/drivers/i2c/busses/i2c-designware-core.c
> +++ b/drivers/i2c/busses/i2c-designware-core.c
> @@ -663,7 +663,7 @@ i2c_dw_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[], int num)
>  	i2c_dw_xfer_init(dev);
>
>  	/* wait for tx to complete */
> -	if (!wait_for_completion_timeout(&dev->cmd_complete, HZ)) {
> +	if (!wait_for_completion_timeout(&dev->cmd_complete, adap->timeout)) {
>  		dev_err(dev->dev, "controller timed out\n");
>  		/* i2c_dw_init implicitly disables the adapter */
>  		i2c_dw_init(dev);

Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>

[toc] | [prev] | [next] | [standalone]

#1424737 — Re: [PATCH v3] i2c: designware: Use transfer timeout from ioctl I2C_TIMEOUT

FromUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date2016-06-17 09:20 +0200
SubjectRe: [PATCH v3] i2c: designware: Use transfer timeout from ioctl I2C_TIMEOUT
Message-ID<rKWem-3sy-27@gated-at.bofh.it>
In reply to#1424598
On Fri, Jun 17, 2016 at 09:46:35AM +0800, Weifeng Voon wrote:
> This allows applications to set the transfer timeout in 10ms increments via
> ioctl I2C_TIMEOUT.
> 
> Signed-off-by: Weifeng Voon <weifeng.voon@intel.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[toc] | [prev] | [next] | [standalone]

#1426005 — Re: [PATCH v3] i2c: designware: Use transfer timeout from ioctl I2C_TIMEOUT

FromWolfram Sang <wsa@the-dreams.de>
Date2016-06-19 19:00 +0200
SubjectRe: [PATCH v3] i2c: designware: Use transfer timeout from ioctl I2C_TIMEOUT
Message-ID<rLOeK-4Ra-21@gated-at.bofh.it>
In reply to#1424598

[Multipart message — attachments visible in raw view] — view raw

On Fri, Jun 17, 2016 at 09:46:35AM +0800, Weifeng Voon wrote:
> This allows applications to set the transfer timeout in 10ms increments via
> ioctl I2C_TIMEOUT.
> 
> Signed-off-by: Weifeng Voon <weifeng.voon@intel.com>

Applied to for-next, thanks!

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web