Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1425857 > unrolled thread
| Started by | Craig Inches <craig@craiginches.com> |
|---|---|
| First post | 2016-06-18 23:30 +0200 |
| Last post | 2016-06-19 04:10 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 0/3] staging: luster: cl_object.h Checkpatch Cleanup Craig Inches <craig@craiginches.com> - 2016-06-18 23:30 +0200
[PATCH 1/3] staging: luster: cl_object.h Checkpatch Cleanup Craig Inches <craig@craiginches.com> - 2016-06-18 23:30 +0200
Re: [PATCH 1/3] staging: luster: cl_object.h Checkpatch Cleanup Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-06-19 04:10 +0200
| From | Craig Inches <craig@craiginches.com> |
|---|---|
| Date | 2016-06-18 23:30 +0200 |
| Subject | [PATCH 0/3] staging: luster: cl_object.h Checkpatch Cleanup |
| Message-ID | <rLvYt-14U-3@gated-at.bofh.it> |
Fix three different issues from checkpatch: Line over 80 Chars Unsigned int prefered over unsigned Macros with complex values should be enclosed in parenthesis Craig Inches (3): checkpatch style issue: Line over 80 char Checkpatch style issue: Checkpatch error cleanup drivers/staging/lustre/lustre/include/cl_object.h | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) -- 2.7.3
[toc] | [next] | [standalone]
| From | Craig Inches <craig@craiginches.com> |
|---|---|
| Date | 2016-06-18 23:30 +0200 |
| Subject | [PATCH 1/3] staging: luster: cl_object.h Checkpatch Cleanup |
| Message-ID | <rLvYt-14U-9@gated-at.bofh.it> |
| In reply to | #1425857 |
Line length greater than 80 char.
Signed-off-by: Craig Inches <craig@craiginches.com>
---
drivers/staging/lustre/lustre/include/cl_object.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/include/cl_object.h b/drivers/staging/lustre/lustre/include/cl_object.h
index 99fc28e..3004625 100644
--- a/drivers/staging/lustre/lustre/include/cl_object.h
+++ b/drivers/staging/lustre/lustre/include/cl_object.h
@@ -1054,7 +1054,7 @@ do { \
#define CL_PAGE_HEADER(mask, env, page, format, ...) \
do { \
if (cfs_cdebug_show(mask, DEBUG_SUBSYSTEM)) { \
- LIBCFS_DEBUG_MSG_DATA_DECL(msgdata, mask, NULL); \
+ LIBCFS_DEBUG_MSG_DATA_DECL(msgdata, mask, NULL); \
cl_page_header_print(env, &msgdata, lu_cdebug_printer, page); \
CDEBUG(mask, format, ## __VA_ARGS__); \
} \
--
2.7.3
[toc] | [prev] | [next] | [standalone]
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2016-06-19 04:10 +0200 |
| Subject | Re: [PATCH 1/3] staging: luster: cl_object.h Checkpatch Cleanup |
| Message-ID | <rLAlr-3Xa-7@gated-at.bofh.it> |
| In reply to | #1425858 |
On Sat, Jun 18, 2016 at 10:25:42PM +0100, Craig Inches wrote: > Line length greater than 80 char. What does that mean? What does your subject mean? Please be more descriptive, again, look at other patches that have been merged for examples... greg k-h
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web