Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1425160 > unrolled thread

[PATCH 0/2] Fixes for sparse reported warnings

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/2] Fixes for sparse reported warnings Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-06-17 16:40 +0200
    [PATCH 2/2] tpm_crb: fix address space of the return pointer in crb_map_res() Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-06-17 16:50 +0200
      Re: [PATCH 2/2] tpm_crb: fix address space of the return pointer in  crb_map_res() Stefan Berger <stefanb@linux.vnet.ibm.com> - 2016-06-17 16:50 +0200
    Re: [PATCH 0/2] Fixes for sparse reported warnings Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-06-18 14:30 +0200

#1425160 — [PATCH 0/2] Fixes for sparse reported warnings

Jarkko Sakkinen (2):
  tpm_vtpm_proxy: fix address space of a user pointer in
    vtpmx_fops_ioctl()
  tpm_crb: fix address space of the return pointer in crb_map_res()

 drivers/char/tpm/tpm_crb.c        | 2 +-
 drivers/char/tpm/tpm_vtpm_proxy.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
2.7.4

[toc] | [next] | [standalone]

#1425164 — [PATCH 2/2] tpm_crb: fix address space of the return pointer in crb_map_res()

When running make C=2 M=drivers/char/tpm/

  CHECK   drivers/char/tpm//tpm_crb.c
drivers/char/tpm//tpm_crb.c:248:31: warning: incorrect type in return expression (different address spaces)
drivers/char/tpm//tpm_crb.c:248:31:    expected void [noderef] <asn:2>*
drivers/char/tpm//tpm_crb.c:248:31:    got void *

Fixes: 1bd047be37d9 ("tpm_crb: Use devm_ioremap_resource")
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
---
 drivers/char/tpm/tpm_crb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/tpm/tpm_crb.c b/drivers/char/tpm/tpm_crb.c
index 1547636..1b8e1b5 100644
--- a/drivers/char/tpm/tpm_crb.c
+++ b/drivers/char/tpm/tpm_crb.c
@@ -245,7 +245,7 @@ static void __iomem *crb_map_res(struct device *dev, struct crb_priv *priv,
 
 	/* Detect a 64 bit address on a 32 bit system */
 	if (start != new_res.start)
-		return ERR_PTR(-EINVAL);
+		return (void __iomem *) ERR_PTR(-EINVAL);
 
 	if (!resource_contains(io_res, &new_res))
 		return devm_ioremap_resource(dev, &new_res);
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1425165 — Re: [PATCH 2/2] tpm_crb: fix address space of the return pointer in crb_map_res()

On 06/17/2016 10:39 AM, Jarkko Sakkinen wrote:
> When running make C=2 M=drivers/char/tpm/
>
>    CHECK   drivers/char/tpm//tpm_crb.c
> drivers/char/tpm//tpm_crb.c:248:31: warning: incorrect type in return expression (different address spaces)
> drivers/char/tpm//tpm_crb.c:248:31:    expected void [noderef] <asn:2>*
> drivers/char/tpm//tpm_crb.c:248:31:    got void *
>
> Fixes: 1bd047be37d9 ("tpm_crb: Use devm_ioremap_resource")
> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

Tested-by: Stefan Berger <stefanb@linux.vnet.ibm.com>

[toc] | [prev] | [next] | [standalone]

#1425712

On Fri, Jun 17, 2016 at 04:39:27PM +0200, Jarkko Sakkinen wrote:
> Jarkko Sakkinen (2):
>   tpm_vtpm_proxy: fix address space of a user pointer in
>     vtpmx_fops_ioctl()
>   tpm_crb: fix address space of the return pointer in crb_map_res()

Merged to next.

/Jarkko

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web