Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1425225 > unrolled thread

[PATCH] timer: avoid using timespec

Back to article view | Back to linux.kernel

Contents

  [PATCH] timer: avoid using timespec Arnd Bergmann <arnd@arndb.de> - 2016-06-17 17:30 +0200
    Re: [PATCH] timer: avoid using timespec John Stultz <john.stultz@linaro.org> - 2016-06-17 23:00 +0200

#1425225 — [PATCH] timer: avoid using timespec

The tstats_show() function prints a ktime_t variable by converting
it to struct timespec first. The algorithm is ok, but we want to
stop using timespec in general because of the 32-bit time_t
overflow problem.

This changes the code to use struct timespec64, without any
functional change.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 kernel/time/timer_stats.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel/time/timer_stats.c b/kernel/time/timer_stats.c
index 1adecb4b87c8..087204c733eb 100644
--- a/kernel/time/timer_stats.c
+++ b/kernel/time/timer_stats.c
@@ -279,7 +279,7 @@ static void print_name_offset(struct seq_file *m, unsigned long addr)
 
 static int tstats_show(struct seq_file *m, void *v)
 {
-	struct timespec period;
+	struct timespec64 period;
 	struct entry *entry;
 	unsigned long ms;
 	long events = 0;
@@ -295,11 +295,11 @@ static int tstats_show(struct seq_file *m, void *v)
 
 	time = ktime_sub(time_stop, time_start);
 
-	period = ktime_to_timespec(time);
+	period = ktime_to_timespec64(time);
 	ms = period.tv_nsec / 1000000;
 
 	seq_puts(m, "Timer Stats Version: v0.3\n");
-	seq_printf(m, "Sample period: %ld.%03ld s\n", period.tv_sec, ms);
+	seq_printf(m, "Sample period: %ld.%03ld s\n", (long)period.tv_sec, ms);
 	if (atomic_read(&overflow_count))
 		seq_printf(m, "Overflow: %d entries\n", atomic_read(&overflow_count));
 	seq_printf(m, "Collection: %s\n", timer_stats_active ? "active" : "inactive");
-- 
2.9.0

[toc] | [next] | [standalone]

#1425471

On Fri, Jun 17, 2016 at 8:30 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> The tstats_show() function prints a ktime_t variable by converting
> it to struct timespec first. The algorithm is ok, but we want to
> stop using timespec in general because of the 32-bit time_t
> overflow problem.
>
> This changes the code to use struct timespec64, without any
> functional change.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Queued for testing.

thanks
-john

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web