Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1420131 > unrolled thread

Re: [PATCH 3/3] ARM: dts: imx7: add Toradex Colibri iMX7S/iMX7D support

Started byShawn Guo <shawnguo@kernel.org>
First post2016-06-12 04:40 +0200
Last post2016-06-16 13:00 +0200
Articles 3 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 3/3] ARM: dts: imx7: add Toradex Colibri iMX7S/iMX7D  support Shawn Guo <shawnguo@kernel.org> - 2016-06-12 04:40 +0200
    Re: [PATCH 3/3] ARM: dts: imx7: add Toradex Colibri iMX7S/iMX7D  support Stefan Agner <stefan@agner.ch> - 2016-06-16 07:50 +0200
      Re: [PATCH 3/3] ARM: dts: imx7: add Toradex Colibri iMX7S/iMX7D  support Marcel Ziswiler <marcel.ziswiler@toradex.com> - 2016-06-16 13:00 +0200

#1420131 — Re: [PATCH 3/3] ARM: dts: imx7: add Toradex Colibri iMX7S/iMX7D support

FromShawn Guo <shawnguo@kernel.org>
Date2016-06-12 04:40 +0200
SubjectRe: [PATCH 3/3] ARM: dts: imx7: add Toradex Colibri iMX7S/iMX7D support
Message-ID<rJ3tE-2R5-9@gated-at.bofh.it>
On Tue, Jun 07, 2016 at 07:37:09PM -0700, Stefan Agner wrote:
> +&lcdif {
> +	status = "okay";
> +	display = <&display0>;

Please put 'status' at the bottom of property list.

> +
> +	display0: lcd-display {
> +		bits-per-pixel = <16>;
> +		bus-width = <18>;
> +
> +		display-timings {
> +			native-mode = <&timing_vga>;
> +
> +			/* Standard VGA timing */
> +			timing_vga: 640x480 {
> +				clock-frequency = <25175000>;
> +				hactive = <640>;
> +				vactive = <480>;
> +				hback-porch = <40>;
> +				hfront-porch = <24>;
> +				vback-porch = <32>;
> +				vfront-porch = <11>;
> +				hsync-len = <96>;
> +				vsync-len = <2>;
> +				de-active = <1>;
> +				hsync-active = <0>;
> +				vsync-active = <0>;
> +				pixelclk-active = <0>;
> +			};
> +		};
> +	};
> +};

<snip>

> +&usdhc1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_usdhc1 &pinctrl_cd_usdhc1>;
> +	no-1-8-v;
> +	cd-gpios = <&gpio1 0 0>;

Use the macro in include/dt-bindings/gpio/gpio.h.

> +	enable-sdio-wakeup;

This is deprecated.  Please use wakeup-source instead.

> +	fsl,tuning-step = <2>;
> +	keep-power-in-suspend;
> +	status = "okay";
> +};

<snip>

> +&fec1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_enet1>;
> +	clocks = <&clks IMX7D_ENET_AXI_ROOT_CLK>,
> +		<&clks IMX7D_ENET_AXI_ROOT_CLK>,
> +		<&clks IMX7D_ENET1_TIME_ROOT_CLK>,
> +		<&clks IMX7D_PLL_ENET_MAIN_50M_CLK>;
> +	clock-names = "ipg", "ahb", "ptp", "enet_clk_ref";
> +

Drop this newline.

> +	assigned-clocks = <&clks IMX7D_ENET1_TIME_ROOT_SRC>,
> +			  <&clks IMX7D_ENET1_TIME_ROOT_CLK>;
> +	assigned-clock-parents = <&clks IMX7D_PLL_ENET_MAIN_100M_CLK>;
> +	assigned-clock-rates = <0>, <100000000>;
> +	phy-mode = "rmii";
> +	phy-supply = <&reg_LDO1>;
> +	fsl,magic-packet;
> +};

<snip>

> +&uart1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_uart1 &pinctrl_uart1_ctrl1 &pinctrl_uart1_ctrl2>;
> +	assigned-clocks = <&clks IMX7D_UART1_ROOT_SRC>;
> +	assigned-clock-parents = <&clks IMX7D_OSC_24M_CLK>;
> +	fsl,uart-has-rtscts;

Please use generic 'uart-has-rtscts' instead.

> +	fsl,dte-mode;
> +};
> +
> +&uart2 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_uart2>;
> +	assigned-clocks = <&clks IMX7D_UART2_ROOT_SRC>;
> +	assigned-clock-parents = <&clks IMX7D_OSC_24M_CLK>;
> +	fsl,uart-has-rtscts;

Ditto

> +	fsl,dte-mode;
> +};

<snip>

> +/ {
> +	model = "Toradex Colibri iMX7D on Colibri Evaluation Board V3";
> +	compatible = "toradex,colibri_imx7d-eval", "toradex,colibri_imx7d", \

We always use hyphen than underscore in compatible string.

> +		     "fsl,imx7d";
> +
> +	reg_usb_otg2_vbus: regulator-usb-otg2-vbus {
> +		compatible = "regulator-fixed";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_usbotg2_reg>;
> +		regulator-name = "VCC_USB[1-4]";
> +		regulator-min-microvolt = <5000000>;
> +		regulator-max-microvolt = <5000000>;
> +		gpio = <&gpio4 7 GPIO_ACTIVE_LOW>;
> +	};
> +};
> +/ {
> +	model = "Toradex Colibri iMX7S on Colibri Evaluation Board V3";
> +	compatible = "toradex,colibri_imx7s-eval", "toradex,colibri_imx7s", \
> +		     "fsl,imx7s", "fsl,imx7d";

You may not want to have "fsl,imx7d" here.  Otherwise, the detection
between  imx7s and imx7d colibri-eval-v3 board will be difficult.

Shawn

> +};

[toc] | [next] | [standalone]

#1423687

FromStefan Agner <stefan@agner.ch>
Date2016-06-16 07:50 +0200
Message-ID<rKylH-4js-7@gated-at.bofh.it>
In reply to#1420131
On 2016-06-11 19:31, Shawn Guo wrote:
> On Tue, Jun 07, 2016 at 07:37:09PM -0700, Stefan Agner wrote:
>> +&lcdif {
>> +	status = "okay";
>> +	display = <&display0>;
> 
> Please put 'status' at the bottom of property list.
> 
>> +
>> +	display0: lcd-display {
>> +		bits-per-pixel = <16>;
>> +		bus-width = <18>;
>> +
>> +		display-timings {
>> +			native-mode = <&timing_vga>;
>> +
>> +			/* Standard VGA timing */
>> +			timing_vga: 640x480 {
>> +				clock-frequency = <25175000>;
>> +				hactive = <640>;
>> +				vactive = <480>;
>> +				hback-porch = <40>;
>> +				hfront-porch = <24>;
>> +				vback-porch = <32>;
>> +				vfront-porch = <11>;
>> +				hsync-len = <96>;
>> +				vsync-len = <2>;
>> +				de-active = <1>;
>> +				hsync-active = <0>;
>> +				vsync-active = <0>;
>> +				pixelclk-active = <0>;
>> +			};
>> +		};
>> +	};
>> +};
> 
> <snip>
> 
>> +&usdhc1 {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_usdhc1 &pinctrl_cd_usdhc1>;
>> +	no-1-8-v;
>> +	cd-gpios = <&gpio1 0 0>;
> 
> Use the macro in include/dt-bindings/gpio/gpio.h.
> 
>> +	enable-sdio-wakeup;
> 
> This is deprecated.  Please use wakeup-source instead.
> 
>> +	fsl,tuning-step = <2>;
>> +	keep-power-in-suspend;
>> +	status = "okay";
>> +};
> 
> <snip>
> 
>> +&fec1 {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_enet1>;
>> +	clocks = <&clks IMX7D_ENET_AXI_ROOT_CLK>,
>> +		<&clks IMX7D_ENET_AXI_ROOT_CLK>,
>> +		<&clks IMX7D_ENET1_TIME_ROOT_CLK>,
>> +		<&clks IMX7D_PLL_ENET_MAIN_50M_CLK>;
>> +	clock-names = "ipg", "ahb", "ptp", "enet_clk_ref";
>> +
> 
> Drop this newline.
> 
>> +	assigned-clocks = <&clks IMX7D_ENET1_TIME_ROOT_SRC>,
>> +			  <&clks IMX7D_ENET1_TIME_ROOT_CLK>;
>> +	assigned-clock-parents = <&clks IMX7D_PLL_ENET_MAIN_100M_CLK>;
>> +	assigned-clock-rates = <0>, <100000000>;
>> +	phy-mode = "rmii";
>> +	phy-supply = <&reg_LDO1>;
>> +	fsl,magic-packet;
>> +};
> 
> <snip>
> 
>> +&uart1 {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_uart1 &pinctrl_uart1_ctrl1 &pinctrl_uart1_ctrl2>;
>> +	assigned-clocks = <&clks IMX7D_UART1_ROOT_SRC>;
>> +	assigned-clock-parents = <&clks IMX7D_OSC_24M_CLK>;
>> +	fsl,uart-has-rtscts;
> 
> Please use generic 'uart-has-rtscts' instead.
> 
>> +	fsl,dte-mode;
>> +};
>> +
>> +&uart2 {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_uart2>;
>> +	assigned-clocks = <&clks IMX7D_UART2_ROOT_SRC>;
>> +	assigned-clock-parents = <&clks IMX7D_OSC_24M_CLK>;
>> +	fsl,uart-has-rtscts;
> 
> Ditto
> 
>> +	fsl,dte-mode;
>> +};

Agreed on all the stuff above.

> 
> <snip>
> 
>> +/ {
>> +	model = "Toradex Colibri iMX7D on Colibri Evaluation Board V3";
>> +	compatible = "toradex,colibri_imx7d-eval", "toradex,colibri_imx7d", \
> 
> We always use hyphen than underscore in compatible string.

We always used underscores, this goes back to the first Colibri specific
device tree: tegra20-iris-512.dts.

I would rather prefer to not change this for the sake of consistency...
What do you think?

> 
>> +		     "fsl,imx7d";
>> +
>> +	reg_usb_otg2_vbus: regulator-usb-otg2-vbus {
>> +		compatible = "regulator-fixed";
>> +		pinctrl-names = "default";
>> +		pinctrl-0 = <&pinctrl_usbotg2_reg>;
>> +		regulator-name = "VCC_USB[1-4]";
>> +		regulator-min-microvolt = <5000000>;
>> +		regulator-max-microvolt = <5000000>;
>> +		gpio = <&gpio4 7 GPIO_ACTIVE_LOW>;
>> +	};
>> +};
>> +/ {
>> +	model = "Toradex Colibri iMX7S on Colibri Evaluation Board V3";
>> +	compatible = "toradex,colibri_imx7s-eval", "toradex,colibri_imx7s", \
>> +		     "fsl,imx7s", "fsl,imx7d";
> 
> You may not want to have "fsl,imx7d" here.  Otherwise, the detection
> between  imx7s and imx7d colibri-eval-v3 board will be difficult.

Yeah my idea behind this is that "imx7d" is still kind of the base name
of that SoC. But I agree for the bindings it does not make that much
sense.

I have to add imx7s to arch/arm/mach-imx/mach-imx7d.c though.

--
Stefan

[toc] | [prev] | [next] | [standalone]

#1423937

FromMarcel Ziswiler <marcel.ziswiler@toradex.com>
Date2016-06-16 13:00 +0200
Message-ID<rKDbI-7iC-13@gated-at.bofh.it>
In reply to#1423687
Sali Stefan

On Wed, 2016-06-15 at 22:37 -0700, Stefan Agner wrote:
> On 2016-06-11 19:31, Shawn Guo wrote:
> > 
> > On Tue, Jun 07, 2016 at 07:37:09PM -0700, Stefan Agner wrote:
> > > 
> > <snip>
> > > 
> > > +/ {
> > > +	model = "Toradex Colibri iMX7D on Colibri Evaluation
> > > Board V3";
> > > +	compatible = "toradex,colibri_imx7d-eval",
> > > "toradex,colibri_imx7d", \
> > We always use hyphen than underscore in compatible string.
> We always used underscores, this goes back to the first Colibri
> specific
> device tree: tegra20-iris-512.dts.
> 
> I would rather prefer to not change this for the sake of
> consistency...
> What do you think?

I have been there before when submitting a first Apalis TK1 version:

https://lkml.org/lkml/2016/5/16/288

Upon Rob Herring's suggestion I changed it now all to dashes:

https://lkml.org/lkml/2016/5/27/399

Even in our downstream U-Boot:

http://git.toradex.com/cgit/u-boot-toradex.git/commit/?h=2015.04-torade
x-next&id=4ae2e657f3350422ad81b1632de156bdd9517206

Of course for Colibri iMX7 one could argue that we already sold a
couple hundred pieces still using underscores. However I guess we could
still change to dashes now as those were all prototype, sample and/or
beta.

Cheers

Marcel

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web