Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1423385 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2016-06-15 22:20 +0200 |
| Last post | 2016-06-15 23:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] amdgpu: use NULL instead of 0 for pointer Arnd Bergmann <arnd@arndb.de> - 2016-06-15 22:20 +0200
Re: [PATCH] amdgpu: use NULL instead of 0 for pointer Alex Deucher <alexdeucher@gmail.com> - 2016-06-15 23:30 +0200
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-06-15 22:20 +0200 |
| Subject | [PATCH] amdgpu: use NULL instead of 0 for pointer |
| Message-ID | <rKps6-77R-21@gated-at.bofh.it> |
In the AMD powerplay driver, a pointer is checked for validity by comparing against an integer '0', which causes a harmless warning when building with "make W=1": drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/processpptables.c:1502:16: error: ordered comparison of pointer with integer zero [-Werror=extra] This changes the code to the more conventional "if (pointer)" check. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c b/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c index 2f1a14fe05b1..b64f42d2c3ae 100644 --- a/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c @@ -1499,7 +1499,7 @@ int get_number_of_vce_state_table_entries( const ATOM_PPLIB_VCE_State_Table *vce_table = get_vce_state_table(hwmgr, table); - if (vce_table > 0) + if (vce_table) return vce_table->numEntries; return 0; -- 2.9.0
[toc] | [next] | [standalone]
| From | Alex Deucher <alexdeucher@gmail.com> |
|---|---|
| Date | 2016-06-15 23:30 +0200 |
| Message-ID | <rKqxQ-7NH-23@gated-at.bofh.it> |
| In reply to | #1423385 |
On Wed, Jun 15, 2016 at 4:32 PM, Christian König <christian.koenig@amd.com> wrote: > Am 15.06.2016 um 22:15 schrieb Arnd Bergmann: >> >> In the AMD powerplay driver, a pointer is checked for validity by >> comparing against an integer '0', which causes a harmless warning >> when building with "make W=1": >> >> drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/processpptables.c:1502:16: >> error: ordered comparison of pointer with integer zero [-Werror=extra] >> >> This changes the code to the more conventional "if (pointer)" check. >> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > > Reviewed-by: Christian König <christian.koenig@amd.com>. Applied. thanks! Alex > >> --- >> drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c >> b/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c >> index 2f1a14fe05b1..b64f42d2c3ae 100644 >> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c >> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c >> @@ -1499,7 +1499,7 @@ int get_number_of_vce_state_table_entries( >> const ATOM_PPLIB_VCE_State_Table *vce_table = >> get_vce_state_table(hwmgr, table); >> - if (vce_table > 0) >> + if (vce_table) >> return vce_table->numEntries; >> return 0; > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web