Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1423277 > unrolled thread
| Started by | Matt Wilson <msw@amzn.com> |
|---|---|
| First post | 2016-06-15 20:10 +0200 |
| Last post | 2016-06-15 20:40 +0200 |
| Articles | 3 — 1 participant |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA) Matt Wilson <msw@amzn.com> - 2016-06-15 20:10 +0200
Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA) Matt Wilson <msw@amzn.com> - 2016-06-15 20:30 +0200
Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA) Matt Wilson <msw@amzn.com> - 2016-06-15 20:40 +0200
| From | Matt Wilson <msw@amzn.com> |
|---|---|
| Date | 2016-06-15 20:10 +0200 |
| Subject | Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA) |
| Message-ID | <rKnqh-5W3-7@gated-at.bofh.it> |
On Mon, Jun 13, 2016 at 11:46:13AM +0300, Netanel Belgazal wrote:
> This is a driver for the forthcoming ENA family of networking devices.
>
> Signed-off-by: Netanel Belgazal <netanel@annapurnalabs.com>
[...]
> +
> +struct ena_napi {
> + struct napi_struct napi ____cacheline_aligned;
> + struct ena_ring *tx_ring;
> + struct ena_ring *rx_ring;
> +#ifndef HAVE_NETDEV_NAPI_LIST
> + struct net_device poll_dev;
> +#endif /* HAVE_NETDEV_NAPI_LIST */
> + u32 qid;
> +};
Netanel,
Sorry I missed this when I read through the patch earlier this week
(though I pointed it out before...). This "#ifndef
HAVE_NETDEV_NAPI_LIST" bit needs to be removed for the in-tree
version.
You also had a few typos in the email addresses on the Cc: line that
I've corrected (davm@avemeloft.net -> davem@davemeloft.net,
aligouri@amazon.com -> aliguori@amazon.com). Please make sure to
correct in your v2 patch.
--msw
[toc] | [next] | [standalone]
| From | Matt Wilson <msw@amzn.com> |
|---|---|
| Date | 2016-06-15 20:30 +0200 |
| Message-ID | <rKnJE-62T-17@gated-at.bofh.it> |
| In reply to | #1423277 |
On Wed, Jun 15, 2016 at 11:07:17AM -0700, Matt Wilson wrote: > > You also had a few typos in the email addresses on the Cc: line that > I've corrected (davm@avemeloft.net -> davem@davemeloft.net, Argh, and of course I typo'ed the correction. -> davem@davemloft.net. --msw
[toc] | [prev] | [next] | [standalone]
| From | Matt Wilson <msw@amzn.com> |
|---|---|
| Date | 2016-06-15 20:40 +0200 |
| Message-ID | <rKnTj-668-19@gated-at.bofh.it> |
| In reply to | #1423309 |
On Wed, Jun 15, 2016 at 09:32:35PM +0300, Netanel Belgazal wrote: > I removed HAVE_NETDEV_NAPI_LIST and fixed the ena print macro. > I'll wait a bit to see if there are additional comment before I'll send the > v2 patch. Also, please don't top post (reply inline) and send emails as plain text only. Have a look at [1] for how to set up a mailer like mutt with Gmail. --msw [1] https://www.kernel.org/doc/Documentation/email-clients.txt > On 15 June 2016 at 21:22, Matt Wilson <msw@amzn.com> wrote: > > > On Wed, Jun 15, 2016 at 11:07:17AM -0700, Matt Wilson wrote: > > > > > > You also had a few typos in the email addresses on the Cc: line that > > > I've corrected (davm@avemeloft.net -> davem@davemeloft.net, > > > > Argh, and of course I typo'ed the correction. -> davem@davemloft.net. > > > > --msw > >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web