Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1423130 > unrolled thread

[PATCH] kprobes: fix a comment typo

Started byJinbum Park <jinb.park7@gmail.com>
First post2016-06-15 17:20 +0200
Last post2016-06-15 23:40 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] kprobes: fix a comment typo Jinbum Park <jinb.park7@gmail.com> - 2016-06-15 17:20 +0200
    Re: [PATCH] kprobes: fix a comment typo Masami Hiramatsu <mhiramat@kernel.org> - 2016-06-15 23:40 +0200

#1423130 — [PATCH] kprobes: fix a comment typo

FromJinbum Park <jinb.park7@gmail.com>
Date2016-06-15 17:20 +0200
Subject[PATCH] kprobes: fix a comment typo
Message-ID<rKkLL-4en-15@gated-at.bofh.it>
Just fix a typo in the code comment.

Signed-off-by: Jinbum Park <jinb.park7@gmail.com>
---
 arch/arm/probes/kprobes/opt-arm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/probes/kprobes/opt-arm.c b/arch/arm/probes/kprobes/opt-arm.c
index bcdecc2..073c0ba 100644
--- a/arch/arm/probes/kprobes/opt-arm.c
+++ b/arch/arm/probes/kprobes/opt-arm.c
@@ -223,7 +223,7 @@ int arch_prepare_optimized_kprobe(struct optimized_kprobe *op, struct kprobe *or
 	 *
 	 * So the maximum forward branch should be:
 	 *   (0x007fffff << 2) = 0x01fffffc =  0x1fffffc
-	 * The maximum backword branch should be:
+	 * The maximum backward branch should be:
 	 *   (0xff800000 << 2) = 0xfe000000 = -0x2000000
 	 *
 	 * We can simply check (rel & 0xfe000003):
-- 
1.9.1

[toc] | [next] | [standalone]


#1423474

FromMasami Hiramatsu <mhiramat@kernel.org>
Date2016-06-15 23:40 +0200
Message-ID<rKqHw-7SL-37@gated-at.bofh.it>
In reply to#1423130
On Thu, 16 Jun 2016 00:19:22 +0900
Jinbum Park <jinb.park7@gmail.com> wrote:

> Just fix a typo in the code comment.

Thanks :)

Acked-by: Masami Hiramatsu <mhiramat@kernel.org>

> 
> Signed-off-by: Jinbum Park <jinb.park7@gmail.com>
> ---
>  arch/arm/probes/kprobes/opt-arm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/probes/kprobes/opt-arm.c b/arch/arm/probes/kprobes/opt-arm.c
> index bcdecc2..073c0ba 100644
> --- a/arch/arm/probes/kprobes/opt-arm.c
> +++ b/arch/arm/probes/kprobes/opt-arm.c
> @@ -223,7 +223,7 @@ int arch_prepare_optimized_kprobe(struct optimized_kprobe *op, struct kprobe *or
>  	 *
>  	 * So the maximum forward branch should be:
>  	 *   (0x007fffff << 2) = 0x01fffffc =  0x1fffffc
> -	 * The maximum backword branch should be:
> +	 * The maximum backward branch should be:
>  	 *   (0xff800000 << 2) = 0xfe000000 = -0x2000000
>  	 *
>  	 * We can simply check (rel & 0xfe000003):
> -- 
> 1.9.1
> 


-- 
Masami Hiramatsu <mhiramat@kernel.org>

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web