Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1422832 > unrolled thread
| Started by | Benjamin Tissoires <benjamin.tissoires@redhat.com> |
|---|---|
| First post | 2016-06-15 11:40 +0200 |
| Last post | 2016-06-15 11:40 +0200 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 5/7] Input: synaptics-rmi4: Remove pointer to rmi_function in f12_data Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-06-15 11:40 +0200
| From | Benjamin Tissoires <benjamin.tissoires@redhat.com> |
|---|---|
| Date | 2016-06-15 11:40 +0200 |
| Subject | Re: [PATCH 5/7] Input: synaptics-rmi4: Remove pointer to rmi_function in f12_data |
| Message-ID | <rKfsK-Lj-27@gated-at.bofh.it> |
On Jun 03 2016 or thereabouts, Andrew Duggan wrote:
> The pointer to struct rmi_function in f12_data is never set and was never
> used. The fn pointer is also stored in rmi_2d_sensor which is a member of
> f12_data.
>
> Signed-off-by: Andrew Duggan <aduggan@synaptics.com>
> ---
If it compiles, you are OK :)
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cheers,
Benjamin
> drivers/input/rmi4/rmi_f12.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/rmi4/rmi_f12.c b/drivers/input/rmi4/rmi_f12.c
> index 041a91d..7d66766 100644
> --- a/drivers/input/rmi4/rmi_f12.c
> +++ b/drivers/input/rmi4/rmi_f12.c
> @@ -27,7 +27,6 @@ enum rmi_f12_object_type {
> };
>
> struct f12_data {
> - struct rmi_function *fn;
> struct rmi_2d_sensor sensor;
> struct rmi_2d_sensor_platform_data sensor_pdata;
> bool has_dribble;
> --
> 2.5.0
>
Back to top | Article view | linux.kernel
csiph-web