Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1422846 > unrolled thread
| Started by | Alexander Potapenko <glider@google.com> |
|---|---|
| First post | 2016-06-15 12:00 +0200 |
| Last post | 2016-06-15 12:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] arm64: allow building with kcov coverage on ARM64 Alexander Potapenko <glider@google.com> - 2016-06-15 12:00 +0200
Re: [PATCH] arm64: allow building with kcov coverage on ARM64 Marc Zyngier <marc.zyngier@arm.com> - 2016-06-15 12:50 +0200
| From | Alexander Potapenko <glider@google.com> |
|---|---|
| Date | 2016-06-15 12:00 +0200 |
| Subject | [PATCH] arm64: allow building with kcov coverage on ARM64 |
| Message-ID | <rKfM6-Te-17@gated-at.bofh.it> |
Add ARCH_HAS_KCOV to ARM64 config. To avoid potential crashes, disable
instrumentation of the files in arch/arm64/kvm/hyp/*.
Signed-off-by: Alexander Potapenko <glider@google.com>
Acked-by: Mark Rutland <mark.rutland@arm.com>
---
v3: - reverted arch/arm64/boot/Makefile, there's no code in that dir
- added ack from Mark Rutland
v2: - disable instrumentation of arch/arm64/{boot,kvm/hyp}
- enable instrumentation of arch/arm64/lib/delay.c
---
arch/arm64/Kconfig | 1 +
arch/arm64/kvm/hyp/Makefile | 4 ++++
2 files changed, 5 insertions(+)
diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index 5a0a691..eb0b0a0 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -7,6 +7,7 @@ config ARM64
select ARCH_HAS_ATOMIC64_DEC_IF_POSITIVE
select ARCH_HAS_ELF_RANDOMIZE
select ARCH_HAS_GCOV_PROFILE_ALL
+ select ARCH_HAS_KCOV
select ARCH_HAS_SG_CHAIN
select ARCH_HAS_TICK_BROADCAST if GENERIC_CLOCKEVENTS_BROADCAST
select ARCH_USE_CMPXCHG_LOCKREF
diff --git a/arch/arm64/kvm/hyp/Makefile b/arch/arm64/kvm/hyp/Makefile
index 778d0ef..0c85feb 100644
--- a/arch/arm64/kvm/hyp/Makefile
+++ b/arch/arm64/kvm/hyp/Makefile
@@ -17,6 +17,10 @@ obj-$(CONFIG_KVM_ARM_HOST) += tlb.o
obj-$(CONFIG_KVM_ARM_HOST) += hyp-entry.o
obj-$(CONFIG_KVM_ARM_HOST) += s2-setup.o
+# KVM code is run at a different exception code with a different map, so
+# compiler instrumentation that inserts callbacks or checks into the code may
+# cause crashes. Just disable it.
GCOV_PROFILE := n
KASAN_SANITIZE := n
UBSAN_SANITIZE := n
+KCOV_INSTRUMENT := n
--
2.8.0.rc3.226.g39d4020
[toc] | [next] | [standalone]
| From | Marc Zyngier <marc.zyngier@arm.com> |
|---|---|
| Date | 2016-06-15 12:50 +0200 |
| Message-ID | <rKgyt-1rv-3@gated-at.bofh.it> |
| In reply to | #1422846 |
On Wed, 15 Jun 2016 11:55:23 +0200 Alexander Potapenko <glider@google.com> wrote: > Add ARCH_HAS_KCOV to ARM64 config. To avoid potential crashes, disable > instrumentation of the files in arch/arm64/kvm/hyp/*. > > Signed-off-by: Alexander Potapenko <glider@google.com> > Acked-by: Mark Rutland <mark.rutland@arm.com> Acked-by: Marc Zyngier <marc.zyngier@arm.com> M. -- Jazz is not dead. It just smells funny.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web