Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1422586 > unrolled thread

[PATCH -next] Revert "clocksource/drivers/timer-atmel-st: Add the COMPILE_TEST option"

Started byGuenter Roeck <linux@roeck-us.net>
First post2016-06-15 06:10 +0200
Last post2016-06-16 14:20 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH -next] Revert "clocksource/drivers/timer-atmel-st: Add the COMPILE_TEST option" Guenter Roeck <linux@roeck-us.net> - 2016-06-15 06:10 +0200
    Re: [PATCH -next] Revert "clocksource/drivers/timer-atmel-st: Add the  COMPILE_TEST option" Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-06-16 14:20 +0200

#1422586 — [PATCH -next] Revert "clocksource/drivers/timer-atmel-st: Add the COMPILE_TEST option"

FromGuenter Roeck <linux@roeck-us.net>
Date2016-06-15 06:10 +0200
Subject[PATCH -next] Revert "clocksource/drivers/timer-atmel-st: Add the COMPILE_TEST option"
Message-ID<rKajn-5WF-3@gated-at.bofh.it>
This reverts commit 7011a4947ca61cd28a8c025b39c98861687e4fb6.

When trying to build parisc:allmodconfig:

drivers/clocksource/timer-atmel-st.c: In function 'at91rm9200_timer_interrupt':
drivers/clocksource/timer-atmel-st.c:76:3: error:
	invalid use of undefined type 'struct clock_event_device'

Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 drivers/clocksource/Kconfig | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index 0677e81af030..5a921dc913e5 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -335,11 +335,9 @@ config ATMEL_PIT
 	def_bool SOC_AT91SAM9 || SOC_SAMA5
 
 config ATMEL_ST
-	bool "Atmel ST timer support" if COMPILE_TEST
+	bool
 	select CLKSRC_OF
 	select MFD_SYSCON
-	help
-	  Support for the Atmel ST timer.
 
 config CLKSRC_METAG_GENERIC
 	def_bool y if METAG
-- 
2.5.0

[toc] | [next] | [standalone]


#1423997 — Re: [PATCH -next] Revert "clocksource/drivers/timer-atmel-st: Add the COMPILE_TEST option"

FromDaniel Lezcano <daniel.lezcano@linaro.org>
Date2016-06-16 14:20 +0200
SubjectRe: [PATCH -next] Revert "clocksource/drivers/timer-atmel-st: Add the COMPILE_TEST option"
Message-ID<rKEr8-8fX-17@gated-at.bofh.it>
In reply to#1422586
On 06/15/2016 06:01 AM, Guenter Roeck wrote:
> This reverts commit 7011a4947ca61cd28a8c025b39c98861687e4fb6.
>
> When trying to build parisc:allmodconfig:
>
> drivers/clocksource/timer-atmel-st.c: In function 'at91rm9200_timer_interrupt':
> drivers/clocksource/timer-atmel-st.c:76:3: error:
> 	invalid use of undefined type 'struct clock_event_device'
>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---

Thanks for reporting the issue. I fixed this issue by adding

+depends on GENERIC_CLOCKEVENTS

instead of reverting the patch.

   -- Daniel

-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web