Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1424932 > unrolled thread
| Started by | Enric Balletbo i Serra <enric.balletbo@collabora.com> |
|---|---|
| First post | 2016-06-17 13:00 +0200 |
| Last post | 2016-06-17 15:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 1/2] watchdog: ziirave_wdt: Correct I2C device id to fix module autoloading. Enric Balletbo i Serra <enric.balletbo@collabora.com> - 2016-06-17 13:00 +0200
Re: [PATCH 1/2] watchdog: ziirave_wdt: Correct I2C device id to fix module autoloading. Guenter Roeck <linux@roeck-us.net> - 2016-06-17 15:30 +0200
| From | Enric Balletbo i Serra <enric.balletbo@collabora.com> |
|---|---|
| Date | 2016-06-17 13:00 +0200 |
| Subject | [PATCH 1/2] watchdog: ziirave_wdt: Correct I2C device id to fix module autoloading. |
| Message-ID | <rKZFf-5tp-1@gated-at.bofh.it> |
The I2C core removes the manufacturer prefix from the compatible field
so it reports to user-space the uevent i2c:rave-wdt, but this doesn't
match with the i2c_device_id (i2c:ziirave-wdt) array so the module is not
autoloaded. Correct the I2C device id to match with the reported uevent
and fix the module autoloading functionality.
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---
drivers/watchdog/ziirave_wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/ziirave_wdt.c b/drivers/watchdog/ziirave_wdt.c
index cbe373de..fa1efef 100644
--- a/drivers/watchdog/ziirave_wdt.c
+++ b/drivers/watchdog/ziirave_wdt.c
@@ -339,7 +339,7 @@ static int ziirave_wdt_remove(struct i2c_client *client)
}
static struct i2c_device_id ziirave_wdt_id[] = {
- { "ziirave-wdt", 0 },
+ { "rave-wdt", 0 },
{ }
};
MODULE_DEVICE_TABLE(i2c, ziirave_wdt_id);
--
2.1.0
[toc] | [next] | [standalone]
| From | Guenter Roeck <linux@roeck-us.net> |
|---|---|
| Date | 2016-06-17 15:30 +0200 |
| Subject | Re: [PATCH 1/2] watchdog: ziirave_wdt: Correct I2C device id to fix module autoloading. |
| Message-ID | <rL20q-73O-33@gated-at.bofh.it> |
| In reply to | #1424932 |
On 06/17/2016 03:52 AM, Enric Balletbo i Serra wrote:
> The I2C core removes the manufacturer prefix from the compatible field
> so it reports to user-space the uevent i2c:rave-wdt, but this doesn't
> match with the i2c_device_id (i2c:ziirave-wdt) array so the module is not
> autoloaded. Correct the I2C device id to match with the reported uevent
> and fix the module autoloading functionality.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/ziirave_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/ziirave_wdt.c b/drivers/watchdog/ziirave_wdt.c
> index cbe373de..fa1efef 100644
> --- a/drivers/watchdog/ziirave_wdt.c
> +++ b/drivers/watchdog/ziirave_wdt.c
> @@ -339,7 +339,7 @@ static int ziirave_wdt_remove(struct i2c_client *client)
> }
>
> static struct i2c_device_id ziirave_wdt_id[] = {
> - { "ziirave-wdt", 0 },
> + { "rave-wdt", 0 },
> { }
> };
> MODULE_DEVICE_TABLE(i2c, ziirave_wdt_id);
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web