Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1423972 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2016-06-16 13:40 +0200 |
| Last post | 2016-06-17 02:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 2/5] net: tlan: don't set unused function argument Arnd Bergmann <arnd@arndb.de> - 2016-06-16 13:40 +0200
Re: [PATCH 2/5] net: tlan: don't set unused function argument David Miller <davem@davemloft.net> - 2016-06-17 02:40 +0200
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-06-16 13:40 +0200 |
| Subject | [PATCH 2/5] net: tlan: don't set unused function argument |
| Message-ID | <rKDOp-7Nv-5@gated-at.bofh.it> |
We get a warning for tlan_handle_tx_eoc when building with "make W=1"
drivers/net/ethernet/ti/tlan.c: In function 'tlan_handle_tx_eoc':
drivers/net/ethernet/ti/tlan.c:1647:59: error: parameter 'host_int' set but not used [-Werror=unused-but-set-parameter]
static u32 tlan_handle_tx_eoc(struct net_device *dev, u16 host_int)
This is harmless, but removing the unused assignment lets us avoid
the warning with no downside.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/ethernet/ti/tlan.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/ti/tlan.c b/drivers/net/ethernet/ti/tlan.c
index 561703317312..ece0ea0f6b38 100644
--- a/drivers/net/ethernet/ti/tlan.c
+++ b/drivers/net/ethernet/ti/tlan.c
@@ -1651,7 +1651,6 @@ static u32 tlan_handle_tx_eoc(struct net_device *dev, u16 host_int)
dma_addr_t head_list_phys;
u32 ack = 1;
- host_int = 0;
if (priv->tlan_rev < 0x30) {
TLAN_DBG(TLAN_DEBUG_TX,
"TRANSMIT: handling TX EOC (Head=%d Tail=%d) -- IRQ\n",
--
2.9.0
[toc] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2016-06-17 02:40 +0200 |
| Message-ID | <rKPZf-7Fj-15@gated-at.bofh.it> |
| In reply to | #1423972 |
From: Arnd Bergmann <arnd@arndb.de> Date: Thu, 16 Jun 2016 13:38:23 +0200 > We get a warning for tlan_handle_tx_eoc when building with "make W=1" > > drivers/net/ethernet/ti/tlan.c: In function 'tlan_handle_tx_eoc': > drivers/net/ethernet/ti/tlan.c:1647:59: error: parameter 'host_int' set but not used [-Werror=unused-but-set-parameter] > static u32 tlan_handle_tx_eoc(struct net_device *dev, u16 host_int) > > This is harmless, but removing the unused assignment lets us avoid > the warning with no downside. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Applied to net-next.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web