Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1424390 > unrolled thread

[PATCH] MIPS: Lantiq: fix build failure

Back to article view | Back to linux.kernel

Contents

  [PATCH] MIPS: Lantiq: fix build failure Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-06-16 22:50 +0200
    Re: [PATCH] MIPS: Lantiq: fix build failure John Crispin <john@phrozen.org> - 2016-06-17 10:50 +0200

#1424390 — [PATCH] MIPS: Lantiq: fix build failure

Some configs of mips like xway_defconffig are failing with the error:
arch/mips/lantiq/irq.c:209:2: error: initialization from incompatible
pointer type [-Werror]
  "icu",
  ^
arch/mips/lantiq/irq.c:209:2: error: (near initialization for
'ltq_irq_type.parent_device') [-Werror]
arch/mips/lantiq/irq.c:219:2: error: initialization from incompatible
pointer type [-Werror]
  "eiu",
  ^
arch/mips/lantiq/irq.c:219:2: error: (near initialization for
'ltq_eiu_type.parent_device') [-Werror]

The first member of the "struct irq" is no longer a pointer for the
name.

Fixes: be45beb2df69 ("genirq: Add runtime power management support for IRQ chips")
Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
---

build log can be seen at:
https://travis-ci.org/sudipm-mukherjee/parport/jobs/137992701

 arch/mips/lantiq/irq.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/mips/lantiq/irq.c b/arch/mips/lantiq/irq.c
index ff17669e..02c0252 100644
--- a/arch/mips/lantiq/irq.c
+++ b/arch/mips/lantiq/irq.c
@@ -206,7 +206,7 @@ static void ltq_shutdown_eiu_irq(struct irq_data *d)
 }
 
 static struct irq_chip ltq_irq_type = {
-	"icu",
+	.name = "icu",
 	.irq_enable = ltq_enable_irq,
 	.irq_disable = ltq_disable_irq,
 	.irq_unmask = ltq_enable_irq,
@@ -216,7 +216,7 @@ static struct irq_chip ltq_irq_type = {
 };
 
 static struct irq_chip ltq_eiu_type = {
-	"eiu",
+	.name = "eiu",
 	.irq_startup = ltq_startup_eiu_irq,
 	.irq_shutdown = ltq_shutdown_eiu_irq,
 	.irq_enable = ltq_enable_irq,
-- 
1.9.1

[toc] | [next] | [standalone]

#1424819

On 16/06/2016 22:46, Sudip Mukherjee wrote:
> Some configs of mips like xway_defconffig are failing with the error:
> arch/mips/lantiq/irq.c:209:2: error: initialization from incompatible
> pointer type [-Werror]
>   "icu",
>   ^
> arch/mips/lantiq/irq.c:209:2: error: (near initialization for
> 'ltq_irq_type.parent_device') [-Werror]
> arch/mips/lantiq/irq.c:219:2: error: initialization from incompatible
> pointer type [-Werror]
>   "eiu",
>   ^
> arch/mips/lantiq/irq.c:219:2: error: (near initialization for
> 'ltq_eiu_type.parent_device') [-Werror]
> 
> The first member of the "struct irq" is no longer a pointer for the
> name.
> 
> Fixes: be45beb2df69 ("genirq: Add runtime power management support for IRQ chips")
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>

Acked-by: John Crispin <john@phrozen.org>

> ---
> 
> build log can be seen at:
> https://travis-ci.org/sudipm-mukherjee/parport/jobs/137992701
> 
>  arch/mips/lantiq/irq.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/mips/lantiq/irq.c b/arch/mips/lantiq/irq.c
> index ff17669e..02c0252 100644
> --- a/arch/mips/lantiq/irq.c
> +++ b/arch/mips/lantiq/irq.c
> @@ -206,7 +206,7 @@ static void ltq_shutdown_eiu_irq(struct irq_data *d)
>  }
>  
>  static struct irq_chip ltq_irq_type = {
> -	"icu",
> +	.name = "icu",
>  	.irq_enable = ltq_enable_irq,
>  	.irq_disable = ltq_disable_irq,
>  	.irq_unmask = ltq_enable_irq,
> @@ -216,7 +216,7 @@ static struct irq_chip ltq_irq_type = {
>  };
>  
>  static struct irq_chip ltq_eiu_type = {
> -	"eiu",
> +	.name = "eiu",
>  	.irq_startup = ltq_startup_eiu_irq,
>  	.irq_shutdown = ltq_shutdown_eiu_irq,
>  	.irq_enable = ltq_enable_irq,
> 

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web