Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1424117 > unrolled thread

Re: [PATCH 1/3] include/linux/mfd/intel_soc_pmic.h: add new data structures

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 1/3] include/linux/mfd/intel_soc_pmic.h: add new data  structures Lee Jones <lee.jones@linaro.org> - 2016-06-16 16:30 +0200
    Re: [PATCH 1/3] include/linux/mfd/intel_soc_pmic.h: add new data  structures Lee Jones <lee.jones@linaro.org> - 2016-06-16 16:40 +0200

#1424117 — Re: [PATCH 1/3] include/linux/mfd/intel_soc_pmic.h: add new data structures

On Sat, 11 Jun 2016, Bin Gao wrote:

> This patch adds three new data structures: struct trip_config_map {},
> struct thermal_irq_map {} and struct pmic_thermal_data {} which are
> required by some new drivers.
> 
> Signed-off-by: ysiyer <yegnesh.s.iyer@intel.com>
> Signed-off-by: Bin Gao <bin.gao@intel.com>
> ---
>  include/linux/mfd/intel_soc_pmic.h | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)

Please place the addition of the structs into the patches which use
them first.

> diff --git a/include/linux/mfd/intel_soc_pmic.h b/include/linux/mfd/intel_soc_pmic.h
> index cf619db..7df4302 100644
> --- a/include/linux/mfd/intel_soc_pmic.h
> +++ b/include/linux/mfd/intel_soc_pmic.h
> @@ -21,6 +21,27 @@
>  
>  #include <linux/regmap.h>
>  
> +struct trip_config_map {
> +	u16 irq_reg;
> +	u16 irq_en;
> +	u16 evt_stat;
> +	u8 irq_mask;
> +	u8 irq_en_mask;
> +	u8 evt_mask;
> +	u8 trip_num;
> +};
> +
> +struct thermal_irq_map {
> +	char handle[20];
> +	int num_trips;
> +	struct trip_config_map *trip_config;
> +};
> +
> +struct pmic_thermal_data {
> +	struct thermal_irq_map *maps;
> +	int num_maps;
> +};
> +
>  struct intel_soc_pmic {
>  	int irq;
>  	struct regmap *regmap;

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[toc] | [next] | [standalone]

#1424124

On Thu, 16 Jun 2016, Lee Jones wrote:

> On Sat, 11 Jun 2016, Bin Gao wrote:
> 
> > This patch adds three new data structures: struct trip_config_map {},
> > struct thermal_irq_map {} and struct pmic_thermal_data {} which are
> > required by some new drivers.
> > 
> > Signed-off-by: ysiyer <yegnesh.s.iyer@intel.com>
> > Signed-off-by: Bin Gao <bin.gao@intel.com>
> > ---
> >  include/linux/mfd/intel_soc_pmic.h | 21 +++++++++++++++++++++
> >  1 file changed, 21 insertions(+)
> 
> Please place the addition of the structs into the patches which use
> them first.

Oh, and when you submit patch-sets, please ensure they are
'threaded'.  Or else they have a tendency to spread themselves to the
four winds in people's Inboxes.

Please fix the subject line too (in all of your patches).  To help
with this you should always do a:

  `git log --oneline -- <subsystem>`

> > diff --git a/include/linux/mfd/intel_soc_pmic.h b/include/linux/mfd/intel_soc_pmic.h
> > index cf619db..7df4302 100644
> > --- a/include/linux/mfd/intel_soc_pmic.h
> > +++ b/include/linux/mfd/intel_soc_pmic.h
> > @@ -21,6 +21,27 @@
> >  
> >  #include <linux/regmap.h>
> >  
> > +struct trip_config_map {
> > +	u16 irq_reg;
> > +	u16 irq_en;
> > +	u16 evt_stat;
> > +	u8 irq_mask;
> > +	u8 irq_en_mask;
> > +	u8 evt_mask;
> > +	u8 trip_num;
> > +};
> > +
> > +struct thermal_irq_map {
> > +	char handle[20];
> > +	int num_trips;
> > +	struct trip_config_map *trip_config;
> > +};
> > +
> > +struct pmic_thermal_data {
> > +	struct thermal_irq_map *maps;
> > +	int num_maps;
> > +};
> > +
> >  struct intel_soc_pmic {
> >  	int irq;
> >  	struct regmap *regmap;
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web