Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1423930 > unrolled thread

Re: [RESEND RFT PATCH 2/2] mfd: max14577: Allow driver to be built as a module

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [RESEND RFT PATCH 2/2] mfd: max14577: Allow driver to be built  as a module Lee Jones <lee.jones@linaro.org> - 2016-06-16 12:50 +0200
    Re: [RESEND RFT PATCH 2/2] mfd: max14577: Allow driver to be built as  a module Javier Martinez Canillas <javier@osg.samsung.com> - 2016-06-16 15:50 +0200

#1423930 — Re: [RESEND RFT PATCH 2/2] mfd: max14577: Allow driver to be built as a module

On Thu, 26 May 2016, Javier Martinez Canillas wrote:

> The driver's Kconfig symbol is a boolean but nothing prevents the driver
> to be built as a module instead of built-in. It is true that most system
> integrators will choose the latter but the config should not restrict it.

Does the driver have all of the module related code?

> Suggested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 
> ---
> 
>  drivers/mfd/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index a49565cc1a6b..33d112f390fe 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -514,8 +514,8 @@ config MFD_88PM860X
>  	  battery-charger under the corresponding menus.
>  
>  config MFD_MAX14577
> -	bool "Maxim Semiconductor MAX14577/77836 MUIC + Charger Support"
> -	depends on I2C=y
> +	tristate "Maxim Semiconductor MAX14577/77836 MUIC + Charger Support"
> +	depends on I2C
>  	select MFD_CORE
>  	select REGMAP_I2C
>  	select REGMAP_IRQ

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[toc] | [next] | [standalone]

#1424068 — Re: [RESEND RFT PATCH 2/2] mfd: max14577: Allow driver to be built as a module

Hello Lee,

On 06/16/2016 06:40 AM, Lee Jones wrote:
> On Thu, 26 May 2016, Javier Martinez Canillas wrote:
> 
>> The driver's Kconfig symbol is a boolean but nothing prevents the driver
>> to be built as a module instead of built-in. It is true that most system
>> integrators will choose the latter but the config should not restrict it.
> 
> Does the driver have all of the module related code?
>

Yes, it always did (even has a MODULE_DEVICE_TABLE so autoload should work)
but is just that the Kconfig symbol was bool instead of tristate since most
system integrators will choose to have it built-in.
 
Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web