Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1422443 > unrolled thread

Re: [rcu:rcu/next 25/36] include/linux/irqflags.h:79:3: error: implicit declaration of function 'arch_irqs_disabled_flags'

Started by"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
First post2016-06-15 01:00 +0200
Last post2016-06-15 14:50 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [rcu:rcu/next 25/36] include/linux/irqflags.h:79:3: error:  implicit declaration of function 'arch_irqs_disabled_flags' "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-06-15 01:00 +0200
    Re: [rcu:rcu/next 25/36] include/linux/irqflags.h:79:3: error:  implicit declaration of function 'arch_irqs_disabled_flags' Richard Weinberger <richard@nod.at> - 2016-06-15 09:10 +0200
      Re: [rcu:rcu/next 25/36] include/linux/irqflags.h:79:3: error:  implicit declaration of function 'arch_irqs_disabled_flags' "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-06-15 14:50 +0200

#1422443 — Re: [rcu:rcu/next 25/36] include/linux/irqflags.h:79:3: error: implicit declaration of function 'arch_irqs_disabled_flags'

From"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Date2016-06-15 01:00 +0200
SubjectRe: [rcu:rcu/next 25/36] include/linux/irqflags.h:79:3: error: implicit declaration of function 'arch_irqs_disabled_flags'
Message-ID<rK5to-2E2-23@gated-at.bofh.it>
On Mon, Jun 06, 2016 at 02:04:03AM +0800, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/next
> head:   13ee0de9cd2444b57ce30c4f1607b49b90aa0c38
> commit: f251ac814fc5787765009e60d54a2bd4277350c8 [25/36] rcu: Make call_rcu_tasks() tolerate first call with irqs disabled
> config: um-allmodconfig (attached as .config)
> compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
> reproduce:
>         git checkout f251ac814fc5787765009e60d54a2bd4277350c8
>         # save the attached .config to linux build tree
>         make ARCH=um 

My kneejerk reaction would be to make CONFIG_TASKS_RCU depend on
!UML or something similar.

Another approach would be create a arch_irqs_disabled_flags() for UML.

Any preferences?

							Thanx, Paul

> All errors (new ones prefixed by >>):
> 
>    In file included from include/linux/spinlock.h:53:0,
>                     from kernel/rcu/update.c:36:
>    kernel/rcu/update.c: In function 'call_rcu_tasks':
> >> include/linux/irqflags.h:79:3: error: implicit declaration of function 'arch_irqs_disabled_flags' [-Werror=implicit-function-declaration]
>       arch_irqs_disabled_flags(flags); \
>       ^
>    include/linux/irqflags.h:149:36: note: in expansion of macro 'raw_irqs_disabled_flags'
>     #define irqs_disabled_flags(flags) raw_irqs_disabled_flags(flags)
>                                        ^~~~~~~~~~~~~~~~~~~~~~~
>    kernel/rcu/update.c:572:21: note: in expansion of macro 'irqs_disabled_flags'
>          (!havetask && !irqs_disabled_flags(flags))) {
>                         ^~~~~~~~~~~~~~~~~~~
>    cc1: some warnings being treated as errors
> 
> vim +/arch_irqs_disabled_flags +79 include/linux/irqflags.h
> 
> df9ee292 David Howells 2010-10-07  73  		typecheck(unsigned long, flags);	\
> df9ee292 David Howells 2010-10-07  74  		flags = arch_local_save_flags();	\
> df9ee292 David Howells 2010-10-07  75  	} while (0)
> df9ee292 David Howells 2010-10-07  76  #define raw_irqs_disabled_flags(flags)			\
> df9ee292 David Howells 2010-10-07  77  	({						\
> df9ee292 David Howells 2010-10-07  78  		typecheck(unsigned long, flags);	\
> df9ee292 David Howells 2010-10-07 @79  		arch_irqs_disabled_flags(flags);	\
> df9ee292 David Howells 2010-10-07  80  	})
> df9ee292 David Howells 2010-10-07  81  #define raw_irqs_disabled()		(arch_irqs_disabled())
> df9ee292 David Howells 2010-10-07  82  #define raw_safe_halt()			arch_safe_halt()
> 
> :::::: The code at line 79 was first introduced by commit
> :::::: df9ee29270c11dba7d0fe0b83ce47a4d8e8d2101 Fix IRQ flag handling naming
> 
> :::::: TO: David Howells <dhowells@redhat.com>
> :::::: CC: David Howells <dhowells@redhat.com>
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[toc] | [next] | [standalone]

#1422675

FromRichard Weinberger <richard@nod.at>
Date2016-06-15 09:10 +0200
Message-ID<rKd7z-7Q2-1@gated-at.bofh.it>
In reply to#1422443
Paul,

Am 15.06.2016 um 00:54 schrieb Paul E. McKenney:
> On Mon, Jun 06, 2016 at 02:04:03AM +0800, kbuild test robot wrote:
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/next
>> head:   13ee0de9cd2444b57ce30c4f1607b49b90aa0c38
>> commit: f251ac814fc5787765009e60d54a2bd4277350c8 [25/36] rcu: Make call_rcu_tasks() tolerate first call with irqs disabled
>> config: um-allmodconfig (attached as .config)
>> compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
>> reproduce:
>>         git checkout f251ac814fc5787765009e60d54a2bd4277350c8
>>         # save the attached .config to linux build tree
>>         make ARCH=um 
> 
> My kneejerk reaction would be to make CONFIG_TASKS_RCU depend on
> !UML or something similar.
> 
> Another approach would be create a arch_irqs_disabled_flags() for UML.
> 
> Any preferences?

Patches for arch_irqs_disabled_flags() support are already on LKML:
https://lkml.org/lkml/2016/6/12/162

My plan was to merge them in the v4.8 merge window.
So having CONFIG_TASKS_RCU depend on !UML for now should be fine.
We can remove the dependency in v4.8 again.

Thanks,
//richard

[toc] | [prev] | [next] | [standalone]

#1422987

From"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Date2016-06-15 14:50 +0200
Message-ID<rKiqC-2zV-33@gated-at.bofh.it>
In reply to#1422675
On Wed, Jun 15, 2016 at 09:05:37AM +0200, Richard Weinberger wrote:
> Paul,
> 
> Am 15.06.2016 um 00:54 schrieb Paul E. McKenney:
> > On Mon, Jun 06, 2016 at 02:04:03AM +0800, kbuild test robot wrote:
> >> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/next
> >> head:   13ee0de9cd2444b57ce30c4f1607b49b90aa0c38
> >> commit: f251ac814fc5787765009e60d54a2bd4277350c8 [25/36] rcu: Make call_rcu_tasks() tolerate first call with irqs disabled
> >> config: um-allmodconfig (attached as .config)
> >> compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
> >> reproduce:
> >>         git checkout f251ac814fc5787765009e60d54a2bd4277350c8
> >>         # save the attached .config to linux build tree
> >>         make ARCH=um 
> > 
> > My kneejerk reaction would be to make CONFIG_TASKS_RCU depend on
> > !UML or something similar.
> > 
> > Another approach would be create a arch_irqs_disabled_flags() for UML.
> > 
> > Any preferences?
> 
> Patches for arch_irqs_disabled_flags() support are already on LKML:
> https://lkml.org/lkml/2016/6/12/162
> 
> My plan was to merge them in the v4.8 merge window.
> So having CONFIG_TASKS_RCU depend on !UML for now should be fine.
> We can remove the dependency in v4.8 again.

Sounds very good, thank you!

							Thanx, Paul

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web