Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1420800 > unrolled thread

[PATCH 2/3] infiniband: rxe: add UDP_TUNNEL dependency

Started byArnd Bergmann <arnd@arndb.de>
First post2016-06-13 15:00 +0200
Last post2016-06-13 17:30 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 2/3] infiniband: rxe: add UDP_TUNNEL dependency Arnd Bergmann <arnd@arndb.de> - 2016-06-13 15:00 +0200
    Re: [PATCH 2/3] infiniband: rxe: add UDP_TUNNEL dependency Moni Shoua <monis@mellanox.com> - 2016-06-13 17:30 +0200

#1420800 — [PATCH 2/3] infiniband: rxe: add UDP_TUNNEL dependency

FromArnd Bergmann <arnd@arndb.de>
Date2016-06-13 15:00 +0200
Subject[PATCH 2/3] infiniband: rxe: add UDP_TUNNEL dependency
Message-ID<rJzDb-6p5-5@gated-at.bofh.it>
The newly added rxe driver links against the UDP tunneling code,
which causes build errors when CONFIG_UDP_TUNNEL is disabled:

ERROR: "setup_udp_tunnel_sock" [drivers/infiniband/hw/rxe/ib_rxe.ko] undefined!
ERROR: "udp_tunnel_sock_release" [drivers/infiniband/hw/rxe/ib_rxe.ko] undefined!
ERROR: "udp_sock_create4" [drivers/infiniband/hw/rxe/ib_rxe.ko] undefined!

This adds a Kconfig dependency to prevent the invalid configuration.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/infiniband/hw/rxe/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/infiniband/hw/rxe/Kconfig b/drivers/infiniband/hw/rxe/Kconfig
index 649b7be11eb8..a199d0df31d0 100644
--- a/drivers/infiniband/hw/rxe/Kconfig
+++ b/drivers/infiniband/hw/rxe/Kconfig
@@ -1,6 +1,7 @@
 config INFINIBAND_RXE
 	tristate "Software RDMA over Ethernet (RoCE) driver"
 	depends on INET && PCI && INFINIBAND
+	depends on NET_UDP_TUNNEL
 	---help---
 	This driver implements the InfiniBand RDMA transport over
 	the Linux network stack. It enables a system with a
-- 
2.7.0

[toc] | [next] | [standalone]


#1420997

FromMoni Shoua <monis@mellanox.com>
Date2016-06-13 17:30 +0200
Message-ID<rJBYn-86X-29@gated-at.bofh.it>
In reply to#1420800
thanks. will be applied to next series

On Mon, Jun 13, 2016 at 3:54 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> The newly added rxe driver links against the UDP tunneling code,
> which causes build errors when CONFIG_UDP_TUNNEL is disabled:
>
> ERROR: "setup_udp_tunnel_sock" [drivers/infiniband/hw/rxe/ib_rxe.ko] undefined!
> ERROR: "udp_tunnel_sock_release" [drivers/infiniband/hw/rxe/ib_rxe.ko] undefined!
> ERROR: "udp_sock_create4" [drivers/infiniband/hw/rxe/ib_rxe.ko] undefined!
>
> This adds a Kconfig dependency to prevent the invalid configuration.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/infiniband/hw/rxe/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/infiniband/hw/rxe/Kconfig b/drivers/infiniband/hw/rxe/Kconfig
> index 649b7be11eb8..a199d0df31d0 100644
> --- a/drivers/infiniband/hw/rxe/Kconfig
> +++ b/drivers/infiniband/hw/rxe/Kconfig
> @@ -1,6 +1,7 @@
>  config INFINIBAND_RXE
>         tristate "Software RDMA over Ethernet (RoCE) driver"
>         depends on INET && PCI && INFINIBAND
> +       depends on NET_UDP_TUNNEL
>         ---help---
>         This driver implements the InfiniBand RDMA transport over
>         the Linux network stack. It enables a system with a
> --
> 2.7.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web