Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1420464 > unrolled thread

Re: [PATCH] scripts/gdb: Perform path expansion to lx-symbol's arguments

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] scripts/gdb: Perform path expansion to lx-symbol's  arguments Jan Kiszka <jan.kiszka@siemens.com> - 2016-06-13 08:20 +0200
    Re: [PATCH] scripts/gdb: Perform path expansion to lx-symbol's  arguments Kieran Bingham <kieran@ksquared.org.uk> - 2016-06-13 11:00 +0200

#1420464 — Re: [PATCH] scripts/gdb: Perform path expansion to lx-symbol's arguments

On 2016-06-08 18:28, Nikolay Borisov wrote:
> Python doesn't do automatic expansion of paths. In case one passes
> path of the from ~/foo/bar the gdb scripts won't automatically expand
> that and as a result the symbols files won't be loaded. Fix this
> by explicitly expanding all paths which begin with "~"
> 
> Signed-off-by: Nikolay Borisov <n.borisov.lkml@gmail.com>
> ---
>  scripts/gdb/linux/symbols.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/gdb/linux/symbols.py b/scripts/gdb/linux/symbols.py
> index 9a0f8923f67c..004b0ac7fa72 100644
> --- a/scripts/gdb/linux/symbols.py
> +++ b/scripts/gdb/linux/symbols.py
> @@ -153,7 +153,7 @@ lx-symbols command."""
>              saved_state['breakpoint'].enabled = saved_state['enabled']
>  
>      def invoke(self, arg, from_tty):
> -        self.module_paths = arg.split()
> +        self.module_paths = [os.path.expanduser(p) for p in arg.split()]
>          self.module_paths.append(os.getcwd())
>  
>          # enforce update
> 

Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>

Kieran, will you take this, as you are already preparing other patches?

Thanks,
Jan

-- 
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux

[toc] | [next] | [standalone]

#1420635

On 13/06/16 07:18, Jan Kiszka wrote:
> On 2016-06-08 18:28, Nikolay Borisov wrote:
>> Python doesn't do automatic expansion of paths. In case one passes
>> path of the from ~/foo/bar the gdb scripts won't automatically expand
>> that and as a result the symbols files won't be loaded. Fix this
>> by explicitly expanding all paths which begin with "~"
>>
>> Signed-off-by: Nikolay Borisov <n.borisov.lkml@gmail.com>
>> ---
>>  scripts/gdb/linux/symbols.py | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/gdb/linux/symbols.py b/scripts/gdb/linux/symbols.py
>> index 9a0f8923f67c..004b0ac7fa72 100644
>> --- a/scripts/gdb/linux/symbols.py
>> +++ b/scripts/gdb/linux/symbols.py
>> @@ -153,7 +153,7 @@ lx-symbols command."""
>>              saved_state['breakpoint'].enabled = saved_state['enabled']
>>  
>>      def invoke(self, arg, from_tty):
>> -        self.module_paths = arg.split()
>> +        self.module_paths = [os.path.expanduser(p) for p in arg.split()]
>>          self.module_paths.append(os.getcwd())
>>  
>>          # enforce update
>>
> 
> Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>
> 
> Kieran, will you take this, as you are already preparing other patches?

Yes, that should be fine.

> Thanks,
> Jan
> 

-- 
Regards

Kieran Bingham

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web