Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1420285 > unrolled thread

Re: [PATCH 01/11] clk: imx: clk-pllv3: fix incorrect handle of enet powerdown bit

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 01/11] clk: imx: clk-pllv3: fix incorrect handle of enet  powerdown bit Dong Aisheng <dongas86@gmail.com> - 2016-06-12 17:00 +0200
    Re: [PATCH 01/11] clk: imx: clk-pllv3: fix incorrect handle of enet  powerdown bit Shawn Guo <shawnguo@kernel.org> - 2016-06-13 05:00 +0200

#1420285 — Re: [PATCH 01/11] clk: imx: clk-pllv3: fix incorrect handle of enet powerdown bit

Hi Shawn,

On Wed, Jun 8, 2016 at 10:33 PM, Dong Aisheng <aisheng.dong@nxp.com> wrote:
> After commit f53947456f98 ("ARM: clk: imx: update pllv3 to support imx7"),
> the former used BM_PLL_POWER bit is not correct anymore for IMX7 ENET.
> Instead, pll->powerdown holds the correct bit, so using powerdown bit
> in clk_pllv3_{prepare | unprepare} functions.
>
> Fixes: f53947456f98 ("ARM: clk: imx: update pllv3 to support imx7")
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>

Any comments about this one?

Regards
Dong Aisheng

> ---
>  drivers/clk/imx/clk-pllv3.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/clk/imx/clk-pllv3.c b/drivers/clk/imx/clk-pllv3.c
> index 4826b3c9e19e..44d294a336f0 100644
> --- a/drivers/clk/imx/clk-pllv3.c
> +++ b/drivers/clk/imx/clk-pllv3.c
> @@ -77,9 +77,9 @@ static int clk_pllv3_prepare(struct clk_hw *hw)
>
>         val = readl_relaxed(pll->base);
>         if (pll->powerup_set)
> -               val |= BM_PLL_POWER;
> +               val |= pll->powerdown;
>         else
> -               val &= ~BM_PLL_POWER;
> +               val &= ~pll->powerdown;
>         writel_relaxed(val, pll->base);
>
>         return clk_pllv3_wait_lock(pll);
> @@ -92,9 +92,9 @@ static void clk_pllv3_unprepare(struct clk_hw *hw)
>
>         val = readl_relaxed(pll->base);
>         if (pll->powerup_set)
> -               val &= ~BM_PLL_POWER;
> +               val &= ~pll->powerdown;
>         else
> -               val |= BM_PLL_POWER;
> +               val |= pll->powerdown;
>         writel_relaxed(val, pll->base);
>  }
>
> --
> 1.9.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[toc] | [next] | [standalone]

#1420413

On Sun, Jun 12, 2016 at 10:56:38PM +0800, Dong Aisheng wrote:
> Hi Shawn,
> 
> On Wed, Jun 8, 2016 at 10:33 PM, Dong Aisheng <aisheng.dong@nxp.com> wrote:
> > After commit f53947456f98 ("ARM: clk: imx: update pllv3 to support imx7"),
> > the former used BM_PLL_POWER bit is not correct anymore for IMX7 ENET.
> > Instead, pll->powerdown holds the correct bit, so using powerdown bit
> > in clk_pllv3_{prepare | unprepare} functions.
> >
> > Fixes: f53947456f98 ("ARM: clk: imx: update pllv3 to support imx7")
> > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> 
> Any comments about this one?

Sorry.  I thought I had applied it.  Applied it now, thanks.

Shawn

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web