Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1421346 > unrolled thread

Re: [PATCH 1/2] powercap/rapl: add support for skx

Started by"Rafael J. Wysocki" <rjw@rjwysocki.net>
First post2016-06-13 23:30 +0200
Last post2016-06-15 01:10 +0200
Articles 6 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 1/2] powercap/rapl: add support for skx "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-06-13 23:30 +0200
    Re: [PATCH 1/2] powercap/rapl: add support for skx "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-06-14 00:00 +0200
      Re: [PATCH 1/2] powercap/rapl: add support for skx Jacob Pan <jacob.jun.pan@linux.intel.com> - 2016-06-14 02:10 +0200
        Re: [PATCH 1/2] powercap/rapl: add support for skx "Rafael J. Wysocki" <rafael@kernel.org> - 2016-06-14 02:30 +0200
          Re: [PATCH 1/2] powercap/rapl: add support for skx Jacob Pan <jacob.jun.pan@linux.intel.com> - 2016-06-14 16:50 +0200
            Re: [PATCH 1/2] powercap/rapl: add support for skx "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-06-15 01:10 +0200

#1421346 — Re: [PATCH 1/2] powercap/rapl: add support for skx

From"Rafael J. Wysocki" <rjw@rjwysocki.net>
Date2016-06-13 23:30 +0200
SubjectRe: [PATCH 1/2] powercap/rapl: add support for skx
Message-ID<rJHAK-3pk-3@gated-at.bofh.it>
On Monday, May 23, 2016 09:45:42 AM Jacob Pan wrote:
> SKX RAPL interface is similar to HSX/BDX.
> 
> Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
> ---
>  drivers/powercap/intel_rapl.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/powercap/intel_rapl.c b/drivers/powercap/intel_rapl.c
> index 470bb62..a417e68 100644
> --- a/drivers/powercap/intel_rapl.c
> +++ b/drivers/powercap/intel_rapl.c
> @@ -1096,6 +1096,7 @@ static const struct x86_cpu_id rapl_ids[] __initconst = {
>  	RAPL_CPU(0x4E, rapl_defaults_core),/* Skylake */
>  	RAPL_CPU(0x4C, rapl_defaults_cht),/* Braswell/Cherryview */
>  	RAPL_CPU(0x4A, rapl_defaults_tng),/* Tangier */
> +	RAPL_CPU(0x55, rapl_defaults_hsw_server),/* Skylake server */
>  	RAPL_CPU(0x56, rapl_defaults_core),/* Future Xeon */
>  	RAPL_CPU(0x5A, rapl_defaults_ann),/* Annidale */
>  	RAPL_CPU(0X5C, rapl_defaults_core),/* Broxton */
> 

Can you please rebase this on top of 4.7-rc3?

Thanks,
Rafael

[toc] | [next] | [standalone]

#1421362

From"Rafael J. Wysocki" <rjw@rjwysocki.net>
Date2016-06-14 00:00 +0200
Message-ID<rJI3L-3C7-1@gated-at.bofh.it>
In reply to#1421346
On Monday, June 13, 2016 11:32:10 PM Rafael J. Wysocki wrote:
> On Monday, May 23, 2016 09:45:42 AM Jacob Pan wrote:
> > SKX RAPL interface is similar to HSX/BDX.
> > 
> > Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
> > ---
> >  drivers/powercap/intel_rapl.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/powercap/intel_rapl.c b/drivers/powercap/intel_rapl.c
> > index 470bb62..a417e68 100644
> > --- a/drivers/powercap/intel_rapl.c
> > +++ b/drivers/powercap/intel_rapl.c
> > @@ -1096,6 +1096,7 @@ static const struct x86_cpu_id rapl_ids[] __initconst = {
> >  	RAPL_CPU(0x4E, rapl_defaults_core),/* Skylake */
> >  	RAPL_CPU(0x4C, rapl_defaults_cht),/* Braswell/Cherryview */
> >  	RAPL_CPU(0x4A, rapl_defaults_tng),/* Tangier */
> > +	RAPL_CPU(0x55, rapl_defaults_hsw_server),/* Skylake server */
> >  	RAPL_CPU(0x56, rapl_defaults_core),/* Future Xeon */
> >  	RAPL_CPU(0x5A, rapl_defaults_ann),/* Annidale */
> >  	RAPL_CPU(0X5C, rapl_defaults_core),/* Broxton */
> > 
> 
> Can you please rebase this on top of 4.7-rc3?

Or rather on top of the x86/cpu branch from tip?

BTW, I can take the Denverton support for RAPL too (unless already applied
elsewhere), but it has to be based on x86/cpu as well.

Thanks,
Rafael

[toc] | [prev] | [next] | [standalone]

#1421460

FromJacob Pan <jacob.jun.pan@linux.intel.com>
Date2016-06-14 02:10 +0200
Message-ID<rJK5z-5nH-3@gated-at.bofh.it>
In reply to#1421362
On Mon, 13 Jun 2016 23:56:18 +0200
"Rafael J. Wysocki" <rjw@rjwysocki.net> wrote:

> On Monday, June 13, 2016 11:32:10 PM Rafael J. Wysocki wrote:
> > On Monday, May 23, 2016 09:45:42 AM Jacob Pan wrote:
> > > SKX RAPL interface is similar to HSX/BDX.
> > > 
> > > Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
> > > ---
> > >  drivers/powercap/intel_rapl.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/drivers/powercap/intel_rapl.c
> > > b/drivers/powercap/intel_rapl.c index 470bb62..a417e68 100644
> > > --- a/drivers/powercap/intel_rapl.c
> > > +++ b/drivers/powercap/intel_rapl.c
> > > @@ -1096,6 +1096,7 @@ static const struct x86_cpu_id rapl_ids[]
> > > __initconst = { RAPL_CPU(0x4E, rapl_defaults_core),/* Skylake */
> > >  	RAPL_CPU(0x4C, rapl_defaults_cht),/* Braswell/Cherryview
> > > */ RAPL_CPU(0x4A, rapl_defaults_tng),/* Tangier */
> > > +	RAPL_CPU(0x55, rapl_defaults_hsw_server),/* Skylake
> > > server */ RAPL_CPU(0x56, rapl_defaults_core),/* Future Xeon */
> > >  	RAPL_CPU(0x5A, rapl_defaults_ann),/* Annidale */
> > >  	RAPL_CPU(0X5C, rapl_defaults_core),/* Broxton */
> > > 
> > 
> > Can you please rebase this on top of 4.7-rc3?
> 
> Or rather on top of the x86/cpu branch from tip?
> 
done. just sent you v2.
[PATCH v2] powercap/rapl: add support for denverton
> BTW, I can take the Denverton support for RAPL too (unless already
> applied elsewhere), but it has to be based on x86/cpu as well.
> 
Not applied elsewhere, please take it. I was confused powercap/rapl with
perf/rapl which should be in tip.

[toc] | [prev] | [next] | [standalone]

#1421469

From"Rafael J. Wysocki" <rafael@kernel.org>
Date2016-06-14 02:30 +0200
Message-ID<rJKoV-5uE-13@gated-at.bofh.it>
In reply to#1421460
On Tue, Jun 14, 2016 at 2:06 AM, Jacob Pan
<jacob.jun.pan@linux.intel.com> wrote:
> On Mon, 13 Jun 2016 23:56:18 +0200
> "Rafael J. Wysocki" <rjw@rjwysocki.net> wrote:
>
>> On Monday, June 13, 2016 11:32:10 PM Rafael J. Wysocki wrote:
>> > On Monday, May 23, 2016 09:45:42 AM Jacob Pan wrote:
>> > > SKX RAPL interface is similar to HSX/BDX.
>> > >
>> > > Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
>> > > ---
>> > >  drivers/powercap/intel_rapl.c | 1 +
>> > >  1 file changed, 1 insertion(+)
>> > >
>> > > diff --git a/drivers/powercap/intel_rapl.c
>> > > b/drivers/powercap/intel_rapl.c index 470bb62..a417e68 100644
>> > > --- a/drivers/powercap/intel_rapl.c
>> > > +++ b/drivers/powercap/intel_rapl.c
>> > > @@ -1096,6 +1096,7 @@ static const struct x86_cpu_id rapl_ids[]
>> > > __initconst = { RAPL_CPU(0x4E, rapl_defaults_core),/* Skylake */
>> > >   RAPL_CPU(0x4C, rapl_defaults_cht),/* Braswell/Cherryview
>> > > */ RAPL_CPU(0x4A, rapl_defaults_tng),/* Tangier */
>> > > + RAPL_CPU(0x55, rapl_defaults_hsw_server),/* Skylake
>> > > server */ RAPL_CPU(0x56, rapl_defaults_core),/* Future Xeon */
>> > >   RAPL_CPU(0x5A, rapl_defaults_ann),/* Annidale */
>> > >   RAPL_CPU(0X5C, rapl_defaults_core),/* Broxton */
>> > >
>> >
>> > Can you please rebase this on top of 4.7-rc3?
>>
>> Or rather on top of the x86/cpu branch from tip?
>>
> done. just sent you v2.
> [PATCH v2] powercap/rapl: add support for denverton

Thanks for that one, but the $subject one was for SKX.  Any chance to
rebase and resend this one too?

[toc] | [prev] | [next] | [standalone]

#1421979

FromJacob Pan <jacob.jun.pan@linux.intel.com>
Date2016-06-14 16:50 +0200
Message-ID<rJXPd-66e-53@gated-at.bofh.it>
In reply to#1421469
On Tue, 14 Jun 2016 02:21:41 +0200
"Rafael J. Wysocki" <rafael@kernel.org> wrote:

> On Tue, Jun 14, 2016 at 2:06 AM, Jacob Pan
> <jacob.jun.pan@linux.intel.com> wrote:
> > On Mon, 13 Jun 2016 23:56:18 +0200
> > "Rafael J. Wysocki" <rjw@rjwysocki.net> wrote:
> >
> >> On Monday, June 13, 2016 11:32:10 PM Rafael J. Wysocki wrote:
> >> > On Monday, May 23, 2016 09:45:42 AM Jacob Pan wrote:
> >> > > SKX RAPL interface is similar to HSX/BDX.
> >> > >
> >> > > Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
> >> > > ---
> >> > >  drivers/powercap/intel_rapl.c | 1 +
> >> > >  1 file changed, 1 insertion(+)
> >> > >
> >> > > diff --git a/drivers/powercap/intel_rapl.c
> >> > > b/drivers/powercap/intel_rapl.c index 470bb62..a417e68 100644
> >> > > --- a/drivers/powercap/intel_rapl.c
> >> > > +++ b/drivers/powercap/intel_rapl.c
> >> > > @@ -1096,6 +1096,7 @@ static const struct x86_cpu_id rapl_ids[]
> >> > > __initconst = { RAPL_CPU(0x4E, rapl_defaults_core),/* Skylake
> >> > > */ RAPL_CPU(0x4C, rapl_defaults_cht),/* Braswell/Cherryview
> >> > > */ RAPL_CPU(0x4A, rapl_defaults_tng),/* Tangier */
> >> > > + RAPL_CPU(0x55, rapl_defaults_hsw_server),/* Skylake
> >> > > server */ RAPL_CPU(0x56, rapl_defaults_core),/* Future Xeon */
> >> > >   RAPL_CPU(0x5A, rapl_defaults_ann),/* Annidale */
> >> > >   RAPL_CPU(0X5C, rapl_defaults_core),/* Broxton */
> >> > >
> >> >
> >> > Can you please rebase this on top of 4.7-rc3?
> >>
> >> Or rather on top of the x86/cpu branch from tip?
> >>
> > done. just sent you v2.
> > [PATCH v2] powercap/rapl: add support for denverton
> 
> Thanks for that one, but the $subject one was for SKX.  Any chance to
> rebase and resend this one too?

SKX has already been added by commit below in tip/x86/cpu:

commit d40671e30cb46e834651e0ce3d4590c915171414
Author: Dave Hansen <dave.hansen@linux.intel.com>
Date:   Thu Jun 2 17:19:55 2016 -0700

    x86, powercap, rapl: Add Skylake Server model number
    
    SKX uses similar RAPL interface as Broadwell server according to
    Jacob Pan.
    
    Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
    Cc: Andy Lutomirski <luto@amacapital.net>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: Brian Gerst <brgerst@gmail.com>
    Cc: Dave Hansen <dave@sr71.net>
    Cc: Denys Vlasenko <dvlasenk@redhat.com>
    Cc: H. Peter Anvin <hpa@zytor.com>
    Cc: Jacob Pan <jacob.jun.pan@linux.intel.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: jacob.jun.pan@intel.com
    Cc: linux-pm@vger.kernel.org
    Link: http://lkml.kernel.org/r/20160603001955.38E1E684@viggo.jf.intel.com
    Signed-off-by: Ingo Molnar <mingo@kernel.org>

diff --git a/drivers/powercap/intel_rapl.c b/drivers/powercap/intel_rapl.c
index f4f8532..2e8f2be 100644
--- a/drivers/powercap/intel_rapl.c
+++ b/drivers/powercap/intel_rapl.c
@@ -1114,6 +1114,7 @@ static const struct x86_cpu_id rapl_ids[] __initconst = {
 
        RAPL_CPU(INTEL_FAM6_SKYLAKE_DESKTOP,    rapl_defaults_core),
        RAPL_CPU(INTEL_FAM6_SKYLAKE_MOBILE,     rapl_defaults_core),
+       RAPL_CPU(INTEL_FAM6_SKYLAKE_X,          rapl_defaults_hsw_server),
        RAPL_CPU(INTEL_FAM6_KABYLAKE_MOBILE,    rapl_defaults_core),
        RAPL_CPU(INTEL_FAM6_KABYLAKE_DESKTOP,   rapl_defaults_core),

[toc] | [prev] | [next] | [standalone]

#1422445

From"Rafael J. Wysocki" <rjw@rjwysocki.net>
Date2016-06-15 01:10 +0200
Message-ID<rK5D4-2WS-15@gated-at.bofh.it>
In reply to#1421979
On Tuesday, June 14, 2016 07:47:45 AM Jacob Pan wrote:
> On Tue, 14 Jun 2016 02:21:41 +0200
> "Rafael J. Wysocki" <rafael@kernel.org> wrote:
> 
> > On Tue, Jun 14, 2016 at 2:06 AM, Jacob Pan
> > <jacob.jun.pan@linux.intel.com> wrote:
> > > On Mon, 13 Jun 2016 23:56:18 +0200
> > > "Rafael J. Wysocki" <rjw@rjwysocki.net> wrote:
> > >
> > >> On Monday, June 13, 2016 11:32:10 PM Rafael J. Wysocki wrote:
> > >> > On Monday, May 23, 2016 09:45:42 AM Jacob Pan wrote:
> > >> > > SKX RAPL interface is similar to HSX/BDX.
> > >> > >
> > >> > > Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
> > >> > > ---
> > >> > >  drivers/powercap/intel_rapl.c | 1 +
> > >> > >  1 file changed, 1 insertion(+)
> > >> > >
> > >> > > diff --git a/drivers/powercap/intel_rapl.c
> > >> > > b/drivers/powercap/intel_rapl.c index 470bb62..a417e68 100644
> > >> > > --- a/drivers/powercap/intel_rapl.c
> > >> > > +++ b/drivers/powercap/intel_rapl.c
> > >> > > @@ -1096,6 +1096,7 @@ static const struct x86_cpu_id rapl_ids[]
> > >> > > __initconst = { RAPL_CPU(0x4E, rapl_defaults_core),/* Skylake
> > >> > > */ RAPL_CPU(0x4C, rapl_defaults_cht),/* Braswell/Cherryview
> > >> > > */ RAPL_CPU(0x4A, rapl_defaults_tng),/* Tangier */
> > >> > > + RAPL_CPU(0x55, rapl_defaults_hsw_server),/* Skylake
> > >> > > server */ RAPL_CPU(0x56, rapl_defaults_core),/* Future Xeon */
> > >> > >   RAPL_CPU(0x5A, rapl_defaults_ann),/* Annidale */
> > >> > >   RAPL_CPU(0X5C, rapl_defaults_core),/* Broxton */
> > >> > >
> > >> >
> > >> > Can you please rebase this on top of 4.7-rc3?
> > >>
> > >> Or rather on top of the x86/cpu branch from tip?
> > >>
> > > done. just sent you v2.
> > > [PATCH v2] powercap/rapl: add support for denverton
> > 
> > Thanks for that one, but the $subject one was for SKX.  Any chance to
> > rebase and resend this one too?
> 
> SKX has already been added by commit below in tip/x86/cpu:
> 
> commit d40671e30cb46e834651e0ce3d4590c915171414
> Author: Dave Hansen <dave.hansen@linux.intel.com>
> Date:   Thu Jun 2 17:19:55 2016 -0700
> 
>     x86, powercap, rapl: Add Skylake Server model number

OK, thanks!

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web