Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1421537 > unrolled thread
| Started by | Duc Dang <dhdang@apm.com> |
|---|---|
| First post | 2016-06-14 04:40 +0200 |
| Last post | 2016-06-14 15:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] arm64: dts: apm: Use lowercase consistently for hex constants Duc Dang <dhdang@apm.com> - 2016-06-14 04:40 +0200
Re: [PATCH] arm64: dts: apm: Use lowercase consistently for hex constants Bjorn Helgaas <helgaas@kernel.org> - 2016-06-14 15:00 +0200
| From | Duc Dang <dhdang@apm.com> |
|---|---|
| Date | 2016-06-14 04:40 +0200 |
| Subject | Re: [PATCH] arm64: dts: apm: Use lowercase consistently for hex constants |
| Message-ID | <rJMqJ-6UI-1@gated-at.bofh.it> |
On Wed, Jun 8, 2016 at 12:48 PM, Rob Herring <robh@kernel.org> wrote:
> On Mon, Jun 06, 2016 at 03:17:56PM -0500, Bjorn Helgaas wrote:
>> The convention in these files is to use lowercase for "0x" prefixes and for
>> the hex constants themselves, but a few changes didn't follow that
>> convention, which makes the file annoying to read.
>>
>> Use lowercase consistently for the hex constants. No functional change
>> intended.
>>
>> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
>> ---
>> .../devicetree/bindings/net/apm-xgene-enet.txt | 4 +-
>> arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 40 ++++++++++----------
>> arch/arm64/boot/dts/apm/apm-storm.dtsi | 36 +++++++++---------
>> 3 files changed, 40 insertions(+), 40 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/net/apm-xgene-enet.txt b/Documentation/devicetree/bindings/net/apm-xgene-enet.txt
>> index 05f705e3..e41b2d5 100644
>> --- a/Documentation/devicetree/bindings/net/apm-xgene-enet.txt
>> +++ b/Documentation/devicetree/bindings/net/apm-xgene-enet.txt
>> @@ -59,8 +59,8 @@ Example:
>> compatible = "apm,xgene-enet";
>> status = "disabled";
>> reg = <0x0 0x17020000 0x0 0xd100>,
>> - <0x0 0X17030000 0x0 0X400>,
>> - <0x0 0X10000000 0x0 0X200>;
>> + <0x0 0x17030000 0x0 0x400>,
>> + <0x0 0x10000000 0x0 0x200>;
>> reg-names = "enet_csr", "ring_csr", "ring_cmd";
>> interrupts = <0x0 0x3c 0x4>;
>> port-id = <0>;
>> diff --git a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
>> index c569f76..9773687 100644
>> --- a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
>> +++ b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
>> @@ -106,9 +106,9 @@
>> interrupts = <1 9 0xf04>; /* GIC Maintenence IRQ */
>> ranges = <0 0 0 0x79000000 0x0 0x800000>; /* MSI Range */
>> reg = <0x0 0x78090000 0x0 0x10000>, /* GIC Dist */
>> - <0x0 0x780A0000 0x0 0x20000>, /* GIC CPU */
>> - <0x0 0x780C0000 0x0 0x10000>, /* GIC VCPU Control */
>> - <0x0 0x780E0000 0x0 0x20000>; /* GIC VCPU */
>> + <0x0 0x780a0000 0x0 0x20000>, /* GIC CPU */
>> + <0x0 0x780c0000 0x0 0x10000>, /* GIC VCPU Control */
>> + <0x0 0x780e0000 0x0 0x20000>; /* GIC VCPU */
>> v2m0: v2m@0x00000 {
>
> Unit addresses should not have '0x' or leading 0s.
>
>> compatible = "arm,gic-v2m-frame";
>> msi-controller;
>> @@ -159,35 +159,35 @@
>> msi-controller;
>> reg = <0x0 0x90000 0x0 0x1000>;
>> };
>> - v2m10: v2m@0xA0000 {
>> + v2m10: v2m@0xa0000 {
>
> and here...
Thanks, Bjorn. Will you have time to post another version that
addresses Rob's comment?
Hi Rob,
If you are fine, I will take these changes into my xgene-next tree for
the next DTS pull request for 4.8 (after your comment is addressed)
Regards,
Duc Dang.
>
> Rob
[toc] | [next] | [standalone]
| From | Bjorn Helgaas <helgaas@kernel.org> |
|---|---|
| Date | 2016-06-14 15:00 +0200 |
| Subject | Re: [PATCH] arm64: dts: apm: Use lowercase consistently for hex constants |
| Message-ID | <rJW6K-4Wd-19@gated-at.bofh.it> |
| In reply to | #1421537 |
On Mon, Jun 13, 2016 at 07:33:59PM -0700, Duc Dang wrote:
> On Wed, Jun 8, 2016 at 12:48 PM, Rob Herring <robh@kernel.org> wrote:
> > On Mon, Jun 06, 2016 at 03:17:56PM -0500, Bjorn Helgaas wrote:
> >> The convention in these files is to use lowercase for "0x" prefixes and for
> >> the hex constants themselves, but a few changes didn't follow that
> >> convention, which makes the file annoying to read.
> >>
> >> Use lowercase consistently for the hex constants. No functional change
> >> intended.
> >>
> >> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> >> ---
> >> .../devicetree/bindings/net/apm-xgene-enet.txt | 4 +-
> >> arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 40 ++++++++++----------
> >> arch/arm64/boot/dts/apm/apm-storm.dtsi | 36 +++++++++---------
> >> 3 files changed, 40 insertions(+), 40 deletions(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/net/apm-xgene-enet.txt b/Documentation/devicetree/bindings/net/apm-xgene-enet.txt
> >> index 05f705e3..e41b2d5 100644
> >> --- a/Documentation/devicetree/bindings/net/apm-xgene-enet.txt
> >> +++ b/Documentation/devicetree/bindings/net/apm-xgene-enet.txt
> >> @@ -59,8 +59,8 @@ Example:
> >> compatible = "apm,xgene-enet";
> >> status = "disabled";
> >> reg = <0x0 0x17020000 0x0 0xd100>,
> >> - <0x0 0X17030000 0x0 0X400>,
> >> - <0x0 0X10000000 0x0 0X200>;
> >> + <0x0 0x17030000 0x0 0x400>,
> >> + <0x0 0x10000000 0x0 0x200>;
> >> reg-names = "enet_csr", "ring_csr", "ring_cmd";
> >> interrupts = <0x0 0x3c 0x4>;
> >> port-id = <0>;
> >> diff --git a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
> >> index c569f76..9773687 100644
> >> --- a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
> >> +++ b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
> >> @@ -106,9 +106,9 @@
> >> interrupts = <1 9 0xf04>; /* GIC Maintenence IRQ */
> >> ranges = <0 0 0 0x79000000 0x0 0x800000>; /* MSI Range */
> >> reg = <0x0 0x78090000 0x0 0x10000>, /* GIC Dist */
> >> - <0x0 0x780A0000 0x0 0x20000>, /* GIC CPU */
> >> - <0x0 0x780C0000 0x0 0x10000>, /* GIC VCPU Control */
> >> - <0x0 0x780E0000 0x0 0x20000>; /* GIC VCPU */
> >> + <0x0 0x780a0000 0x0 0x20000>, /* GIC CPU */
> >> + <0x0 0x780c0000 0x0 0x10000>, /* GIC VCPU Control */
> >> + <0x0 0x780e0000 0x0 0x20000>; /* GIC VCPU */
> >> v2m0: v2m@0x00000 {
> >
> > Unit addresses should not have '0x' or leading 0s.
> >
> >> compatible = "arm,gic-v2m-frame";
> >> msi-controller;
> >> @@ -159,35 +159,35 @@
> >> msi-controller;
> >> reg = <0x0 0x90000 0x0 0x1000>;
> >> };
> >> - v2m10: v2m@0xA0000 {
> >> + v2m10: v2m@0xa0000 {
> >
> > and here...
>
> Thanks, Bjorn. Will you have time to post another version that
> addresses Rob's comment?
Sorry, I forgot to follow up on this. I didn't understand Rob's comment,
because my patch only changed uppercase/lowercase. I didn't add or remove
any '0x' or '0' prefixes.
From the context, I infer that we should have "v2m10: v2m@a0000" instead of
"v2m10: v2m@0xa0000".
I'll make a second patch that makes that change. I do notice many other
DTs that have similar constructs, e.g.,
arch/arc/boot/dts/abilis_tb10x.dtsi: spi0: spi@0xFE010000 {
arch/arc/boot/dts/abilis_tb10x.dtsi: spi1: spi@0xFE011000 {
arch/arc/boot/dts/axc001.dtsi: dw-apb-gpio@0x2000 {
arch/arc/boot/dts/axc001.dtsi: debug_uart: dw-apb-uart@0x5000 {
...
Maybe more opportunities for cleanup?
Bjorn
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web