Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1421368 > unrolled thread

Re: [PATCH v2 3/3] ARM64: dts: meson-gxbb: Add Hardware Random Generator node

Started byKevin Hilman <khilman@baylibre.com>
First post2016-06-14 00:20 +0200
Last post2016-06-14 07:00 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH v2 3/3] ARM64: dts: meson-gxbb: Add Hardware Random Generator node Kevin Hilman <khilman@baylibre.com> - 2016-06-14 00:20 +0200
    Re: [PATCH v2 3/3] ARM64: dts: meson-gxbb: Add Hardware Random  Generator node Neil Armstrong <narmstrong@baylibre.com> - 2016-06-14 07:00 +0200

#1421368 — Re: [PATCH v2 3/3] ARM64: dts: meson-gxbb: Add Hardware Random Generator node

FromKevin Hilman <khilman@baylibre.com>
Date2016-06-14 00:20 +0200
SubjectRe: [PATCH v2 3/3] ARM64: dts: meson-gxbb: Add Hardware Random Generator node
Message-ID<rJIn7-422-1@gated-at.bofh.it>
Hi Neil,

Neil Armstrong <narmstrong@baylibre.com> writes:

> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
>  arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> index 832815d..8353621 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> @@ -167,6 +167,11 @@
>  			};
>  		};
>  
> +		rng {
> +			compatible = "amlogic,meson-rng";
> +			reg = <0x0 0xc8834000 0x0 0x4>;
> +		};

This should be under the periphs bus, with an offset of 0x0 instead of
at the top level.

See the for-next branch in the linux-amlogic tree[1] which has separate
busses for periphs and hiu.

Kevin

[1] git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-amlogic.git

[toc] | [next] | [standalone]


#1421575 — Re: [PATCH v2 3/3] ARM64: dts: meson-gxbb: Add Hardware Random Generator node

FromNeil Armstrong <narmstrong@baylibre.com>
Date2016-06-14 07:00 +0200
SubjectRe: [PATCH v2 3/3] ARM64: dts: meson-gxbb: Add Hardware Random Generator node
Message-ID<rJOCd-8ma-15@gated-at.bofh.it>
In reply to#1421368
On 06/14/2016 12:09 AM, Kevin Hilman wrote:
> Hi Neil,
> 
> Neil Armstrong <narmstrong@baylibre.com> writes:
> 
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> ---
>>  arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
>> index 832815d..8353621 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
>> @@ -167,6 +167,11 @@
>>  			};
>>  		};
>>  
>> +		rng {
>> +			compatible = "amlogic,meson-rng";
>> +			reg = <0x0 0xc8834000 0x0 0x4>;
>> +		};
> 
> This should be under the periphs bus, with an offset of 0x0 instead of
> at the top level.
> 
> See the for-next branch in the linux-amlogic tree[1] which has separate
> busses for periphs and hiu.

Yes, It was introduced lately.

Herbert,

I'll repost this patch separately to arm-soc directly rebased on [1].

Thanks,
Neil

> Kevin
> 
> [1] git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-amlogic.git
> 

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web