Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1420888 > unrolled thread
| Started by | Steven Caron <steven.caron@genband.com> |
|---|---|
| First post | 2016-06-13 16:10 +0200 |
| Last post | 2016-06-15 07:50 +0200 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH v1 1/1] ipv4: Prevent malformed UFO fragments in ip_append_page Steven Caron <steven.caron@genband.com> - 2016-06-13 16:10 +0200
Re: [PATCH v1 1/1] ipv4: Prevent malformed UFO fragments in ip_append_page Eric Dumazet <eric.dumazet@gmail.com> - 2016-06-13 17:20 +0200
Re: [PATCH v1 1/1] ipv4: Prevent malformed UFO fragments in ip_append_page Hannes Frederic Sowa <hannes@stressinduktion.org> - 2016-06-13 21:30 +0200
Re: [PATCH v1 1/1] ipv4: Prevent malformed UFO fragments in ip_append_page David Miller <davem@davemloft.net> - 2016-06-15 07:50 +0200
| From | Steven Caron <steven.caron@genband.com> |
|---|---|
| Date | 2016-06-13 16:10 +0200 |
| Subject | [PATCH v1 1/1] ipv4: Prevent malformed UFO fragments in ip_append_page |
| Message-ID | <rJAIW-7lo-41@gated-at.bofh.it> |
As the ip fragment offset field counts 8-byte chunks, non-final ip
fragments must be multiples of 8 bytes of payload. Depending on the
mtu and ip option sizes, ip_append_page wasn't respecting this,
notably when running NFS under UDP.
Signed-off-by: Steven Caron <steven.caron@genband.com>
---
diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c index 124bf0a..21ec54e 100644
--- a/net/ipv4/ip_output.c
+++ b/net/ipv4/ip_output.c
@@ -1239,7 +1239,7 @@ ssize_t ip_append_page(struct sock *sk, struct flowi4 *fl4, struct page *page,
if (skb->ip_summed != CHECKSUM_PARTIAL)
return -EOPNOTSUPP;
- skb_shinfo(skb)->gso_size = mtu - fragheaderlen;
+ skb_shinfo(skb)->gso_size = maxfraglen - fragheaderlen;
skb_shinfo(skb)->gso_type = SKB_GSO_UDP;
}
cork->length += size;
[toc] | [next] | [standalone]
| From | Eric Dumazet <eric.dumazet@gmail.com> |
|---|---|
| Date | 2016-06-13 17:20 +0200 |
| Message-ID | <rJBOG-82T-29@gated-at.bofh.it> |
| In reply to | #1420888 |
On Mon, 2016-06-13 at 14:01 +0000, Steven Caron wrote: > As the ip fragment offset field counts 8-byte chunks, non-final ip > fragments must be multiples of 8 bytes of payload. Depending on the > mtu and ip option sizes, ip_append_page wasn't respecting this, > notably when running NFS under UDP. > > Signed-off-by: Steven Caron <steven.caron@genband.com> > --- Acked-by: Eric Dumazet <edumazet@google.com>
[toc] | [prev] | [next] | [standalone]
| From | Hannes Frederic Sowa <hannes@stressinduktion.org> |
|---|---|
| Date | 2016-06-13 21:30 +0200 |
| Message-ID | <rJFIB-2aM-13@gated-at.bofh.it> |
| In reply to | #1420888 |
On 13.06.2016 16:01, Steven Caron wrote: > > As the ip fragment offset field counts 8-byte chunks, non-final ip > fragments must be multiples of 8 bytes of payload. Depending on the > mtu and ip option sizes, ip_append_page wasn't respecting this, > notably when running NFS under UDP. > > Signed-off-by: Steven Caron <steven.caron@genband.com> Awesome! Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2016-06-15 07:50 +0200 |
| Message-ID | <rKbS9-6S6-21@gated-at.bofh.it> |
| In reply to | #1420888 |
From: Steven Caron <steven.caron@genband.com> Date: Mon, 13 Jun 2016 14:01:19 +0000 > As the ip fragment offset field counts 8-byte chunks, non-final ip > fragments must be multiples of 8 bytes of payload. Depending on the > mtu and ip option sizes, ip_append_page wasn't respecting this, > notably when running NFS under UDP. > > Signed-off-by: Steven Caron <steven.caron@genband.com> This seems to have DOS newlines or something strange like that. Please fix your email client to send clean patches. Thanks.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web