Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1420139 > unrolled thread

[PATCH v3 1/6] dt-bindings: add LG LP097QX1-SPA1 panel binding

Started byYakir Yang <ykk@rock-chips.com>
First post2016-06-12 05:00 +0200
Last post2016-06-14 11:00 +0200
Articles 6 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH v3 1/6] dt-bindings: add LG LP097QX1-SPA1 panel binding Yakir Yang <ykk@rock-chips.com> - 2016-06-12 05:00 +0200
    [PATCH v3 5/6] dt-bindings: add Sharp LQ123P1JX31 panel binding Yakir Yang <ykk@rock-chips.com> - 2016-06-12 05:00 +0200
      Re: [PATCH v3 5/6] dt-bindings: add Sharp LQ123P1JX31 panel binding Rob Herring <robh@kernel.org> - 2016-06-15 00:10 +0200
    [PATCH v3 4/6] drm/panel: simple: Add support for Samsung LSN122DL01-C01 2560x1600 panel Yakir Yang <ykk@rock-chips.com> - 2016-06-12 05:00 +0200
      Re: [PATCH v3 4/6] drm/panel: simple: Add support for Samsung  LSN122DL01-C01 2560x1600 panel Doug Anderson <dianders@chromium.org> - 2016-06-13 19:10 +0200
        Re: [PATCH v3 4/6] drm/panel: simple: Add support for Samsung  LSN122DL01-C01 2560x1600 panel Thierry Reding <thierry.reding@gmail.com> - 2016-06-14 11:00 +0200

#1420139 — [PATCH v3 1/6] dt-bindings: add LG LP097QX1-SPA1 panel binding

FromYakir Yang <ykk@rock-chips.com>
Date2016-06-12 05:00 +0200
Subject[PATCH v3 1/6] dt-bindings: add LG LP097QX1-SPA1 panel binding
Message-ID<rJ3MZ-2Xu-3@gated-at.bofh.it>
The LG LP097QX1-SPA1 is an 9.7", 2048x1536 (QXGA) TFT-LCD panel
connected using eDP interfaces.

Signed-off-by: Yakir Yang <ykk@rock-chips.com>
Acked-by: Rob Herring <robh@kernel.org>
---
Changes in v3: None
Changes in v2:
- Add Rob's acked for dt-bindings of LG LP097QX1-SPA1 panel

 .../devicetree/bindings/display/panel/lg,lp097qx1-spa1.txt         | 7 +++++++
 1 file changed, 7 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/lg,lp097qx1-spa1.txt

diff --git a/Documentation/devicetree/bindings/display/panel/lg,lp097qx1-spa1.txt b/Documentation/devicetree/bindings/display/panel/lg,lp097qx1-spa1.txt
new file mode 100644
index 0000000..4214151
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/lg,lp097qx1-spa1.txt
@@ -0,0 +1,7 @@
+LG 9.7" (2048x1536 pixels) TFT LCD panel
+
+Required properties:
+- compatible: should be "lg,lp097qx1-spa1"
+
+This binding is compatible with the simple-panel binding, which is specified
+in simple-panel.txt in this directory.
-- 
1.9.1

[toc] | [next] | [standalone]

#1420140 — [PATCH v3 5/6] dt-bindings: add Sharp LQ123P1JX31 panel binding

FromYakir Yang <ykk@rock-chips.com>
Date2016-06-12 05:00 +0200
Subject[PATCH v3 5/6] dt-bindings: add Sharp LQ123P1JX31 panel binding
Message-ID<rJ3MZ-2Xu-27@gated-at.bofh.it>
In reply to#1420139
The Sharp LQ123P1JX31 is an 12.3" 2400x1600 TFT-LCD panel
connected using eDP interfaces.

Signed-off-by: Yakir Yang <ykk@rock-chips.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
---
Changes in v3:
- Drop the extra comma in compatible name (Rob)
- Add the reviewed flag from Doug

Changes in v2:
- Add dt-bindings of Sharp LQ123P1JX31 panel in v2

 .../devicetree/bindings/display/panel/sharp,lq123p1jx31.txt        | 7 +++++++
 1 file changed, 7 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt

diff --git a/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt b/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt
new file mode 100644
index 0000000..bcb0e8a
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt
@@ -0,0 +1,7 @@
+Sharp 12.3" (2400x1600 pixels) TFT LCD panel
+
+Required properties:
+- compatible: should be "sharp,lq123p1jx31"
+
+This binding is compatible with the simple-panel binding, which is specified
+in simple-panel.txt in this directory.
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]

#1422382 — Re: [PATCH v3 5/6] dt-bindings: add Sharp LQ123P1JX31 panel binding

FromRob Herring <robh@kernel.org>
Date2016-06-15 00:10 +0200
SubjectRe: [PATCH v3 5/6] dt-bindings: add Sharp LQ123P1JX31 panel binding
Message-ID<rK4H0-2lJ-25@gated-at.bofh.it>
In reply to#1420140
On Sun, Jun 12, 2016 at 10:56:16AM +0800, Yakir Yang wrote:
> The Sharp LQ123P1JX31 is an 12.3" 2400x1600 TFT-LCD panel
> connected using eDP interfaces.
> 
> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> ---
> Changes in v3:
> - Drop the extra comma in compatible name (Rob)
> - Add the reviewed flag from Doug
> 
> Changes in v2:
> - Add dt-bindings of Sharp LQ123P1JX31 panel in v2
> 
>  .../devicetree/bindings/display/panel/sharp,lq123p1jx31.txt        | 7 +++++++
>  1 file changed, 7 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt

Acked-by: Rob Herring <robh@kernel.org>

[toc] | [prev] | [next] | [standalone]

#1420141 — [PATCH v3 4/6] drm/panel: simple: Add support for Samsung LSN122DL01-C01 2560x1600 panel

FromYakir Yang <ykk@rock-chips.com>
Date2016-06-12 05:00 +0200
Subject[PATCH v3 4/6] drm/panel: simple: Add support for Samsung LSN122DL01-C01 2560x1600 panel
Message-ID<rJ3N0-2Xu-29@gated-at.bofh.it>
In reply to#1420139
The Samsung LSN122DL01-C01 is an 12.2" 2560x1600 (WQXGA) TFT-LCD panel
connected using eDP interfaces.

Signed-off-by: Yakir Yang <ykk@rock-chips.com>
---
Changes in v3:
- Correct the size of panel_desc to active area 262mmx164mm (Emil, Stéphane)

Changes in v2: None

 drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 2d40a21..17cc973 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1246,6 +1246,28 @@ static const struct panel_desc qd43003c0_40 = {
 	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
 };
 
+static const struct drm_display_mode samsung_lsn122dl01_c01_mode = {
+	.clock = 271560,
+	.hdisplay = 2560,
+	.hsync_start = 2560 + 48,
+	.hsync_end = 2560 + 48 + 32,
+	.htotal = 2560 + 48 + 32 + 80,
+	.vdisplay = 1600,
+	.vsync_start = 1600 + 2,
+	.vsync_end = 1600 + 2 + 5,
+	.vtotal = 1600 + 2 + 5 + 57,
+	.vrefresh = 60,
+};
+
+static const struct panel_desc samsung_lsn122dl01_c01 = {
+	.modes = &samsung_lsn122dl01_c01_mode,
+	.num_modes = 1,
+	.size = {
+		.width = 262,
+		.height = 164,
+	},
+};
+
 static const struct drm_display_mode samsung_ltn101nt05_mode = {
 	.clock = 54030,
 	.hdisplay = 1024,
@@ -1506,6 +1528,9 @@ static const struct of_device_id platform_of_match[] = {
 		.compatible = "qiaodian,qd43003c0-40",
 		.data = &qd43003c0_40,
 	}, {
+		.compatible = "samsung,lsn122dl01-c01",
+		.data = &samsung_lsn122dl01_c01,
+	}, {
 		.compatible = "samsung,ltn101nt05",
 		.data = &samsung_ltn101nt05,
 	}, {
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]

#1421061 — Re: [PATCH v3 4/6] drm/panel: simple: Add support for Samsung LSN122DL01-C01 2560x1600 panel

FromDoug Anderson <dianders@chromium.org>
Date2016-06-13 19:10 +0200
SubjectRe: [PATCH v3 4/6] drm/panel: simple: Add support for Samsung LSN122DL01-C01 2560x1600 panel
Message-ID<rJDx7-LB-3@gated-at.bofh.it>
In reply to#1420141
Yakir,

On Sat, Jun 11, 2016 at 7:56 PM, Yakir Yang <ykk@rock-chips.com> wrote:
> The Samsung LSN122DL01-C01 is an 12.2" 2560x1600 (WQXGA) TFT-LCD panel
> connected using eDP interfaces.
>
> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
> ---
> Changes in v3:
> - Correct the size of panel_desc to active area 262mmx164mm (Emil, Stéphane)
>
> Changes in v2: None
>
>  drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 2d40a21..17cc973 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1246,6 +1246,28 @@ static const struct panel_desc qd43003c0_40 = {
>         .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
>  };
>
> +static const struct drm_display_mode samsung_lsn122dl01_c01_mode = {
> +       .clock = 271560,
> +       .hdisplay = 2560,
> +       .hsync_start = 2560 + 48,
> +       .hsync_end = 2560 + 48 + 32,
> +       .htotal = 2560 + 48 + 32 + 80,
> +       .vdisplay = 1600,
> +       .vsync_start = 1600 + 2,
> +       .vsync_end = 1600 + 2 + 5,
> +       .vtotal = 1600 + 2 + 5 + 57,
> +       .vrefresh = 60,
> +};
> +
> +static const struct panel_desc samsung_lsn122dl01_c01 = {
> +       .modes = &samsung_lsn122dl01_c01_mode,
> +       .num_modes = 1,
> +       .size = {
> +               .width = 262,
> +               .height = 164,

Earlier you said that the active area of this panel was:

> Display area     262.656(H) X 164.16(V)         (12.2”diagonal)

In other panels I looked at the EDID tended to round numbers, not
truncate them.  For instance the Starry panel that I sent the patch
for says in the manual "262.7712 (H) x 164.232 (V)" but then the EDID
says "263 x 164".

That would mean your width should be 263 mm, not 262 mm.

-Doug

[toc] | [prev] | [next] | [standalone]

#1421685 — Re: [PATCH v3 4/6] drm/panel: simple: Add support for Samsung LSN122DL01-C01 2560x1600 panel

FromThierry Reding <thierry.reding@gmail.com>
Date2016-06-14 11:00 +0200
SubjectRe: [PATCH v3 4/6] drm/panel: simple: Add support for Samsung LSN122DL01-C01 2560x1600 panel
Message-ID<rJSmt-2tW-23@gated-at.bofh.it>
In reply to#1421061

[Multipart message — attachments visible in raw view] — view raw

On Mon, Jun 13, 2016 at 10:00:45AM -0700, Doug Anderson wrote:
> Yakir,
> 
> On Sat, Jun 11, 2016 at 7:56 PM, Yakir Yang <ykk@rock-chips.com> wrote:
> > The Samsung LSN122DL01-C01 is an 12.2" 2560x1600 (WQXGA) TFT-LCD panel
> > connected using eDP interfaces.
> >
> > Signed-off-by: Yakir Yang <ykk@rock-chips.com>
> > ---
> > Changes in v3:
> > - Correct the size of panel_desc to active area 262mmx164mm (Emil, Stéphane)
> >
> > Changes in v2: None
> >
> >  drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++++++++
> >  1 file changed, 25 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> > index 2d40a21..17cc973 100644
> > --- a/drivers/gpu/drm/panel/panel-simple.c
> > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > @@ -1246,6 +1246,28 @@ static const struct panel_desc qd43003c0_40 = {
> >         .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> >  };
> >
> > +static const struct drm_display_mode samsung_lsn122dl01_c01_mode = {
> > +       .clock = 271560,
> > +       .hdisplay = 2560,
> > +       .hsync_start = 2560 + 48,
> > +       .hsync_end = 2560 + 48 + 32,
> > +       .htotal = 2560 + 48 + 32 + 80,
> > +       .vdisplay = 1600,
> > +       .vsync_start = 1600 + 2,
> > +       .vsync_end = 1600 + 2 + 5,
> > +       .vtotal = 1600 + 2 + 5 + 57,
> > +       .vrefresh = 60,
> > +};
> > +
> > +static const struct panel_desc samsung_lsn122dl01_c01 = {
> > +       .modes = &samsung_lsn122dl01_c01_mode,
> > +       .num_modes = 1,
> > +       .size = {
> > +               .width = 262,
> > +               .height = 164,
> 
> Earlier you said that the active area of this panel was:
> 
> > Display area     262.656(H) X 164.16(V)         (12.2”diagonal)
> 
> In other panels I looked at the EDID tended to round numbers, not
> truncate them.  For instance the Starry panel that I sent the patch
> for says in the manual "262.7712 (H) x 164.232 (V)" but then the EDID
> says "263 x 164".
> 
> That would mean your width should be 263 mm, not 262 mm.

Yes, rounding is what I've also applied to all panels that I added.
While it isn't documented I hope that other panels did round, rather
than truncate, as well.

Thierry

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web