Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1416104 > unrolled thread

[PATCH v2 02/20] drm: arc: Rely on the default ->best_encoder() behavior

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v2 02/20] drm: arc: Rely on the default ->best_encoder() behavior Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-06-07 14:10 +0200
    Re: [PATCH v2 02/20] drm: arc: Rely on the default ->best_encoder()  behavior Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2016-06-10 17:10 +0200

#1416104 — [PATCH v2 02/20] drm: arc: Rely on the default ->best_encoder() behavior

We have a 1:1 relationship between connectors and encoders and the
driver is relying on the atomic helpers: we can drop the custom
->best_encoder(), and let the core call drm_atomic_helper_best_encoder()
for us.

Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
---
 drivers/gpu/drm/arc/arcpgu_hdmi.c | 18 ------------------
 1 file changed, 18 deletions(-)

diff --git a/drivers/gpu/drm/arc/arcpgu_hdmi.c b/drivers/gpu/drm/arc/arcpgu_hdmi.c
index 08b6bae..b7a8b2a 100644
--- a/drivers/gpu/drm/arc/arcpgu_hdmi.c
+++ b/drivers/gpu/drm/arc/arcpgu_hdmi.c
@@ -46,23 +46,6 @@ static int arcpgu_drm_connector_get_modes(struct drm_connector *connector)
 	return sfuncs->get_modes(&slave->base, connector);
 }
 
-struct drm_encoder *
-arcpgu_drm_connector_best_encoder(struct drm_connector *connector)
-{
-	struct drm_encoder_slave *slave;
-	struct arcpgu_drm_connector *con =
-		container_of(connector, struct arcpgu_drm_connector, connector);
-
-	slave = con->encoder_slave;
-	if (slave == NULL) {
-		dev_err(connector->dev->dev,
-			"connector_best_encoder: cannot find slave encoder for connector\n");
-		return NULL;
-	}
-
-	return &slave->base;
-}
-
 static enum drm_connector_status
 arcpgu_drm_connector_detect(struct drm_connector *connector, bool force)
 {
@@ -97,7 +80,6 @@ static void arcpgu_drm_connector_destroy(struct drm_connector *connector)
 static const struct drm_connector_helper_funcs
 arcpgu_drm_connector_helper_funcs = {
 	.get_modes = arcpgu_drm_connector_get_modes,
-	.best_encoder = arcpgu_drm_connector_best_encoder,
 };
 
 static const struct drm_connector_funcs arcpgu_drm_connector_funcs = {
-- 
2.7.4

[toc] | [next] | [standalone]

#1419507 — Re: [PATCH v2 02/20] drm: arc: Rely on the default ->best_encoder() behavior

Hi Boris,

On Tue, 2016-06-07 at 13:47 +-0200, Boris Brezillon wrote:
+AD4- We have a 1:1 relationship between connectors and encoders and the
+AD4- driver is relying on the atomic helpers: we can drop the custom
+AD4- -+AD4-best+AF8-encoder(), and let the core call drm+AF8-atomic+AF8-helper+AF8-best+AF8-encoder()
+AD4- for us.
+AD4- 
+AD4- Signed-off-by: Boris Brezillon +ADw-boris.brezillon+AEA-free-electrons.com+AD4-
+AD4- ---

Acked-by: Alexey Brodkin +ADw-abrodkin+AEA-synopsys.com+AD4-

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web