Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1419785 > unrolled thread
| Started by | Andy Lutomirski <luto@amacapital.net> |
|---|---|
| First post | 2016-06-11 00:20 +0200 |
| Last post | 2016-06-11 11:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [Xen-devel] [PATCH 1/7] x86/xen: Simplify set_aliased_prot Andy Lutomirski <luto@amacapital.net> - 2016-06-11 00:20 +0200
Re: [Xen-devel] [PATCH 1/7] x86/xen: Simplify set_aliased_prot Ingo Molnar <mingo@kernel.org> - 2016-06-11 11:30 +0200
| From | Andy Lutomirski <luto@amacapital.net> |
|---|---|
| Date | 2016-06-11 00:20 +0200 |
| Subject | Re: [Xen-devel] [PATCH 1/7] x86/xen: Simplify set_aliased_prot |
| Message-ID | <rICWu-2P1-21@gated-at.bofh.it> |
On Wed, May 25, 2016 at 2:50 AM, David Vrabel <david.vrabel@citrix.com> wrote:
> On 24/05/16 23:48, Andy Lutomirski wrote:
>> In aa1acff356bb ("x86/xen: Probe target addresses in
>> set_aliased_prot() before the hypercall"), I added an explicit probe
>> to work around a hypercall issue. The code can be simplified by
>> using probe_kernel_read.
>
> Acked-by: David Vrabel <david.vrabel@citrix.com>
Ingo, can you apply this one patch directly to x86/asm? The rest of
the series is stalled pending my fixing Borislav's review comments
and, more importantly, fixing the bugs that testing it has shaken
loose. This patch is a nice cleanup all by itself, though.
--Andy
[toc] | [next] | [standalone]
| From | Ingo Molnar <mingo@kernel.org> |
|---|---|
| Date | 2016-06-11 11:30 +0200 |
| Message-ID | <rINoR-1h4-15@gated-at.bofh.it> |
| In reply to | #1419785 |
* Andy Lutomirski <luto@amacapital.net> wrote:
> On Wed, May 25, 2016 at 2:50 AM, David Vrabel <david.vrabel@citrix.com> wrote:
> > On 24/05/16 23:48, Andy Lutomirski wrote:
> >> In aa1acff356bb ("x86/xen: Probe target addresses in
> >> set_aliased_prot() before the hypercall"), I added an explicit probe
> >> to work around a hypercall issue. The code can be simplified by
> >> using probe_kernel_read.
> >
> > Acked-by: David Vrabel <david.vrabel@citrix.com>
>
> Ingo, can you apply this one patch directly to x86/asm? The rest of
> the series is stalled pending my fixing Borislav's review comments
> and, more importantly, fixing the bugs that testing it has shaken
> loose. This patch is a nice cleanup all by itself, though.
Ok, agreed, done.
Note that I simplified it some more:
- probe_kernel_read(&dummy, (unsigned char *)v, 1);
+ probe_kernel_read(&dummy, v, 1);
... because 'v' already has a 'void *' natural type.
Thanks,
Ingo
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web