Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1411381 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2016-06-01 18:30 +0200 |
| Last post | 2016-06-07 22:10 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] rtl8xxxu: fix typo on variable name, compare against correct variable Colin King <colin.king@canonical.com> - 2016-06-01 18:30 +0200
Re: [PATCH] rtl8xxxu: fix typo on variable name, compare against correct variable Jes Sorensen <Jes.Sorensen@redhat.com> - 2016-06-03 21:40 +0200
Re: [PATCH] rtl8xxxu: fix typo on variable name, compare against correct variable Jes Sorensen <Jes.Sorensen@redhat.com> - 2016-06-07 22:10 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2016-06-01 18:30 +0200 |
| Subject | [PATCH] rtl8xxxu: fix typo on variable name, compare against correct variable |
| Message-ID | <rFhbR-2gC-77@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
path_b_ok is being assigned but immediately after path_a_ok is being
compared to the value 0x03. This appears to be a typo on the
variable name, compare path_b_ok instead.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c
index fe19ace..b04cf30 100644
--- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c
+++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c
@@ -1149,7 +1149,7 @@ static void rtl8192eu_phy_iqcalibrate(struct rtl8xxxu_priv *priv,
for (i = 0; i < retry; i++) {
path_b_ok = rtl8192eu_rx_iqk_path_b(priv);
- if (path_a_ok == 0x03) {
+ if (path_b_ok == 0x03) {
val32 = rtl8xxxu_read32(priv,
REG_RX_POWER_BEFORE_IQK_B_2);
result[t][6] = (val32 >> 16) & 0x3ff;
--
2.8.1
[toc] | [next] | [standalone]
| From | Jes Sorensen <Jes.Sorensen@redhat.com> |
|---|---|
| Date | 2016-06-03 21:40 +0200 |
| Message-ID | <rG36N-7m7-7@gated-at.bofh.it> |
| In reply to | #1411381 |
Colin King <colin.king@canonical.com> writes:
> From: Colin Ian King <colin.king@canonical.com>
>
> path_b_ok is being assigned but immediately after path_a_ok is being
> compared to the value 0x03. This appears to be a typo on the
> variable name, compare path_b_ok instead.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c
> index fe19ace..b04cf30 100644
> --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c
> +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c
> @@ -1149,7 +1149,7 @@ static void rtl8192eu_phy_iqcalibrate(struct rtl8xxxu_priv *priv,
>
> for (i = 0; i < retry; i++) {
> path_b_ok = rtl8192eu_rx_iqk_path_b(priv);
> - if (path_a_ok == 0x03) {
> + if (path_b_ok == 0x03) {
> val32 = rtl8xxxu_read32(priv,
> REG_RX_POWER_BEFORE_IQK_B_2);
> result[t][6] = (val32 >> 16) & 0x3ff;
Nice catch, that does indeed look like a bug!
Thanks, I want to test it, but I plan to apply it to rtl8xxxu-devel
shortly.
Cheers,
Jes
[toc] | [prev] | [next] | [standalone]
| From | Jes Sorensen <Jes.Sorensen@redhat.com> |
|---|---|
| Date | 2016-06-07 22:10 +0200 |
| Message-ID | <rHvu2-7bR-23@gated-at.bofh.it> |
| In reply to | #1413421 |
Jes Sorensen <Jes.Sorensen@redhat.com> writes:
> Colin King <colin.king@canonical.com> writes:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> path_b_ok is being assigned but immediately after path_a_ok is being
>> compared to the value 0x03. This appears to be a typo on the
>> variable name, compare path_b_ok instead.
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c
>> index fe19ace..b04cf30 100644
>> --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c
>> +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c
>> @@ -1149,7 +1149,7 @@ static void rtl8192eu_phy_iqcalibrate(struct rtl8xxxu_priv *priv,
>>
>> for (i = 0; i < retry; i++) {
>> path_b_ok = rtl8192eu_rx_iqk_path_b(priv);
>> - if (path_a_ok == 0x03) {
>> + if (path_b_ok == 0x03) {
>> val32 = rtl8xxxu_read32(priv,
>> REG_RX_POWER_BEFORE_IQK_B_2);
>> result[t][6] = (val32 >> 16) & 0x3ff;
>
> Nice catch, that does indeed look like a bug!
>
> Thanks, I want to test it, but I plan to apply it to rtl8xxxu-devel
> shortly.
Tested and applied!
Thanks,
Jes
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web