Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1416529 > unrolled thread
| Started by | Bhaktipriya Shridhar <bhaktipriya96@gmail.com> |
|---|---|
| First post | 2016-06-07 21:40 +0200 |
| Last post | 2016-06-11 08:00 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] RDS: IB: Remove deprecated create_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-06-07 21:40 +0200
Re: [PATCH] RDS: IB: Remove deprecated create_workqueue Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2016-06-07 22:40 +0200
Re: [PATCH] RDS: IB: Remove deprecated create_workqueue David Miller <davem@davemloft.net> - 2016-06-11 08:00 +0200
| From | Bhaktipriya Shridhar <bhaktipriya96@gmail.com> |
|---|---|
| Date | 2016-06-07 21:40 +0200 |
| Subject | [PATCH] RDS: IB: Remove deprecated create_workqueue |
| Message-ID | <rHv0Z-6Mo-19@gated-at.bofh.it> |
alloc_workqueue replaces deprecated create_workqueue().
Since the driver is infiniband which can be used as block device and the
workqueue seems involved in regular operation of the device, so a
dedicated workqueue has been used with WQ_MEM_RECLAIM set to guarantee
forward progress under memory pressure.
Since there are only a fixed number of work items, explicit concurrency
limit is unnecessary here.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
net/rds/ib_rdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/rds/ib_rdma.c b/net/rds/ib_rdma.c
index f7164ac..a0f21b6 100644
--- a/net/rds/ib_rdma.c
+++ b/net/rds/ib_rdma.c
@@ -618,7 +618,7 @@ struct rds_ib_mr_pool *rds_ib_create_mr_pool(struct rds_ib_device *rds_ibdev,
int rds_ib_mr_init(void)
{
- rds_ib_mr_wq = create_workqueue("rds_mr_flushd");
+ rds_ib_mr_wq = alloc_workqueue("rds_mr_flushd", WQ_MEM_RECLAIM, 0);
if (!rds_ib_mr_wq)
return -ENOMEM;
return 0;
--
2.1.4
[toc] | [next] | [standalone]
| From | Santosh Shilimkar <santosh.shilimkar@oracle.com> |
|---|---|
| Date | 2016-06-07 22:40 +0200 |
| Message-ID | <rHvX4-7lS-19@gated-at.bofh.it> |
| In reply to | #1416529 |
Hi, On 6/7/2016 12:33 PM, Bhaktipriya Shridhar wrote: > alloc_workqueue replaces deprecated create_workqueue(). > > Since the driver is infiniband which can be used as block device and the > workqueue seems involved in regular operation of the device, so a > dedicated workqueue has been used with WQ_MEM_RECLAIM set to guarantee > forward progress under memory pressure. > Since there are only a fixed number of work items, explicit concurrency > limit is unnecessary here. > > Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> > --- Looks fine. Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2016-06-11 08:00 +0200 |
| Message-ID | <rIK7E-7w3-7@gated-at.bofh.it> |
| In reply to | #1416529 |
From: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Date: Wed, 8 Jun 2016 01:03:45 +0530 > alloc_workqueue replaces deprecated create_workqueue(). > > Since the driver is infiniband which can be used as block device and the > workqueue seems involved in regular operation of the device, so a > dedicated workqueue has been used with WQ_MEM_RECLAIM set to guarantee > forward progress under memory pressure. > Since there are only a fixed number of work items, explicit concurrency > limit is unnecessary here. > > Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Applied, thanks.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web