Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1416429 > unrolled thread

[PATCH v2] staging: lustre: lustre: obdclass: Modify return statement

Back to article view | Back to linux.kernel

Contents

  [PATCH v2] staging: lustre: lustre: obdclass: Modify return statement Anchal Jain <anchalj109@gmail.com> - 2016-06-07 19:10 +0200
    Re: [PATCH v2] staging: lustre: lustre: obdclass: Modify return  statement Greg KH <gregkh@linuxfoundation.org> - 2016-06-07 19:40 +0200

#1416429 — [PATCH v2] staging: lustre: lustre: obdclass: Modify return statement

Modify the return statement.
The Coccinelle semantic patch used to make this change is as follows:

@@
expression e, ret;
@@

-ret =
+return
        e;
-return ret;

Delete the declaration of the return variable rc, as it is no longer used.


Signed-off-by: Anchal Jain <anchalj109@gmail.com>
---
changes in v2
	--add public cc with patch
 drivers/staging/lustre/lustre/obdclass/llog_cat.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/staging/lustre/lustre/obdclass/llog_cat.c b/drivers/staging/lustre/lustre/obdclass/llog_cat.c
index c27d4ec..55f625f 100644
--- a/drivers/staging/lustre/lustre/obdclass/llog_cat.c
+++ b/drivers/staging/lustre/lustre/obdclass/llog_cat.c
@@ -127,7 +127,6 @@ out:
 int llog_cat_close(const struct lu_env *env, struct llog_handle *cathandle)
 {
 	struct llog_handle	*loghandle, *n;
-	int			 rc;
 
 	list_for_each_entry_safe(loghandle, n, &cathandle->u.chd.chd_head,
 				 u.phd.phd_entry) {
@@ -138,8 +137,7 @@ int llog_cat_close(const struct lu_env *env, struct llog_handle *cathandle)
 	/* if handle was stored in ctxt, remove it too */
 	if (cathandle->lgh_ctxt->loc_handle == cathandle)
 		cathandle->lgh_ctxt->loc_handle = NULL;
-	rc = llog_close(env, cathandle);
-	return rc;
+	return llog_close(env, cathandle);
 }
 EXPORT_SYMBOL(llog_cat_close);
 
-- 
1.9.1

[toc] | [next] | [standalone]

#1416451 — Re: [PATCH v2] staging: lustre: lustre: obdclass: Modify return statement

On Tue, Jun 07, 2016 at 10:34:01PM +0530, Anchal Jain wrote:
> Modify the return statement.
> The Coccinelle semantic patch used to make this change is as follows:
> 
> @@
> expression e, ret;
> @@
> 
> -ret =
> +return
>         e;
> -return ret;
> 
> Delete the declaration of the return variable rc, as it is no longer used.
> 
> 
> Signed-off-by: Anchal Jain <anchalj109@gmail.com>
> ---
> changes in v2
> 	--add public cc with patch

Please use scripts/get_maintainer.pl to determine who and what lists
to send patches to (hint, lkml is almost never the correct list to
_only_ send patches to.)

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web