Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1416247 > unrolled thread
| Started by | Ben Dooks <ben.dooks@codethink.co.uk> |
|---|---|
| First post | 2016-06-07 16:20 +0200 |
| Last post | 2016-06-07 16:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] clocksource/drivers/armada-370-xp: make syscore_ops static Ben Dooks <ben.dooks@codethink.co.uk> - 2016-06-07 16:20 +0200
Re: [PATCH] clocksource/drivers/armada-370-xp: make syscore_ops static Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-06-07 16:30 +0200
| From | Ben Dooks <ben.dooks@codethink.co.uk> |
|---|---|
| Date | 2016-06-07 16:20 +0200 |
| Subject | [PATCH] clocksource/drivers/armada-370-xp: make syscore_ops static |
| Message-ID | <rHq1j-3KB-5@gated-at.bofh.it> |
The driver does not export armada_370_xp_timer_syscore_ops so
make it static to fix the following warning:
drivers/clocksource/time-armada-370-xp.c:249:20: warning: symbol 'armada_370_xp_timer_syscore_ops' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
---
drivers/clocksource/time-armada-370-xp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/time-armada-370-xp.c b/drivers/clocksource/time-armada-370-xp.c
index d93ec3c..601dbf74 100644
--- a/drivers/clocksource/time-armada-370-xp.c
+++ b/drivers/clocksource/time-armada-370-xp.c
@@ -246,7 +246,7 @@ static void armada_370_xp_timer_resume(void)
writel(timer0_local_ctrl_reg, local_base + TIMER_CTRL_OFF);
}
-struct syscore_ops armada_370_xp_timer_syscore_ops = {
+static struct syscore_ops armada_370_xp_timer_syscore_ops = {
.suspend = armada_370_xp_timer_suspend,
.resume = armada_370_xp_timer_resume,
};
--
2.8.1
[toc] | [next] | [standalone]
| From | Gregory CLEMENT <gregory.clement@free-electrons.com> |
|---|---|
| Date | 2016-06-07 16:30 +0200 |
| Message-ID | <rHqaZ-3ND-5@gated-at.bofh.it> |
| In reply to | #1416247 |
Hi Ben,
On mar., juin 07 2016, Ben Dooks <ben.dooks@codethink.co.uk> wrote:
> The driver does not export armada_370_xp_timer_syscore_ops so
> make it static to fix the following warning:
>
> drivers/clocksource/time-armada-370-xp.c:249:20: warning: symbol 'armada_370_xp_timer_syscore_ops' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Thanks,
Gregory
> ---
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> ---
> drivers/clocksource/time-armada-370-xp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/time-armada-370-xp.c b/drivers/clocksource/time-armada-370-xp.c
> index d93ec3c..601dbf74 100644
> --- a/drivers/clocksource/time-armada-370-xp.c
> +++ b/drivers/clocksource/time-armada-370-xp.c
> @@ -246,7 +246,7 @@ static void armada_370_xp_timer_resume(void)
> writel(timer0_local_ctrl_reg, local_base + TIMER_CTRL_OFF);
> }
>
> -struct syscore_ops armada_370_xp_timer_syscore_ops = {
> +static struct syscore_ops armada_370_xp_timer_syscore_ops = {
> .suspend = armada_370_xp_timer_suspend,
> .resume = armada_370_xp_timer_resume,
> };
> --
> 2.8.1
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web