Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1416117 > unrolled thread
| Started by | Ben Dooks <ben.dooks@codethink.co.uk> |
|---|---|
| First post | 2016-06-07 14:30 +0200 |
| Last post | 2016-06-10 17:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] irqchip/tegra: fix fix sparse warnings on __iomem Ben Dooks <ben.dooks@codethink.co.uk> - 2016-06-07 14:30 +0200
Re: [PATCH] irqchip/tegra: fix fix sparse warnings on __iomem Thierry Reding <thierry.reding@gmail.com> - 2016-06-10 17:50 +0200
| From | Ben Dooks <ben.dooks@codethink.co.uk> |
|---|---|
| Date | 2016-06-07 14:30 +0200 |
| Subject | [PATCH] irqchip/tegra: fix fix sparse warnings on __iomem |
| Message-ID | <rHoiR-2DC-1@gated-at.bofh.it> |
Fix the following warnings from sparse due to casting to/from __iomem
annotated variables:
drivers/irqchip/irq-tegra.c:93:31: warning: incorrect type in initializer (different address spaces)
drivers/irqchip/irq-tegra.c:93:31: expected void [noderef] <asn:2>*base
drivers/irqchip/irq-tegra.c:93:31: got void *chip_data
drivers/irqchip/irq-tegra.c:93:31: warning: incorrect type in initializer (different address spaces)
drivers/irqchip/irq-tegra.c:93:31: expected void [noderef] <asn:2>*base
drivers/irqchip/irq-tegra.c:93:31: got void *chip_data
drivers/irqchip/irq-tegra.c:93:31: warning: incorrect type in initializer (different address spaces)
drivers/irqchip/irq-tegra.c:93:31: expected void [noderef] <asn:2>*base
drivers/irqchip/irq-tegra.c:93:31: got void *chip_data
drivers/irqchip/irq-tegra.c:93:31: warning: incorrect type in initializer (different address spaces)
drivers/irqchip/irq-tegra.c:93:31: expected void [noderef] <asn:2>*base
drivers/irqchip/irq-tegra.c:93:31: got void *chip_data
drivers/irqchip/irq-tegra.c:269:57: warning: incorrect type in argument 5 (different address spaces)
drivers/irqchip/irq-tegra.c:269:57: expected void *chip_data
drivers/irqchip/irq-tegra.c:269:57: got void [noderef] <asn:2>*<noident>
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: linux-kernel@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: Stephen Warren <swarren@wwwdotorg.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Alexandre Courbot <gnurou@gmail.com>
Cc: linux-tegra@vger.kernel.org
---
drivers/irqchip/irq-tegra.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-tegra.c b/drivers/irqchip/irq-tegra.c
index e902f08..3973a14 100644
--- a/drivers/irqchip/irq-tegra.c
+++ b/drivers/irqchip/irq-tegra.c
@@ -90,7 +90,7 @@ static struct tegra_ictlr_info *lic;
static inline void tegra_ictlr_write_mask(struct irq_data *d, unsigned long reg)
{
- void __iomem *base = d->chip_data;
+ void __iomem *base = (void __iomem __force *)d->chip_data;
u32 mask;
mask = BIT(d->hwirq % 32);
@@ -266,7 +266,7 @@ static int tegra_ictlr_domain_alloc(struct irq_domain *domain,
irq_domain_set_hwirq_and_chip(domain, virq + i, hwirq + i,
&tegra_ictlr_chip,
- info->base[ictlr]);
+ (void __force *)info->base[ictlr]);
}
parent_fwspec = *fwspec;
--
2.8.1
[toc] | [next] | [standalone]
| From | Thierry Reding <thierry.reding@gmail.com> |
|---|---|
| Date | 2016-06-10 17:50 +0200 |
| Message-ID | <rIwR3-6nN-17@gated-at.bofh.it> |
| In reply to | #1416117 |
[Multipart message — attachments visible in raw view] — view raw
On Tue, Jun 07, 2016 at 01:24:52PM +0100, Ben Dooks wrote: > Fix the following warnings from sparse due to casting to/from __iomem > annotated variables: > > drivers/irqchip/irq-tegra.c:93:31: warning: incorrect type in initializer (different address spaces) > drivers/irqchip/irq-tegra.c:93:31: expected void [noderef] <asn:2>*base > drivers/irqchip/irq-tegra.c:93:31: got void *chip_data > drivers/irqchip/irq-tegra.c:93:31: warning: incorrect type in initializer (different address spaces) > drivers/irqchip/irq-tegra.c:93:31: expected void [noderef] <asn:2>*base > drivers/irqchip/irq-tegra.c:93:31: got void *chip_data > drivers/irqchip/irq-tegra.c:93:31: warning: incorrect type in initializer (different address spaces) > drivers/irqchip/irq-tegra.c:93:31: expected void [noderef] <asn:2>*base > drivers/irqchip/irq-tegra.c:93:31: got void *chip_data > drivers/irqchip/irq-tegra.c:93:31: warning: incorrect type in initializer (different address spaces) > drivers/irqchip/irq-tegra.c:93:31: expected void [noderef] <asn:2>*base > drivers/irqchip/irq-tegra.c:93:31: got void *chip_data > drivers/irqchip/irq-tegra.c:269:57: warning: incorrect type in argument 5 (different address spaces) > drivers/irqchip/irq-tegra.c:269:57: expected void *chip_data > drivers/irqchip/irq-tegra.c:269:57: got void [noderef] <asn:2>*<noident> > > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> > --- > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Jason Cooper <jason@lakedaemon.net> > Cc: Marc Zyngier <marc.zyngier@arm.com> > Cc: linux-kernel@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: Stephen Warren <swarren@wwwdotorg.org> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: Alexandre Courbot <gnurou@gmail.com> > Cc: linux-tegra@vger.kernel.org > --- > drivers/irqchip/irq-tegra.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Acked-by: Thierry Reding <treding@nvidia.com>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web