Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1414740 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2016-06-06 10:30 +0200 |
| Last post | 2016-06-08 01:20 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH][V2] net: fec: fix spelling mistakes and add missing newline Colin King <colin.king@canonical.com> - 2016-06-06 10:30 +0200
RE: [PATCH][V2] net: fec: fix spelling mistakes and add missing newline Fugang Duan <fugang.duan@nxp.com> - 2016-06-07 04:10 +0200
Re: [PATCH][V2] net: fec: fix spelling mistakes and add missing newline David Miller <davem@davemloft.net> - 2016-06-08 01:20 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2016-06-06 10:30 +0200 |
| Subject | [PATCH][V2] net: fec: fix spelling mistakes and add missing newline |
| Message-ID | <rGY54-2mT-17@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
trivial fix to spelling mistakes and add missing newline in pr_err
messages
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/freescale/fec_main.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 3c0255e..fea0f33 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -2416,24 +2416,24 @@ fec_enet_set_coalesce(struct net_device *ndev, struct ethtool_coalesce *ec)
return -EOPNOTSUPP;
if (ec->rx_max_coalesced_frames > 255) {
- pr_err("Rx coalesced frames exceed hardware limiation");
+ pr_err("Rx coalesced frames exceed hardware limitation\n");
return -EINVAL;
}
if (ec->tx_max_coalesced_frames > 255) {
- pr_err("Tx coalesced frame exceed hardware limiation");
+ pr_err("Tx coalesced frame exceed hardware limitation\n");
return -EINVAL;
}
cycle = fec_enet_us_to_itr_clock(ndev, fep->rx_time_itr);
if (cycle > 0xFFFF) {
- pr_err("Rx coalesed usec exceeed hardware limiation");
+ pr_err("Rx coalesced usec exceed hardware limitation\n");
return -EINVAL;
}
cycle = fec_enet_us_to_itr_clock(ndev, fep->tx_time_itr);
if (cycle > 0xFFFF) {
- pr_err("Rx coalesed usec exceeed hardware limiation");
+ pr_err("Rx coalesced usec exceed hardware limitation\n");
return -EINVAL;
}
--
2.8.1
[toc] | [next] | [standalone]
| From | Fugang Duan <fugang.duan@nxp.com> |
|---|---|
| Date | 2016-06-07 04:10 +0200 |
| Subject | RE: [PATCH][V2] net: fec: fix spelling mistakes and add missing newline |
| Message-ID | <rHeCR-4O2-5@gated-at.bofh.it> |
| In reply to | #1414740 |
From: Colin King <colin.king@canonical.com> Sent: Monday, June 06, 2016 4:22 PM
> To: Fugang Duan <fugang.duan@nxp.com>; netdev@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Subject: [PATCH][V2] net: fec: fix spelling mistakes and add missing newline
>
> From: Colin Ian King <colin.king@canonical.com>
>
> trivial fix to spelling mistakes and add missing newline in pr_err messages
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/ethernet/freescale/fec_main.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/fec_main.c
> b/drivers/net/ethernet/freescale/fec_main.c
> index 3c0255e..fea0f33 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -2416,24 +2416,24 @@ fec_enet_set_coalesce(struct net_device *ndev,
> struct ethtool_coalesce *ec)
> return -EOPNOTSUPP;
>
> if (ec->rx_max_coalesced_frames > 255) {
> - pr_err("Rx coalesced frames exceed hardware limiation");
> + pr_err("Rx coalesced frames exceed hardware limitation\n");
> return -EINVAL;
> }
>
> if (ec->tx_max_coalesced_frames > 255) {
> - pr_err("Tx coalesced frame exceed hardware limiation");
> + pr_err("Tx coalesced frame exceed hardware limitation\n");
> return -EINVAL;
> }
>
> cycle = fec_enet_us_to_itr_clock(ndev, fep->rx_time_itr);
> if (cycle > 0xFFFF) {
> - pr_err("Rx coalesed usec exceeed hardware limiation");
> + pr_err("Rx coalesced usec exceed hardware limitation\n");
> return -EINVAL;
> }
>
> cycle = fec_enet_us_to_itr_clock(ndev, fep->tx_time_itr);
> if (cycle > 0xFFFF) {
> - pr_err("Rx coalesed usec exceeed hardware limiation");
> + pr_err("Rx coalesced usec exceed hardware limitation\n");
> return -EINVAL;
> }
>
> --
> 2.8.1
Acked-by: Fugang Duan <fugang.duan@nxp.com>
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2016-06-08 01:20 +0200 |
| Subject | Re: [PATCH][V2] net: fec: fix spelling mistakes and add missing newline |
| Message-ID | <rHyrT-Ac-1@gated-at.bofh.it> |
| In reply to | #1414740 |
From: Colin King <colin.king@canonical.com> Date: Mon, 6 Jun 2016 09:21:44 +0100 > From: Colin Ian King <colin.king@canonical.com> > > trivial fix to spelling mistakes and add missing newline in pr_err > messages > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Applied.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web