Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1417930 > unrolled thread

Re: [PATCH V6 5/8] vfio: platform: call _RST method when using ACPI

Started by"Rafael J. Wysocki" <rafael@kernel.org>
First post2016-06-09 00:40 +0200
Last post2016-06-09 04:40 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH V6 5/8] vfio: platform: call _RST method when using ACPI "Rafael J. Wysocki" <rafael@kernel.org> - 2016-06-09 00:40 +0200
    Re: [PATCH V6 5/8] vfio: platform: call _RST method when using ACPI Sinan Kaya <okaya@codeaurora.org> - 2016-06-09 04:40 +0200

#1417930 — Re: [PATCH V6 5/8] vfio: platform: call _RST method when using ACPI

From"Rafael J. Wysocki" <rafael@kernel.org>
Date2016-06-09 00:40 +0200
SubjectRe: [PATCH V6 5/8] vfio: platform: call _RST method when using ACPI
Message-ID<rHUiK-6a7-35@gated-at.bofh.it>
On Sun, May 29, 2016 at 12:01 AM, Sinan Kaya <okaya@codeaurora.org> wrote:
> The device tree code checks for the presence of a reset driver and calls
> the of_reset function pointer by looking up the reset driver as a module.
>
> ACPI defines _RST method to perform device level reset. After the _RST
> method is executed, the OS can resume using the device. _RST method is
> expected to stop DMA transfers and IRQs.
>
> This patch checks the presence of _RST method and calls the _RST
> method when reset is requested.

You could check if _RST is present at probe time and store the ACPI
handle of it instead of the HID pointer.

This way you wouldn't need to repeat that check every time reset is used.

[toc] | [next] | [standalone]


#1418023

FromSinan Kaya <okaya@codeaurora.org>
Date2016-06-09 04:40 +0200
Message-ID<rHY30-7L-9@gated-at.bofh.it>
In reply to#1417930
On 6/8/2016 6:31 PM, Rafael J. Wysocki wrote:
> On Sun, May 29, 2016 at 12:01 AM, Sinan Kaya <okaya@codeaurora.org> wrote:
>> The device tree code checks for the presence of a reset driver and calls
>> the of_reset function pointer by looking up the reset driver as a module.
>>
>> ACPI defines _RST method to perform device level reset. After the _RST
>> method is executed, the OS can resume using the device. _RST method is
>> expected to stop DMA transfers and IRQs.
>>
>> This patch checks the presence of _RST method and calls the _RST
>> method when reset is requested.
> 
> You could check if _RST is present at probe time and store the ACPI
> handle of it instead of the HID pointer.
> 
> This way you wouldn't need to repeat that check every time reset is used.
> 

Makes sense. I'll give it a shot.

-- 
Sinan Kaya
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web