Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1416994 > unrolled thread
| Started by | Binoy Jayan <binoy.jayan@linaro.org> |
|---|---|
| First post | 2016-06-08 09:50 +0200 |
| Last post | 2016-06-08 17:40 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH 0/2] *** r8723au: Replace semaphore lock with mutex *** Binoy Jayan <binoy.jayan@linaro.org> - 2016-06-08 09:50 +0200
[PATCH 2/2] staging: r8723au: Remove unused semaphores Binoy Jayan <binoy.jayan@linaro.org> - 2016-06-08 09:50 +0200
Re: [PATCH 0/2] *** r8723au: Replace semaphore lock with mutex *** Jes Sorensen <Jes.Sorensen@redhat.com> - 2016-06-08 14:30 +0200
Re: [PATCH 0/2] *** r8723au: Replace semaphore lock with mutex *** Arnd Bergmann <arnd@arndb.de> - 2016-06-08 17:40 +0200
| From | Binoy Jayan <binoy.jayan@linaro.org> |
|---|---|
| Date | 2016-06-08 09:50 +0200 |
| Subject | [PATCH 0/2] *** r8723au: Replace semaphore lock with mutex *** |
| Message-ID | <rHGpr-5GS-3@gated-at.bofh.it> |
Hi, These are a set of patches which removes semaphores from: drivers/staging/rtl8723au These are part of a bigger effort to eliminate all semaphores from the linux kernel. They build correctly (individually and as a whole). NB: I have not tested this as I do not have the following hardware: R8723AU "Realtek RTL8723AU Wireless LAN NIC driver" Thanks, Binoy Binoy Jayan (2): staging: r8723au: pwrctrl_priv: Replace semaphore lock with mutex staging: r8723au: Remove unused semaphores drivers/staging/rtl8723au/core/rtw_pwrctrl.c | 11 ++++++----- drivers/staging/rtl8723au/core/rtw_xmit.c | 4 ---- drivers/staging/rtl8723au/include/osdep_service.h | 1 - drivers/staging/rtl8723au/include/rtw_io.h | 2 -- drivers/staging/rtl8723au/include/rtw_pwrctrl.h | 3 ++- drivers/staging/rtl8723au/include/rtw_xmit.h | 5 ----- drivers/staging/rtl8723au/os_dep/usb_intf.c | 11 ++++++----- 7 files changed, 14 insertions(+), 23 deletions(-) -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
[toc] | [next] | [standalone]
| From | Binoy Jayan <binoy.jayan@linaro.org> |
|---|---|
| Date | 2016-06-08 09:50 +0200 |
| Subject | [PATCH 2/2] staging: r8723au: Remove unused semaphores |
| Message-ID | <rHGps-5GS-15@gated-at.bofh.it> |
| In reply to | #1416994 |
The semaphores xmit_sema, terminate_xmitthread_sema, tx_retevt and
io_req have no users, hence remove all references to them.
Semaphores are going away in the future.
Signed-off-by: Binoy Jayan <binoy.jayan@linaro.org>
---
drivers/staging/rtl8723au/core/rtw_xmit.c | 4 ----
drivers/staging/rtl8723au/include/osdep_service.h | 1 -
drivers/staging/rtl8723au/include/rtw_io.h | 2 --
drivers/staging/rtl8723au/include/rtw_xmit.h | 5 -----
4 files changed, 12 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_xmit.c b/drivers/staging/rtl8723au/core/rtw_xmit.c
index 3de40cf..003576d 100644
--- a/drivers/staging/rtl8723au/core/rtw_xmit.c
+++ b/drivers/staging/rtl8723au/core/rtw_xmit.c
@@ -60,8 +60,6 @@ int _rtw_init_xmit_priv23a(struct xmit_priv *pxmitpriv,
spin_lock_init(&pxmitpriv->lock);
spin_lock_init(&pxmitpriv->lock_sctx);
- sema_init(&pxmitpriv->xmit_sema, 0);
- sema_init(&pxmitpriv->terminate_xmitthread_sema, 0);
pxmitpriv->adapter = padapter;
@@ -177,8 +175,6 @@ int _rtw_init_xmit_priv23a(struct xmit_priv *pxmitpriv,
for (i = 0; i < 4; i ++)
pxmitpriv->wmm_para_seq[i] = i;
- sema_init(&pxmitpriv->tx_retevt, 0);
-
pxmitpriv->ack_tx = false;
mutex_init(&pxmitpriv->ack_tx_mutex);
rtw_sctx_init23a(&pxmitpriv->ack_tx_ops, 0);
diff --git a/drivers/staging/rtl8723au/include/osdep_service.h b/drivers/staging/rtl8723au/include/osdep_service.h
index 98250b1..33ecb9c 100644
--- a/drivers/staging/rtl8723au/include/osdep_service.h
+++ b/drivers/staging/rtl8723au/include/osdep_service.h
@@ -33,7 +33,6 @@
#include <asm/byteorder.h>
#include <linux/atomic.h>
#include <linux/io.h>
-#include <linux/semaphore.h>
#include <linux/sem.h>
#include <linux/sched.h>
#include <linux/etherdevice.h>
diff --git a/drivers/staging/rtl8723au/include/rtw_io.h b/drivers/staging/rtl8723au/include/rtw_io.h
index c8119e2..d875e9e 100644
--- a/drivers/staging/rtl8723au/include/rtw_io.h
+++ b/drivers/staging/rtl8723au/include/rtw_io.h
@@ -20,7 +20,6 @@
#include <osdep_intf.h>
#include <asm/byteorder.h>
-#include <linux/semaphore.h>
#include <linux/list.h>
/* include <linux/smp_lock.h> */
#include <linux/spinlock.h>
@@ -105,7 +104,6 @@ struct io_req {
u32 command;
u32 status;
u8 *pbuf;
- struct semaphore sema;
void (*_async_io_callback)(struct rtw_adapter *padater, struct io_req *pio_req, u8 *cnxt);
u8 *cnxt;
diff --git a/drivers/staging/rtl8723au/include/rtw_xmit.h b/drivers/staging/rtl8723au/include/rtw_xmit.h
index 2b7d6d0..24f326b 100644
--- a/drivers/staging/rtl8723au/include/rtw_xmit.h
+++ b/drivers/staging/rtl8723au/include/rtw_xmit.h
@@ -275,9 +275,6 @@ struct agg_pkt_info {
struct xmit_priv {
spinlock_t lock;
- struct semaphore xmit_sema;
- struct semaphore terminate_xmitthread_sema;
-
struct rtw_queue be_pending;
struct rtw_queue bk_pending;
struct rtw_queue vi_pending;
@@ -310,8 +307,6 @@ struct xmit_priv {
* 2->be, 3->bk.
*/
- struct semaphore tx_retevt;/* all tx return event; */
-
struct tasklet_struct xmit_tasklet;
struct rtw_queue free_xmitbuf_queue;
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
[toc] | [prev] | [next] | [standalone]
| From | Jes Sorensen <Jes.Sorensen@redhat.com> |
|---|---|
| Date | 2016-06-08 14:30 +0200 |
| Message-ID | <rHKMp-8w1-1@gated-at.bofh.it> |
| In reply to | #1416994 |
Binoy Jayan <binoy.jayan@linaro.org> writes: > Hi, > > These are a set of patches which removes semaphores from: > > drivers/staging/rtl8723au > > These are part of a bigger effort to eliminate all semaphores > from the linux kernel. > > They build correctly (individually and as a whole). > NB: I have not tested this as I do not have the following hardware: > > R8723AU > "Realtek RTL8723AU Wireless LAN NIC driver" I am not against this, but please note this driver is already marked for deletion in a future kernel release. Cheers, Jes
[toc] | [prev] | [next] | [standalone]
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-06-08 17:40 +0200 |
| Message-ID | <rHNKj-1Yh-41@gated-at.bofh.it> |
| In reply to | #1416994 |
On Wednesday, June 8, 2016 1:10:53 PM CEST Binoy Jayan wrote: > These are a set of patches which removes semaphores from: > > drivers/staging/rtl8723au > > These are part of a bigger effort to eliminate all semaphores > from the linux kernel. > > They build correctly (individually and as a whole). Looks good, Reviewed-by: Arnd Bergmann <arnd@arndb.de>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web