Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1416981 > unrolled thread
| Started by | Chen-Yu Tsai <wens@csie.org> |
|---|---|
| First post | 2016-06-08 09:40 +0200 |
| Last post | 2016-06-09 21:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] ARM: dts: sun8i-h3: sinovoip-bpi-m2-plus: Fix LED and switch labels Chen-Yu Tsai <wens@csie.org> - 2016-06-08 09:40 +0200
Re: [PATCH] ARM: dts: sun8i-h3: sinovoip-bpi-m2-plus: Fix LED and switch labels Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-06-09 21:00 +0200
| From | Chen-Yu Tsai <wens@csie.org> |
|---|---|
| Date | 2016-06-08 09:40 +0200 |
| Subject | [PATCH] ARM: dts: sun8i-h3: sinovoip-bpi-m2-plus: Fix LED and switch labels |
| Message-ID | <rHGfL-5Ap-9@gated-at.bofh.it> |
The switch is clearly labeled "power" on the board.
The LED is red, and is lit by default through an external pull up.
Label it as "pwr" even though there is no explicit marking.
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
Hi Maxime,
This patch fixes 2 copy paste errors in the bpi-m2+ dts that slipped
through. Can you squash it into my original patch?
Thanks
ChenYu
---
arch/arm/boot/dts/sun8i-h3-sinovoip-bpi-m2-plus.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/sun8i-h3-sinovoip-bpi-m2-plus.dts b/arch/arm/boot/dts/sun8i-h3-sinovoip-bpi-m2-plus.dts
index 8a19b4b44f1f..8387c458d615 100644
--- a/arch/arm/boot/dts/sun8i-h3-sinovoip-bpi-m2-plus.dts
+++ b/arch/arm/boot/dts/sun8i-h3-sinovoip-bpi-m2-plus.dts
@@ -67,7 +67,7 @@
pinctrl-0 = <&pwr_led_bpi_m2p>;
pwr_led {
- label = "orangepi:green:pwr";
+ label = "bpi-m2+:red:pwr";
gpios = <&r_pio 0 10 GPIO_ACTIVE_HIGH>; /* PL10 */
default-state = "on";
};
@@ -79,7 +79,7 @@
pinctrl-0 = <&sw_r_bpi_m2p>;
sw4 {
- label = "sw4";
+ label = "power";
linux,code = <BTN_0>;
gpios = <&r_pio 0 3 GPIO_ACTIVE_LOW>;
};
--
2.8.1
[toc] | [next] | [standalone]
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Date | 2016-06-09 21:00 +0200 |
| Subject | Re: [PATCH] ARM: dts: sun8i-h3: sinovoip-bpi-m2-plus: Fix LED and switch labels |
| Message-ID | <rIdlo-1OU-17@gated-at.bofh.it> |
| In reply to | #1416981 |
[Multipart message — attachments visible in raw view] — view raw
On Wed, Jun 08, 2016 at 03:36:26PM +0800, Chen-Yu Tsai wrote: > The switch is clearly labeled "power" on the board. > > The LED is red, and is lit by default through an external pull up. > Label it as "pwr" even though there is no explicit marking. > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > --- > > Hi Maxime, > > This patch fixes 2 copy paste errors in the bpi-m2+ dts that slipped > through. Can you squash it into my original patch? Done, thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web