Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1416932 > unrolled thread

[PATCH 3/3] i2c: octeon: Avoid printk after too long SMBUS message

Started byJan Glauber <jglauber@cavium.com>
First post2016-06-08 09:00 +0200
Last post2016-06-09 22:10 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 3/3] i2c: octeon: Avoid printk after too long SMBUS message Jan Glauber <jglauber@cavium.com> - 2016-06-08 09:00 +0200
    Re: [PATCH 3/3] i2c: octeon: Avoid printk after too long SMBUS  message Wolfram Sang <wsa@the-dreams.de> - 2016-06-09 22:10 +0200

#1416932 — [PATCH 3/3] i2c: octeon: Avoid printk after too long SMBUS message

FromJan Glauber <jglauber@cavium.com>
Date2016-06-08 09:00 +0200
Subject[PATCH 3/3] i2c: octeon: Avoid printk after too long SMBUS message
Message-ID<rHFD3-58f-1@gated-at.bofh.it>
Remove the warning about a too long SMBUS message because
the ipmi_ssif driver triggers this warning too frequently so it
spams the message log.

Signed-off-by: Jan Glauber <jglauber@cavium.com>
---
 drivers/i2c/busses/i2c-octeon.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/i2c/busses/i2c-octeon.c b/drivers/i2c/busses/i2c-octeon.c
index 8ade7fb..83fd6d8 100644
--- a/drivers/i2c/busses/i2c-octeon.c
+++ b/drivers/i2c/busses/i2c-octeon.c
@@ -975,12 +975,8 @@ restart:
 
 		data[i] = octeon_i2c_data_read(i2c);
 		if (recv_len && i == 0) {
-			if (data[i] > I2C_SMBUS_BLOCK_MAX + 1) {
-				dev_err(i2c->dev,
-					"%s: read len > I2C_SMBUS_BLOCK_MAX %d\n",
-					__func__, data[i]);
+			if (data[i] > I2C_SMBUS_BLOCK_MAX + 1)
 				return -EPROTO;
-			}
 			length += data[i];
 		}
 
-- 
2.9.0.rc0.21.g7777322

[toc] | [next] | [standalone]


#1418618 — Re: [PATCH 3/3] i2c: octeon: Avoid printk after too long SMBUS message

FromWolfram Sang <wsa@the-dreams.de>
Date2016-06-09 22:10 +0200
SubjectRe: [PATCH 3/3] i2c: octeon: Avoid printk after too long SMBUS message
Message-ID<rIer7-2Lw-1@gated-at.bofh.it>
In reply to#1416932

[Multipart message — attachments visible in raw view] — view raw

On Wed, Jun 08, 2016 at 08:51:19AM +0200, Jan Glauber wrote:
> Remove the warning about a too long SMBUS message because
> the ipmi_ssif driver triggers this warning too frequently so it
> spams the message log.
> 
> Signed-off-by: Jan Glauber <jglauber@cavium.com>

Applied to for-current, thanks!

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web