Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1416886 > unrolled thread
| Started by | Shrikrishna Khare <skhare@vmware.com> |
|---|---|
| First post | 2016-06-08 08:00 +0200 |
| Last post | 2016-06-08 08:20 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH net] Driver: Vmxnet3: segCnt can be 1 for LRO packets Shrikrishna Khare <skhare@vmware.com> - 2016-06-08 08:00 +0200
Re: [PATCH net] Driver: Vmxnet3: segCnt can be 1 for LRO packets David Miller <davem@davemloft.net> - 2016-06-08 08:00 +0200
Re: [PATCH net] Driver: Vmxnet3: segCnt can be 1 for LRO packets Shrikrishna Khare <skhare@vmware.com> - 2016-06-08 08:20 +0200
| From | Shrikrishna Khare <skhare@vmware.com> |
|---|---|
| Date | 2016-06-08 08:00 +0200 |
| Subject | [PATCH net] Driver: Vmxnet3: segCnt can be 1 for LRO packets |
| Message-ID | <rHEGZ-4r1-1@gated-at.bofh.it> |
The device emulation may send segCnt of 1 for LRO packets. Signed-off-by: Shrikrishna Khare <skhare@vmware.com> Signed-off-by: Jin Heo <heoj@vmware.com> --- drivers/net/vmxnet3/vmxnet3_drv.c | 2 +- drivers/net/vmxnet3/vmxnet3_int.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c index db8022a..6f399b2 100644 --- a/drivers/net/vmxnet3/vmxnet3_drv.c +++ b/drivers/net/vmxnet3/vmxnet3_drv.c @@ -1369,7 +1369,7 @@ vmxnet3_rq_rx_complete(struct vmxnet3_rx_queue *rq, rcdlro = (struct Vmxnet3_RxCompDescExt *)rcd; segCnt = rcdlro->segCnt; - BUG_ON(segCnt <= 1); + BUG_ON(segCnt == 0); mss = rcdlro->mss; if (unlikely(segCnt <= 1)) segCnt = 0; diff --git a/drivers/net/vmxnet3/vmxnet3_int.h b/drivers/net/vmxnet3/vmxnet3_int.h index c482539..3d2b64e 100644 --- a/drivers/net/vmxnet3/vmxnet3_int.h +++ b/drivers/net/vmxnet3/vmxnet3_int.h @@ -69,10 +69,10 @@ /* * Version numbers */ -#define VMXNET3_DRIVER_VERSION_STRING "1.4.7.0-k" +#define VMXNET3_DRIVER_VERSION_STRING "1.4.8.0-k" /* a 32-bit int, each byte encode a verion number in VMXNET3_DRIVER_VERSION */ -#define VMXNET3_DRIVER_VERSION_NUM 0x01040700 +#define VMXNET3_DRIVER_VERSION_NUM 0x01040800 #if defined(CONFIG_PCI_MSI) /* RSS only makes sense if MSI-X is supported. */ -- 2.8.2
[toc] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2016-06-08 08:00 +0200 |
| Message-ID | <rHEGZ-4r1-5@gated-at.bofh.it> |
| In reply to | #1416886 |
From: Shrikrishna Khare <skhare@vmware.com> Date: Tue, 7 Jun 2016 22:55:17 -0700 > The device emulation may send segCnt of 1 for LRO packets. > > Signed-off-by: Shrikrishna Khare <skhare@vmware.com> > Signed-off-by: Jin Heo <heoj@vmware.com> Please do not capitalize subsystem prefixes in your Subject line, and "Driver: " is so generic that it's pointless to use it as a part of the subsystem prefix. Plain "vmxnet3: " is sufficient.
[toc] | [prev] | [next] | [standalone]
| From | Shrikrishna Khare <skhare@vmware.com> |
|---|---|
| Date | 2016-06-08 08:20 +0200 |
| Message-ID | <rHF0l-4MH-1@gated-at.bofh.it> |
| In reply to | #1416888 |
On Tue, 7 Jun 2016, David Miller wrote: > From: Shrikrishna Khare <skhare@vmware.com> > Date: Tue, 7 Jun 2016 22:55:17 -0700 > > > The device emulation may send segCnt of 1 for LRO packets. > > > > Signed-off-by: Shrikrishna Khare <skhare@vmware.com> > > Signed-off-by: Jin Heo <heoj@vmware.com> > > Please do not capitalize subsystem prefixes in your Subject line, > and "Driver: " is so generic that it's pointless to use it as a > part of the subsystem prefix. Plain "vmxnet3: " is sufficient. > Ok. Sent v2 of the patch with the subject line fixed.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web