Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1413958 > unrolled thread

[PATCH v2] fpga: FPGA_MGR_ZYNQ_FPGA should depend on HAS_DMA

Started byGeert Uytterhoeven <geert@linux-m68k.org>
First post2016-06-05 11:50 +0200
Last post2016-06-06 22:40 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH v2] fpga: FPGA_MGR_ZYNQ_FPGA should depend on HAS_DMA Geert Uytterhoeven <geert@linux-m68k.org> - 2016-06-05 11:50 +0200
    Re: [PATCH v2] fpga: FPGA_MGR_ZYNQ_FPGA should depend on HAS_DMA Moritz Fischer <moritz.fischer@ettus.com> - 2016-06-06 22:40 +0200

#1413958 — [PATCH v2] fpga: FPGA_MGR_ZYNQ_FPGA should depend on HAS_DMA

FromGeert Uytterhoeven <geert@linux-m68k.org>
Date2016-06-05 11:50 +0200
Subject[PATCH v2] fpga: FPGA_MGR_ZYNQ_FPGA should depend on HAS_DMA
Message-ID<rGCQV-528-3@gated-at.bofh.it>
If NO_DMA=y:

    ERROR: "bad_dma_ops" [drivers/fpga/zynq-fpga.ko] undefined!

Add a dependency on HAS_DMA to fix this.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Reviewed-by: Moritz Fischer <moritz.fischer@ettus.com>
---
v2:
  - Add Reviewed-by,
  - Updated error message for recent kernels,
  - Submit to Greg, as requested by Alan.
---
 drivers/fpga/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
index c9b9fdf6cfbbeb6d..d61410299ec0cf80 100644
--- a/drivers/fpga/Kconfig
+++ b/drivers/fpga/Kconfig
@@ -21,6 +21,7 @@ config FPGA_MGR_SOCFPGA
 
 config FPGA_MGR_ZYNQ_FPGA
 	tristate "Xilinx Zynq FPGA"
+	depends on HAS_DMA
 	help
 	  FPGA manager driver support for Xilinx Zynq FPGAs.
 
-- 
1.9.1

[toc] | [next] | [standalone]


#1415428

FromMoritz Fischer <moritz.fischer@ettus.com>
Date2016-06-06 22:40 +0200
Message-ID<rH9tw-1g5-9@gated-at.bofh.it>
In reply to#1413958
Hi Alan, Geert

On Mon, Jun 6, 2016 at 11:02 AM, atull <atull@opensource.altera.com> wrote:
> On Sun, 5 Jun 2016, Geert Uytterhoeven wrote:
>
>> If NO_DMA=y:
>>
>>     ERROR: "bad_dma_ops" [drivers/fpga/zynq-fpga.ko] undefined!
>>
>> Add a dependency on HAS_DMA to fix this.
>>
>> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>> Reviewed-by: Moritz Fischer <moritz.fischer@ettus.com>
>> ---
>> v2:
>>   - Add Reviewed-by,
>>   - Updated error message for recent kernels,
>>   - Submit to Greg, as requested by Alan.
>
> Hi Geert,
>
> Thank you!

We should probably pick this one over Sudip's duplicate?

Cheers,

Moritz

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web