Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1414138 > unrolled thread
| Started by | Sudip Mukherjee <sudipm.mukherjee@gmail.com> |
|---|---|
| First post | 2016-06-05 20:10 +0200 |
| Last post | 2016-06-06 23:00 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] ASoC: atmel: fix build failure Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-06-05 20:10 +0200
Re: [PATCH] ASoC: atmel: fix build failure Mark Brown <broonie@kernel.org> - 2016-06-06 12:30 +0200
Re: [PATCH] ASoC: atmel: fix build failure Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-06-06 23:00 +0200
| From | Sudip Mukherjee <sudipm.mukherjee@gmail.com> |
|---|---|
| Date | 2016-06-05 20:10 +0200 |
| Subject | [PATCH] ASoC: atmel: fix build failure |
| Message-ID | <rGKEO-1JA-9@gated-at.bofh.it> |
m32r allmodconfig build is failing with the error: ERROR: "bad_dma_ops" [sound/soc/atmel/snd-soc-atmel-pcm-pdc.ko] undefined! The code is using DMA but the related dependency is not mentioned in the Kconfig. Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> --- build log is at: https://travis-ci.org/sudipm-mukherjee/parport/jobs/134651165 sound/soc/atmel/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig index 06e099e..22aec9a 100644 --- a/sound/soc/atmel/Kconfig +++ b/sound/soc/atmel/Kconfig @@ -10,6 +10,7 @@ if SND_ATMEL_SOC config SND_ATMEL_SOC_PDC tristate + depends on HAS_DMA default m if SND_ATMEL_SOC_SSC_PDC=m && SND_ATMEL_SOC_SSC=m default y if SND_ATMEL_SOC_SSC_PDC=y || (SND_ATMEL_SOC_SSC_PDC=m && SND_ATMEL_SOC_SSC=y) -- 1.9.1
[toc] | [next] | [standalone]
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Date | 2016-06-06 12:30 +0200 |
| Message-ID | <rGZXb-3zz-5@gated-at.bofh.it> |
| In reply to | #1414138 |
[Multipart message — attachments visible in raw view] — view raw
On Sun, Jun 05, 2016 at 07:00:21PM +0100, Sudip Mukherjee wrote: > m32r allmodconfig build is failing with the error: > ERROR: "bad_dma_ops" [sound/soc/atmel/snd-soc-atmel-pcm-pdc.ko] undefined! > > The code is using DMA but the related dependency is not mentioned in the > Kconfig. Rather than going through every single driver using DMA adding the dependency might it not be simpler to provide at least a stub DMA implementation for the architectures that don't have it?
[toc] | [prev] | [next] | [standalone]
| From | Sudip Mukherjee <sudipm.mukherjee@gmail.com> |
|---|---|
| Date | 2016-06-06 23:00 +0200 |
| Message-ID | <rH9MS-1mM-13@gated-at.bofh.it> |
| In reply to | #1414871 |
On Monday 06 June 2016 11:17 AM, Mark Brown wrote: > On Sun, Jun 05, 2016 at 07:00:21PM +0100, Sudip Mukherjee wrote: >> m32r allmodconfig build is failing with the error: >> ERROR: "bad_dma_ops" [sound/soc/atmel/snd-soc-atmel-pcm-pdc.ko] undefined! >> >> The code is using DMA but the related dependency is not mentioned in the >> Kconfig. > > Rather than going through every single driver using DMA adding the > dependency might it not be simpler to provide at least a stub DMA > implementation for the architectures that don't have it? > Yes, i can add them for m32r. but since m32r is orphan i send all m32r patches to Andrew. So, Andrew, do you have any objection to it? Regards Sudip
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web