Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1414879 > unrolled thread

[PATCH 0/7] dts: sunxi: Add sunxi NAND Flash Controller support

Started byAleksei Mamlin <mamlinav@gmail.com>
First post2016-06-06 12:30 +0200
Last post2016-06-06 21:00 +0200
Articles 10 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/7] dts: sunxi: Add sunxi NAND Flash Controller support Aleksei Mamlin <mamlinav@gmail.com> - 2016-06-06 12:30 +0200
    [PATCH 5/7] mtd: nand: Add Hynix H27UBG8T2BTR-BC to nand_ids table Aleksei Mamlin <mamlinav@gmail.com> - 2016-06-06 12:30 +0200
      Re: [PATCH 5/7] mtd: nand: Add Hynix H27UBG8T2BTR-BC to nand_ids  table Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-06-06 21:00 +0200
        Re: [PATCH 5/7] mtd: nand: Add Hynix H27UBG8T2BTR-BC to nand_ids  table Aleksei Mamlin <mamlinav@gmail.com> - 2016-06-06 22:00 +0200
          Re: [PATCH 5/7] mtd: nand: Add Hynix H27UBG8T2BTR-BC to nand_ids  table Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-06-06 22:40 +0200
            Re: [PATCH 5/7] mtd: nand: Add Hynix H27UBG8T2BTR-BC to nand_ids  table Aleksei Mamlin <mamlinav@gmail.com> - 2016-06-06 23:10 +0200
              Re: [PATCH 5/7] mtd: nand: Add Hynix H27UBG8T2BTR-BC to nand_ids  table Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-06-07 07:50 +0200
            Re: [PATCH 5/7] mtd: nand: Add Hynix H27UBG8T2BTR-BC to nand_ids  table Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-06-07 08:00 +0200
    [PATCH 6/7] ARM: dts: sun4i: Enable NAND on Marsboard A10 Aleksei Mamlin <mamlinav@gmail.com> - 2016-06-06 12:30 +0200
      Re: [PATCH 6/7] ARM: dts: sun4i: Enable NAND on Marsboard A10 Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-06-06 21:00 +0200

#1414879 — [PATCH 0/7] dts: sunxi: Add sunxi NAND Flash Controller support

FromAleksei Mamlin <mamlinav@gmail.com>
Date2016-06-06 12:30 +0200
Subject[PATCH 0/7] dts: sunxi: Add sunxi NAND Flash Controller support
Message-ID<rGZXb-3zz-3@gated-at.bofh.it>
Hello,

This series adds the sunxi NAND Flash Controller nodes to dts.

The first 4 patches is Boris Brezillon's patches with dtsi changes.
The second 1 patch adds Hynix H27UBG8T2BTR-BC NAND chip definition.
The last 2 patches enables NAND on Marsboard A10 board and Wexler TAB7200
tablet.

Aleksei Mamlin (3):
  mtd: nand: Add Hynix H27UBG8T2BTR-BC to nand_ids table
  ARM: dts: sun4i: Enable NAND on Marsboard A10
  ARM: dts: sun7i: Enable NAND on Wexler TAB7200

Boris Brezillon (4):
  ARM: dts: sun4i: Add A10 NAND controller pin definitions
  ARM: dts: sun4i: Add NFC node to Allwinner A10 SoC
  ARM: dts: sun7i: Add A20 NAND controller pin definitions
  ARM: dts: sun7i: Add NFC node to Allwinner A20 SoC

 arch/arm/boot/dts/sun4i-a10-marsboard.dts      | 41 ++++++++++++
 arch/arm/boot/dts/sun4i-a10.dtsi               | 91 ++++++++++++++++++++++++++
 arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts | 41 ++++++++++++
 arch/arm/boot/dts/sun7i-a20.dtsi               | 91 ++++++++++++++++++++++++++
 drivers/mtd/nand/nand_ids.c                    |  4 ++
 5 files changed, 268 insertions(+)

-- 
2.7.3

[toc] | [next] | [standalone]

#1414881 — [PATCH 5/7] mtd: nand: Add Hynix H27UBG8T2BTR-BC to nand_ids table

FromAleksei Mamlin <mamlinav@gmail.com>
Date2016-06-06 12:30 +0200
Subject[PATCH 5/7] mtd: nand: Add Hynix H27UBG8T2BTR-BC to nand_ids table
Message-ID<rGZXc-3zz-33@gated-at.bofh.it>
In reply to#1414879
Add the full description of the Hynix H27UBG8T2BTR-BC NAND chip in the
nand_ids table so that we can later use the NAND ECC infos and ONFI timings
mode in controller drivers.

Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>
---
 drivers/mtd/nand/nand_ids.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/mtd/nand/nand_ids.c b/drivers/mtd/nand/nand_ids.c
index ccc05f5..ccdc773 100644
--- a/drivers/mtd/nand/nand_ids.c
+++ b/drivers/mtd/nand/nand_ids.c
@@ -52,6 +52,10 @@ struct nand_flash_dev nand_flash_ids[] = {
 		{ .id = {0xad, 0xde, 0x94, 0xda, 0x74, 0xc4} },
 		  SZ_8K, SZ_8K, SZ_2M, NAND_NEED_SCRAMBLING, 6, 640,
 		  NAND_ECC_INFO(40, SZ_1K), 4 },
+	{"H27UBG8T2BTR-BC 32G 3.3V 8-bit",
+		{ .id = {0xad, 0xd7, 0x94, 0xda, 0x74, 0xc3} },
+		  SZ_8K, SZ_4K, SZ_2M, NAND_NEED_SCRAMBLING, 6, 640,
+		  NAND_ECC_INFO(40, SZ_1K), 0 },
 
 	LEGACY_ID_NAND("NAND 4MiB 5V 8-bit",   0x6B, 4, SZ_8K, SP_OPTIONS),
 	LEGACY_ID_NAND("NAND 4MiB 3,3V 8-bit", 0xE3, 4, SZ_8K, SP_OPTIONS),
-- 
2.7.3

[toc] | [prev] | [next] | [standalone]

#1415379 — Re: [PATCH 5/7] mtd: nand: Add Hynix H27UBG8T2BTR-BC to nand_ids table

FromBoris Brezillon <boris.brezillon@free-electrons.com>
Date2016-06-06 21:00 +0200
SubjectRe: [PATCH 5/7] mtd: nand: Add Hynix H27UBG8T2BTR-BC to nand_ids table
Message-ID<rH7UL-da-33@gated-at.bofh.it>
In reply to#1414881
On Mon,  6 Jun 2016 13:24:22 +0300
Aleksei Mamlin <mamlinav@gmail.com> wrote:

> Add the full description of the Hynix H27UBG8T2BTR-BC NAND chip in the
> nand_ids table so that we can later use the NAND ECC infos and ONFI timings
> mode in controller drivers.

Still hoping to get this series [1] merged in 4.8, but if that's
not the case, I'll apply your patch.

BTW, that would be great if you could test it on your platforms.

Regards,

Boris

[1]https://lkml.org/lkml/2016/5/27/264

> 
> Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>
> ---
>  drivers/mtd/nand/nand_ids.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/mtd/nand/nand_ids.c b/drivers/mtd/nand/nand_ids.c
> index ccc05f5..ccdc773 100644
> --- a/drivers/mtd/nand/nand_ids.c
> +++ b/drivers/mtd/nand/nand_ids.c
> @@ -52,6 +52,10 @@ struct nand_flash_dev nand_flash_ids[] = {
>  		{ .id = {0xad, 0xde, 0x94, 0xda, 0x74, 0xc4} },
>  		  SZ_8K, SZ_8K, SZ_2M, NAND_NEED_SCRAMBLING, 6, 640,
>  		  NAND_ECC_INFO(40, SZ_1K), 4 },
> +	{"H27UBG8T2BTR-BC 32G 3.3V 8-bit",
> +		{ .id = {0xad, 0xd7, 0x94, 0xda, 0x74, 0xc3} },
> +		  SZ_8K, SZ_4K, SZ_2M, NAND_NEED_SCRAMBLING, 6, 640,
> +		  NAND_ECC_INFO(40, SZ_1K), 0 },
>  
>  	LEGACY_ID_NAND("NAND 4MiB 5V 8-bit",   0x6B, 4, SZ_8K, SP_OPTIONS),
>  	LEGACY_ID_NAND("NAND 4MiB 3,3V 8-bit", 0xE3, 4, SZ_8K, SP_OPTIONS),



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [next] | [standalone]

#1415393 — Re: [PATCH 5/7] mtd: nand: Add Hynix H27UBG8T2BTR-BC to nand_ids table

FromAleksei Mamlin <mamlinav@gmail.com>
Date2016-06-06 22:00 +0200
SubjectRe: [PATCH 5/7] mtd: nand: Add Hynix H27UBG8T2BTR-BC to nand_ids table
Message-ID<rH8QO-Oc-5@gated-at.bofh.it>
In reply to#1415379
On Mon, 6 Jun 2016 20:55:49 +0200
Boris Brezillon <boris.brezillon@free-electrons.com> wrote:

> On Mon,  6 Jun 2016 13:24:22 +0300
> Aleksei Mamlin <mamlinav@gmail.com> wrote:
> 
> > Add the full description of the Hynix H27UBG8T2BTR-BC NAND chip in the
> > nand_ids table so that we can later use the NAND ECC infos and ONFI timings
> > mode in controller drivers.
> 
> Still hoping to get this series [1] merged in 4.8, but if that's
> not the case, I'll apply your patch.
> 
> BTW, that would be great if you could test it on your platforms.
> 

It seems that Hynix-specific initialization code can't handle H27UBG8T2BTR-BC
chip:

[    0.886153] nand: Could not find valid ONFI parameter page; aborting
[    0.892665] nand: device found, Manufacturer ID: 0xad, Chip ID: 0xd7
[    0.899025] nand: Hynix 1c03000.nand
[    0.902596] nand: bus width 8 instead 16 bit
[    0.906858] nand: No NAND device found
[    0.910620] sunxi_nand 1c03000.nand: failed to init nand chips
[    0.916528] sunxi_nand: probe of 1c03000.nand failed with error -22

> 
> Regards,
> 
> Boris
> 
> [1]https://lkml.org/lkml/2016/5/27/264
> 
> > 
> > Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>
> > ---
> >  drivers/mtd/nand/nand_ids.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/drivers/mtd/nand/nand_ids.c b/drivers/mtd/nand/nand_ids.c
> > index ccc05f5..ccdc773 100644
> > --- a/drivers/mtd/nand/nand_ids.c
> > +++ b/drivers/mtd/nand/nand_ids.c
> > @@ -52,6 +52,10 @@ struct nand_flash_dev nand_flash_ids[] = {
> >  		{ .id = {0xad, 0xde, 0x94, 0xda, 0x74, 0xc4} },
> >  		  SZ_8K, SZ_8K, SZ_2M, NAND_NEED_SCRAMBLING, 6, 640,
> >  		  NAND_ECC_INFO(40, SZ_1K), 4 },
> > +	{"H27UBG8T2BTR-BC 32G 3.3V 8-bit",
> > +		{ .id = {0xad, 0xd7, 0x94, 0xda, 0x74, 0xc3} },
> > +		  SZ_8K, SZ_4K, SZ_2M, NAND_NEED_SCRAMBLING, 6, 640,
> > +		  NAND_ECC_INFO(40, SZ_1K), 0 },
> >  
> >  	LEGACY_ID_NAND("NAND 4MiB 5V 8-bit",   0x6B, 4, SZ_8K, SP_OPTIONS),
> >  	LEGACY_ID_NAND("NAND 4MiB 3,3V 8-bit", 0xE3, 4, SZ_8K, SP_OPTIONS),
> 
> 
> 
> -- 
> Boris Brezillon, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com


-- 
Thanks and regards,
Aleksei Mamlin

[toc] | [prev] | [next] | [standalone]

#1415425 — Re: [PATCH 5/7] mtd: nand: Add Hynix H27UBG8T2BTR-BC to nand_ids table

FromBoris Brezillon <boris.brezillon@free-electrons.com>
Date2016-06-06 22:40 +0200
SubjectRe: [PATCH 5/7] mtd: nand: Add Hynix H27UBG8T2BTR-BC to nand_ids table
Message-ID<rH9tv-1g5-5@gated-at.bofh.it>
In reply to#1415393
On Mon, 6 Jun 2016 22:59:03 +0300
Aleksei Mamlin <mamlinav@gmail.com> wrote:

> On Mon, 6 Jun 2016 20:55:49 +0200
> Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
> 
> > On Mon,  6 Jun 2016 13:24:22 +0300
> > Aleksei Mamlin <mamlinav@gmail.com> wrote:
> >   
> > > Add the full description of the Hynix H27UBG8T2BTR-BC NAND chip in the
> > > nand_ids table so that we can later use the NAND ECC infos and ONFI timings
> > > mode in controller drivers.  
> > 
> > Still hoping to get this series [1] merged in 4.8, but if that's
> > not the case, I'll apply your patch.
> > 
> > BTW, that would be great if you could test it on your platforms.
> >   
> 
> It seems that Hynix-specific initialization code can't handle H27UBG8T2BTR-BC
> chip:
> 
> [    0.886153] nand: Could not find valid ONFI parameter page; aborting
> [    0.892665] nand: device found, Manufacturer ID: 0xad, Chip ID: 0xd7
> [    0.899025] nand: Hynix 1c03000.nand
> [    0.902596] nand: bus width 8 instead 16 bit
> [    0.906858] nand: No NAND device found
> [    0.910620] sunxi_nand 1c03000.nand: failed to init nand chips
> [    0.916528] sunxi_nand: probe of 1c03000.nand failed with error -22

Can you try this patch? It should fix the problem [1].

[1]http://code.bulix.org/6hjww1-100494


-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [next] | [standalone]

#1415454 — Re: [PATCH 5/7] mtd: nand: Add Hynix H27UBG8T2BTR-BC to nand_ids table

FromAleksei Mamlin <mamlinav@gmail.com>
Date2016-06-06 23:10 +0200
SubjectRe: [PATCH 5/7] mtd: nand: Add Hynix H27UBG8T2BTR-BC to nand_ids table
Message-ID<rH9Wz-1Fh-43@gated-at.bofh.it>
In reply to#1415425
On Mon, 6 Jun 2016 22:31:38 +0200
Boris Brezillon <boris.brezillon@free-electrons.com> wrote:

> On Mon, 6 Jun 2016 22:59:03 +0300
> Aleksei Mamlin <mamlinav@gmail.com> wrote:
> 
> > On Mon, 6 Jun 2016 20:55:49 +0200
> > Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
> > 
> > > On Mon,  6 Jun 2016 13:24:22 +0300
> > > Aleksei Mamlin <mamlinav@gmail.com> wrote:
> > >   
> > > > Add the full description of the Hynix H27UBG8T2BTR-BC NAND chip in the
> > > > nand_ids table so that we can later use the NAND ECC infos and ONFI timings
> > > > mode in controller drivers.  
> > > 
> > > Still hoping to get this series [1] merged in 4.8, but if that's
> > > not the case, I'll apply your patch.
> > > 
> > > BTW, that would be great if you could test it on your platforms.
> > >   
> > 
> > It seems that Hynix-specific initialization code can't handle H27UBG8T2BTR-BC
> > chip:
> > 
> > [    0.886153] nand: Could not find valid ONFI parameter page; aborting
> > [    0.892665] nand: device found, Manufacturer ID: 0xad, Chip ID: 0xd7
> > [    0.899025] nand: Hynix 1c03000.nand
> > [    0.902596] nand: bus width 8 instead 16 bit
> > [    0.906858] nand: No NAND device found
> > [    0.910620] sunxi_nand 1c03000.nand: failed to init nand chips
> > [    0.916528] sunxi_nand: probe of 1c03000.nand failed with error -22
> 
> Can you try this patch? It should fix the problem [1].
> 
> [1]http://code.bulix.org/6hjww1-100494
> 

Yes, it fixes problem. What about ONFI parameter page? Should it be ignored?
[    0.886068] nand: Could not find valid ONFI parameter page; aborting
[    0.892571] nand: device found, Manufacturer ID: 0xad, Chip ID: 0xd7
[    0.898917] nand: Hynix NAND 4GiB 3,3V 8-bit
[    0.903198] nand: 4096 MiB, MLC, erase size: 2048 KiB, page size: 8192, OOB size: 640
[    0.911908] Bad block table found at page 524032, version 0x01
[    0.918534] Bad block table found at page 523776, version 0x01
[    0.972112] 5 ofpart partitions found on MTD device 1c03000.nand
[    0.978116] Creating 5 MTD partitions on "1c03000.nand":
[    0.983477] 0x000000000000-0x000000200000 : "boot0"
[    0.988803] 0x000000200000-0x000000400000 : "boot0-rescue"
[    0.994692] 0x000000400000-0x000000600000 : "uboot"
[    0.999944] 0x000000600000-0x000000800000 : "uboot-rescue"
[    1.005763] 0x000000800000-0x000100000000 : "main"

> 
> -- 
> Boris Brezillon, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com


-- 
Thanks and regards,
Aleksei Mamlin

[toc] | [prev] | [next] | [standalone]

#1415713 — Re: [PATCH 5/7] mtd: nand: Add Hynix H27UBG8T2BTR-BC to nand_ids table

FromBoris Brezillon <boris.brezillon@free-electrons.com>
Date2016-06-07 07:50 +0200
SubjectRe: [PATCH 5/7] mtd: nand: Add Hynix H27UBG8T2BTR-BC to nand_ids table
Message-ID<rHi3L-70i-1@gated-at.bofh.it>
In reply to#1415454
On Tue, 7 Jun 2016 00:06:45 +0300
Aleksei Mamlin <mamlinav@gmail.com> wrote:

> On Mon, 6 Jun 2016 22:31:38 +0200
> Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
> 
> > On Mon, 6 Jun 2016 22:59:03 +0300
> > Aleksei Mamlin <mamlinav@gmail.com> wrote:
> >   
> > > On Mon, 6 Jun 2016 20:55:49 +0200
> > > Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
> > >   
> > > > On Mon,  6 Jun 2016 13:24:22 +0300
> > > > Aleksei Mamlin <mamlinav@gmail.com> wrote:
> > > >     
> > > > > Add the full description of the Hynix H27UBG8T2BTR-BC NAND chip in the
> > > > > nand_ids table so that we can later use the NAND ECC infos and ONFI timings
> > > > > mode in controller drivers.    
> > > > 
> > > > Still hoping to get this series [1] merged in 4.8, but if that's
> > > > not the case, I'll apply your patch.
> > > > 
> > > > BTW, that would be great if you could test it on your platforms.
> > > >     
> > > 
> > > It seems that Hynix-specific initialization code can't handle H27UBG8T2BTR-BC
> > > chip:
> > > 
> > > [    0.886153] nand: Could not find valid ONFI parameter page; aborting
> > > [    0.892665] nand: device found, Manufacturer ID: 0xad, Chip ID: 0xd7
> > > [    0.899025] nand: Hynix 1c03000.nand
> > > [    0.902596] nand: bus width 8 instead 16 bit
> > > [    0.906858] nand: No NAND device found
> > > [    0.910620] sunxi_nand 1c03000.nand: failed to init nand chips
> > > [    0.916528] sunxi_nand: probe of 1c03000.nand failed with error -22  
> > 
> > Can you try this patch? It should fix the problem [1].
> > 
> > [1]http://code.bulix.org/6hjww1-100494
> >   
> 
> Yes, it fixes problem. What about ONFI parameter page? Should it be ignored?

It should be ignored: your NAND is not 'ONFI compatible', the datasheet
just says that it supports the' ONFI command set', which is not the
same :).
The trace you're seeing here is just notifying that the core failed to
detect an ONFI NAND, which is expected in your case.

> [    0.886068] nand: Could not find valid ONFI parameter page; aborting
> [    0.892571] nand: device found, Manufacturer ID: 0xad, Chip ID: 0xd7
> [    0.898917] nand: Hynix NAND 4GiB 3,3V 8-bit
> [    0.903198] nand: 4096 MiB, MLC, erase size: 2048 KiB, page size: 8192, OOB size: 640
> [    0.911908] Bad block table found at page 524032, version 0x01
> [    0.918534] Bad block table found at page 523776, version 0x01
> [    0.972112] 5 ofpart partitions found on MTD device 1c03000.nand
> [    0.978116] Creating 5 MTD partitions on "1c03000.nand":
> [    0.983477] 0x000000000000-0x000000200000 : "boot0"
> [    0.988803] 0x000000200000-0x000000400000 : "boot0-rescue"
> [    0.994692] 0x000000400000-0x000000600000 : "uboot"
> [    0.999944] 0x000000600000-0x000000800000 : "uboot-rescue"
> [    1.005763] 0x000000800000-0x000100000000 : "main"
> 
> > 
> > -- 
> > Boris Brezillon, Free Electrons
> > Embedded Linux and Kernel engineering
> > http://free-electrons.com  
> 
> 



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [next] | [standalone]

#1415721 — Re: [PATCH 5/7] mtd: nand: Add Hynix H27UBG8T2BTR-BC to nand_ids table

FromBoris Brezillon <boris.brezillon@free-electrons.com>
Date2016-06-07 08:00 +0200
SubjectRe: [PATCH 5/7] mtd: nand: Add Hynix H27UBG8T2BTR-BC to nand_ids table
Message-ID<rHidt-73B-25@gated-at.bofh.it>
In reply to#1415425
On Mon, 6 Jun 2016 22:31:38 +0200
Boris Brezillon <boris.brezillon@free-electrons.com> wrote:

> On Mon, 6 Jun 2016 22:59:03 +0300
> Aleksei Mamlin <mamlinav@gmail.com> wrote:
> 
> > On Mon, 6 Jun 2016 20:55:49 +0200
> > Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
> >   
> > > On Mon,  6 Jun 2016 13:24:22 +0300
> > > Aleksei Mamlin <mamlinav@gmail.com> wrote:
> > >     
> > > > Add the full description of the Hynix H27UBG8T2BTR-BC NAND chip in the
> > > > nand_ids table so that we can later use the NAND ECC infos and ONFI timings
> > > > mode in controller drivers.    
> > > 
> > > Still hoping to get this series [1] merged in 4.8, but if that's
> > > not the case, I'll apply your patch.
> > > 
> > > BTW, that would be great if you could test it on your platforms.
> > >     
> > 
> > It seems that Hynix-specific initialization code can't handle H27UBG8T2BTR-BC
> > chip:
> > 
> > [    0.886153] nand: Could not find valid ONFI parameter page; aborting
> > [    0.892665] nand: device found, Manufacturer ID: 0xad, Chip ID: 0xd7
> > [    0.899025] nand: Hynix 1c03000.nand
> > [    0.902596] nand: bus width 8 instead 16 bit
> > [    0.906858] nand: No NAND device found
> > [    0.910620] sunxi_nand 1c03000.nand: failed to init nand chips
> > [    0.916528] sunxi_nand: probe of 1c03000.nand failed with error -22  
> 
> Can you try this patch? It should fix the problem [1].

Brian, I have a question regarding the extended NAND ids (not full-ids)
defined in the nand_ids table. Are they really valid for all vendors?

If that's the case, why are we extracting the bus width from the id[3]
since we already have this information in the options field?

> 
> [1]http://code.bulix.org/6hjww1-100494
> 
> 



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [next] | [standalone]

#1414882 — [PATCH 6/7] ARM: dts: sun4i: Enable NAND on Marsboard A10

FromAleksei Mamlin <mamlinav@gmail.com>
Date2016-06-06 12:30 +0200
Subject[PATCH 6/7] ARM: dts: sun4i: Enable NAND on Marsboard A10
Message-ID<rGZXc-3zz-35@gated-at.bofh.it>
In reply to#1414879
Enable the NFC and describe the NAND flash connected to this controller.

Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>
---
 arch/arm/boot/dts/sun4i-a10-marsboard.dts | 41 +++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/arch/arm/boot/dts/sun4i-a10-marsboard.dts b/arch/arm/boot/dts/sun4i-a10-marsboard.dts
index 8e50723..ea6e2d5 100644
--- a/arch/arm/boot/dts/sun4i-a10-marsboard.dts
+++ b/arch/arm/boot/dts/sun4i-a10-marsboard.dts
@@ -150,6 +150,47 @@
 	status = "okay";
 };
 
+&nfc {
+	pinctrl-names = "default";
+	pinctrl-0 = <&nand_pins_a>, <&nand_cs0_pins_a>, <&nand_rb0_pins_a>;
+	status = "okay";
+
+	nand@0 {
+		#address-cells = <2>;
+		#size-cells = <2>;
+		reg = <0>;
+		allwinner,rb = <0>;
+
+		nand-ecc-mode = "hw";
+		nand-on-flash-bbt;
+
+		boot0@0 {
+			label = "boot0";
+			reg = /bits/ 64 <0x0 0x200000>;
+		};
+
+		boot0-rescue@200000 {
+			label = "boot0-rescue";
+			reg = /bits/ 64 <0x200000 0x200000>;
+		};
+
+		uboot@400000 {
+			label = "uboot";
+			reg = /bits/ 64 <0x400000 0x200000>;
+		};
+
+		uboot-rescue@600000 {
+			label = "uboot-rescue";
+			reg = /bits/ 64 <0x600000 0x200000>;
+		};
+
+		main@800000 {
+			label = "main";
+			reg = /bits/ 64 <0x800000 0xff800000>;
+		};
+	};
+};
+
 &ohci0 {
 	status = "okay";
 };
-- 
2.7.3

[toc] | [prev] | [next] | [standalone]

#1415370 — Re: [PATCH 6/7] ARM: dts: sun4i: Enable NAND on Marsboard A10

FromBoris Brezillon <boris.brezillon@free-electrons.com>
Date2016-06-06 21:00 +0200
SubjectRe: [PATCH 6/7] ARM: dts: sun4i: Enable NAND on Marsboard A10
Message-ID<rH7UJ-da-1@gated-at.bofh.it>
In reply to#1414882
On Mon,  6 Jun 2016 13:24:23 +0300
Aleksei Mamlin <mamlinav@gmail.com> wrote:

> Enable the NFC and describe the NAND flash connected to this controller.
> 
> Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>

Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>

> ---
>  arch/arm/boot/dts/sun4i-a10-marsboard.dts | 41 +++++++++++++++++++++++++++++++
>  1 file changed, 41 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun4i-a10-marsboard.dts b/arch/arm/boot/dts/sun4i-a10-marsboard.dts
> index 8e50723..ea6e2d5 100644
> --- a/arch/arm/boot/dts/sun4i-a10-marsboard.dts
> +++ b/arch/arm/boot/dts/sun4i-a10-marsboard.dts
> @@ -150,6 +150,47 @@
>  	status = "okay";
>  };
>  
> +&nfc {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&nand_pins_a>, <&nand_cs0_pins_a>, <&nand_rb0_pins_a>;
> +	status = "okay";
> +
> +	nand@0 {
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		reg = <0>;
> +		allwinner,rb = <0>;
> +
> +		nand-ecc-mode = "hw";
> +		nand-on-flash-bbt;
> +
> +		boot0@0 {
> +			label = "boot0";
> +			reg = /bits/ 64 <0x0 0x200000>;
> +		};
> +
> +		boot0-rescue@200000 {
> +			label = "boot0-rescue";
> +			reg = /bits/ 64 <0x200000 0x200000>;
> +		};
> +
> +		uboot@400000 {
> +			label = "uboot";
> +			reg = /bits/ 64 <0x400000 0x200000>;
> +		};
> +
> +		uboot-rescue@600000 {
> +			label = "uboot-rescue";
> +			reg = /bits/ 64 <0x600000 0x200000>;
> +		};
> +
> +		main@800000 {
> +			label = "main";
> +			reg = /bits/ 64 <0x800000 0xff800000>;
> +		};
> +	};
> +};
> +
>  &ohci0 {
>  	status = "okay";
>  };



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web