Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1411164 > unrolled thread

Re: [PATCH] spinlock: Get rid of spin_can_lock()

Started byPeter Zijlstra <peterz@infradead.org>
First post2016-06-01 14:50 +0200
Last post2016-06-06 19:30 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] spinlock: Get rid of spin_can_lock() Peter Zijlstra <peterz@infradead.org> - 2016-06-01 14:50 +0200
    Re: [PATCH] spinlock: Get rid of spin_can_lock() Davidlohr Bueso <dave@stgolabs.net> - 2016-06-06 19:30 +0200

#1411164 — Re: [PATCH] spinlock: Get rid of spin_can_lock()

FromPeter Zijlstra <peterz@infradead.org>
Date2016-06-01 14:50 +0200
SubjectRe: [PATCH] spinlock: Get rid of spin_can_lock()
Message-ID<rFdKW-8sS-1@gated-at.bofh.it>
On Mon, May 23, 2016 at 06:54:02AM -0700, Davidlohr Bueso wrote:
> ... it has no users and we already have the the regular spin_is_lock()
> call anyway -- although iirc this was going to be different
> than the simple negation for lock elision implementations. Lets drop it.

What about {read,write}_can_lock() ? those look equally unused and
borken.

[toc] | [next] | [standalone]


#1415307

FromDavidlohr Bueso <dave@stgolabs.net>
Date2016-06-06 19:30 +0200
Message-ID<rH6vD-7U4-9@gated-at.bofh.it>
In reply to#1411164
On Wed, 01 Jun 2016, Peter Zijlstra wrote:

>On Mon, May 23, 2016 at 06:54:02AM -0700, Davidlohr Bueso wrote:
>> ... it has no users and we already have the the regular spin_is_lock()
>> call anyway -- although iirc this was going to be different
>> than the simple negation for lock elision implementations. Lets drop it.
>
>What about {read,write}_can_lock() ? those look equally unused and
>borken.

Hmm so the break_lock thingie for archs that don't have ticket locks (or
queued obviously) want to use these, mainly for is_contended() usage afaict.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web