Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1415006 > unrolled thread

[PATCH] gtp: #define _UAPI_LINUX_GTP_H_ and not _UAPI_LINUX_GTP_H__

Started byColin King <colin.king@canonical.com>
First post2016-06-06 15:00 +0200
Last post2016-06-06 17:00 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] gtp: #define _UAPI_LINUX_GTP_H_ and not _UAPI_LINUX_GTP_H__ Colin King <colin.king@canonical.com> - 2016-06-06 15:00 +0200
    Re: [PATCH] gtp: #define _UAPI_LINUX_GTP_H_ and not  _UAPI_LINUX_GTP_H__ Pablo Neira Ayuso <pablo@netfilter.org> - 2016-06-06 17:00 +0200

#1415006 — [PATCH] gtp: #define _UAPI_LINUX_GTP_H_ and not _UAPI_LINUX_GTP_H__

FromColin King <colin.king@canonical.com>
Date2016-06-06 15:00 +0200
Subject[PATCH] gtp: #define _UAPI_LINUX_GTP_H_ and not _UAPI_LINUX_GTP_H__
Message-ID<rH2iq-53K-9@gated-at.bofh.it>
From: Colin Ian King <colin.king@canonical.com>

Fix clang build warning:

./include/uapi/linux/gtp.h:1:9: warning: '_UAPI_LINUX_GTP_H_' is
used as a header guard here, followed by #define of a different
macro [-Wheader-guard]

fix by defining  _UAPI_LINUX_GTP_H_ and not _UAPI_LINUX_GTP_H__

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 include/uapi/linux/gtp.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/uapi/linux/gtp.h b/include/uapi/linux/gtp.h
index ca1054d..72a04a0 100644
--- a/include/uapi/linux/gtp.h
+++ b/include/uapi/linux/gtp.h
@@ -1,5 +1,5 @@
 #ifndef _UAPI_LINUX_GTP_H_
-#define _UAPI_LINUX_GTP_H__
+#define _UAPI_LINUX_GTP_H_
 
 enum gtp_genl_cmds {
 	GTP_CMD_NEWPDP,
-- 
2.8.1

[toc] | [next] | [standalone]


#1415185 — Re: [PATCH] gtp: #define _UAPI_LINUX_GTP_H_ and not _UAPI_LINUX_GTP_H__

FromPablo Neira Ayuso <pablo@netfilter.org>
Date2016-06-06 17:00 +0200
SubjectRe: [PATCH] gtp: #define _UAPI_LINUX_GTP_H_ and not _UAPI_LINUX_GTP_H__
Message-ID<rH4au-6he-11@gated-at.bofh.it>
In reply to#1415006
On Mon, Jun 06, 2016 at 01:51:40PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Fix clang build warning:
> 
> ./include/uapi/linux/gtp.h:1:9: warning: '_UAPI_LINUX_GTP_H_' is
> used as a header guard here, followed by #define of a different
> macro [-Wheader-guard]
> 
> fix by defining  _UAPI_LINUX_GTP_H_ and not _UAPI_LINUX_GTP_H__
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>

I don't see this in netdev's patchwork:

        http://patchwork.ozlabs.org/project/netdev/list/

So please, resubmit Cc'ing netdev@vger.kernel.org.

Thanks.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web