Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1415073 > unrolled thread

Re: [PATCH 1/4] perf stat: Basic support for TopDown in perf stat

Started byArnaldo Carvalho de Melo <acme@kernel.org>
First post2016-06-06 16:10 +0200
Last post2016-06-06 16:40 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 1/4] perf stat: Basic support for TopDown in perf stat Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-06-06 16:10 +0200
    Re: [PATCH 1/4] perf stat: Basic support for TopDown in perf stat Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-06-06 16:20 +0200
      Re: [PATCH 1/4] perf stat: Basic support for TopDown in perf stat Andi Kleen <ak@linux.intel.com> - 2016-06-06 16:40 +0200

#1415073 — Re: [PATCH 1/4] perf stat: Basic support for TopDown in perf stat

FromArnaldo Carvalho de Melo <acme@kernel.org>
Date2016-06-06 16:10 +0200
SubjectRe: [PATCH 1/4] perf stat: Basic support for TopDown in perf stat
Message-ID<rH3o7-5Yv-73@gated-at.bofh.it>
Em Mon, May 30, 2016 at 01:19:42PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Mon, May 30, 2016 at 09:04:02AM -0700, Andi Kleen escreveu:
> > > Which is a Broadwell-U, dual-core, 14 nm.
> > > 
> > > [root@jouet linux]# echo 0 > /proc/sys/kernel/nmi_watchdog
> > > [root@jouet linux]# perf stat --topdown -a usleep 1
> > > System does not support topdown
> > > [root@jouet linux]# cat /proc/sys/kernel/nmi_watchdog
> > > 0
> > > [root@jouet linux]#
> > > 
> > > Please advise.
> > 
> > You don't have the kernel patches?
> > 
> > They're in PeterZ's tree, but not yet in tip
> > https://git.kernel.org/cgit/linux/kernel/git/peterz/queue.git/log/?h=perf/core
> 
> oops, will try applying those patches, thanks for claryfing.

The kernel patches are in tip/perf/core now, so I applied the patches
and they seem to work, but they broke one 'perf test' entry:

# perf test 5
 5: parse events tests                                       : FAILED!

# perf test -v 5
<SNIP>
running test 50 '4:0x6530160/name=numpmu/'
running test 51 'L1-dcache-misses/name=cachepmu/'
running test 0 'cpu/config=10,config1,config2=3,period=1000/u'
running test 1 'cpu/config=1,name=krava/u,cpu/config=2/u'
running test 2 'cpu/config=1,call-graph=fp,time,period=100000/,cpu/config=2,call-graph=no,time=0,period=2000/'
Invalid sysfs entry event=topdown-recovery-bubbles.scale
failed to parse event 'cpu/event=topdown-recovery-bubbles.scale/u', err 1
test child finished with 1
---- end ----
parse events tests: FAILED!
#

Please check that,

- Arnaldo

[toc] | [next] | [standalone]


#1415099

FromArnaldo Carvalho de Melo <acme@kernel.org>
Date2016-06-06 16:20 +0200
Message-ID<rH3xN-62c-61@gated-at.bofh.it>
In reply to#1415073
Em Mon, Jun 06, 2016 at 11:00:03AM -0300, Arnaldo Carvalho de Melo escreveu:
> The kernel patches are in tip/perf/core now, so I applied the patches
> and they seem to work, but they broke one 'perf test' entry:
 
> # perf test -v 5
> <SNIP>
> running test 50 '4:0x6530160/name=numpmu/'
> running test 51 'L1-dcache-misses/name=cachepmu/'
> running test 0 'cpu/config=10,config1,config2=3,period=1000/u'
> running test 1 'cpu/config=1,name=krava/u,cpu/config=2/u'
> running test 2 'cpu/config=1,call-graph=fp,time,period=100000/,cpu/config=2,call-graph=no,time=0,period=2000/'
> Invalid sysfs entry event=topdown-recovery-bubbles.scale
> failed to parse event 'cpu/event=topdown-recovery-bubbles.scale/u', err 1
> test child finished with 1
> ---- end ----
> parse events tests: FAILED!
> #

Ok, the test failure is not due to this patchkit, the reason are the new
topdown*.scale files in the kernel, was there a patch to handle that
that is missing in my branch?

- Arnaldo

[toc] | [prev] | [next] | [standalone]


#1415132

FromAndi Kleen <ak@linux.intel.com>
Date2016-06-06 16:40 +0200
Message-ID<rH3R8-68Z-23@gated-at.bofh.it>
In reply to#1415099
On Mon, Jun 06, 2016 at 11:11:40AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Mon, Jun 06, 2016 at 11:00:03AM -0300, Arnaldo Carvalho de Melo escreveu:
> > The kernel patches are in tip/perf/core now, so I applied the patches
> > and they seem to work, but they broke one 'perf test' entry:
>  
> > # perf test -v 5
> > <SNIP>
> > running test 50 '4:0x6530160/name=numpmu/'
> > running test 51 'L1-dcache-misses/name=cachepmu/'
> > running test 0 'cpu/config=10,config1,config2=3,period=1000/u'
> > running test 1 'cpu/config=1,name=krava/u,cpu/config=2/u'
> > running test 2 'cpu/config=1,call-graph=fp,time,period=100000/,cpu/config=2,call-graph=no,time=0,period=2000/'
> > Invalid sysfs entry event=topdown-recovery-bubbles.scale
> > failed to parse event 'cpu/event=topdown-recovery-bubbles.scale/u', err 1
> > test child finished with 1
> > ---- end ----
> > parse events tests: FAILED!
> > #
> 
> Ok, the test failure is not due to this patchkit, the reason are the new
> topdown*.scale files in the kernel, was there a patch to handle that
> that is missing in my branch?

I sent you a patch separately now that fixes it.

-Andi
-- 
ak@linux.intel.com -- Speaking for myself only

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web