Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1415149 > unrolled thread

[PATCH] x86/efi: remove unused variable efi

Started byColin King <colin.king@canonical.com>
First post2016-06-06 16:40 +0200
Last post2016-06-08 14:50 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] x86/efi: remove unused variable efi Colin King <colin.king@canonical.com> - 2016-06-06 16:40 +0200
    Re: [PATCH] x86/efi: remove unused variable efi Matt Fleming <matt@codeblueprint.co.uk> - 2016-06-08 14:50 +0200

#1415149 — [PATCH] x86/efi: remove unused variable efi

FromColin King <colin.king@canonical.com>
Date2016-06-06 16:40 +0200
Subject[PATCH] x86/efi: remove unused variable efi
Message-ID<rH3R9-68Z-75@gated-at.bofh.it>
From: Colin Ian King <colin.king@canonical.com>

Remove unused variable efi, it is never used. Fixes clang build
warning:

arch/x86/boot/compressed/eboot.c:803:2: warning: Value stored to
  'efi' is never read

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 arch/x86/boot/compressed/eboot.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c
index 52fef60..ff574da 100644
--- a/arch/x86/boot/compressed/eboot.c
+++ b/arch/x86/boot/compressed/eboot.c
@@ -757,7 +757,6 @@ struct boot_params *make_boot_params(struct efi_config *c)
 	struct boot_params *boot_params;
 	struct apm_bios_info *bi;
 	struct setup_header *hdr;
-	struct efi_info *efi;
 	efi_loaded_image_t *image;
 	void *options, *handle;
 	efi_guid_t proto = LOADED_IMAGE_PROTOCOL_GUID;
@@ -800,7 +799,6 @@ struct boot_params *make_boot_params(struct efi_config *c)
 	memset(boot_params, 0x0, 0x4000);
 
 	hdr = &boot_params->hdr;
-	efi = &boot_params->efi_info;
 	bi = &boot_params->apm_bios_info;
 
 	/* Copy the second sector to boot_params */
-- 
2.8.1

[toc] | [next] | [standalone]


#1417375

FromMatt Fleming <matt@codeblueprint.co.uk>
Date2016-06-08 14:50 +0200
Message-ID<rHL5L-aT-7@gated-at.bofh.it>
In reply to#1415149
On Mon, 06 Jun, at 03:32:11PM, Colin Ian King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Remove unused variable efi, it is never used. Fixes clang build
> warning:
> 
> arch/x86/boot/compressed/eboot.c:803:2: warning: Value stored to
>   'efi' is never read
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  arch/x86/boot/compressed/eboot.c | 2 --
>  1 file changed, 2 deletions(-)

Thanks Colin, applied to 'next'.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web