Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1414848 > unrolled thread
| Started by | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| First post | 2016-06-06 11:50 +0200 |
| Last post | 2016-06-06 12:30 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH 0/4] serial: earlycon: keep earlycon symbols for non-module and driver clean-ups Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-06-06 11:50 +0200
[PATCH 3/4] serial: 8250_mtk: drop !defined(MODULE) conditional Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-06-06 11:50 +0200
Re: [PATCH 3/4] serial: 8250_mtk: drop !defined(MODULE) conditional Matthias Brugger <matthias.bgg@gmail.com> - 2016-06-06 12:30 +0200
Re: [PATCH 0/4] serial: earlycon: keep earlycon symbols for non-module and driver clean-ups Arnd Bergmann <arnd@arndb.de> - 2016-06-06 12:30 +0200
| From | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| Date | 2016-06-06 11:50 +0200 |
| Subject | [PATCH 0/4] serial: earlycon: keep earlycon symbols for non-module and driver clean-ups |
| Message-ID | <rGZkt-34Q-7@gated-at.bofh.it> |
1/4: keep earlycon symbols only when CONFIG_SERIAL_EARLYCON is defined
and the driver is built-in.
2/4 thru 4/4: driver clean-ups.
(partially reverts build fixes by Arnd Bergmann)
Masahiro Yamada (4):
earlycon: mark earlycon code as __used iif the caller is built-in
serial: 8250_uniphier: drop !defined(MODULE) conditional
serial: 8250_mtk: drop !defined(MODULE) conditional
serial: 8250_ingenic: drop #if conditional surrounding earlycon code
drivers/tty/serial/8250/8250_ingenic.c | 2 --
drivers/tty/serial/8250/8250_mtk.c | 2 +-
drivers/tty/serial/8250/8250_uniphier.c | 2 +-
drivers/tty/serial/8250/Kconfig | 2 +-
include/linux/serial_core.h | 8 +++++++-
5 files changed, 10 insertions(+), 6 deletions(-)
--
1.9.1
[toc] | [next] | [standalone]
| From | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| Date | 2016-06-06 11:50 +0200 |
| Subject | [PATCH 3/4] serial: 8250_mtk: drop !defined(MODULE) conditional |
| Message-ID | <rGZku-34Q-23@gated-at.bofh.it> |
| In reply to | #1414848 |
The !defined(MODULE) conditional has been added to the
OF_EARLYCON_DECLARE() define.
This commit partially reverts commit 3f5921a60f74 ("serial:
8250/mediatek: fix building with SERIAL_8250=m").
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
drivers/tty/serial/8250/8250_mtk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/8250/8250_mtk.c b/drivers/tty/serial/8250/8250_mtk.c
index 3489fbc..3611ec9 100644
--- a/drivers/tty/serial/8250/8250_mtk.c
+++ b/drivers/tty/serial/8250/8250_mtk.c
@@ -301,7 +301,7 @@ static struct platform_driver mtk8250_platform_driver = {
};
module_platform_driver(mtk8250_platform_driver);
-#if defined(CONFIG_SERIAL_8250_CONSOLE) && !defined(MODULE)
+#ifdef CONFIG_SERIAL_8250_CONSOLE
static int __init early_mtk8250_setup(struct earlycon_device *device,
const char *options)
{
--
1.9.1
[toc] | [prev] | [next] | [standalone]
| From | Matthias Brugger <matthias.bgg@gmail.com> |
|---|---|
| Date | 2016-06-06 12:30 +0200 |
| Subject | Re: [PATCH 3/4] serial: 8250_mtk: drop !defined(MODULE) conditional |
| Message-ID | <rGZXc-3zz-15@gated-at.bofh.it> |
| In reply to | #1414849 |
On 06/06/16 11:41, Masahiro Yamada wrote:
> The !defined(MODULE) conditional has been added to the
> OF_EARLYCON_DECLARE() define.
>
> This commit partially reverts commit 3f5921a60f74 ("serial:
> 8250/mediatek: fix building with SERIAL_8250=m").
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
Acked-by: Matthias Brugger <matthias.bgg@gmail.com>
>
> drivers/tty/serial/8250/8250_mtk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_mtk.c b/drivers/tty/serial/8250/8250_mtk.c
> index 3489fbc..3611ec9 100644
> --- a/drivers/tty/serial/8250/8250_mtk.c
> +++ b/drivers/tty/serial/8250/8250_mtk.c
> @@ -301,7 +301,7 @@ static struct platform_driver mtk8250_platform_driver = {
> };
> module_platform_driver(mtk8250_platform_driver);
>
> -#if defined(CONFIG_SERIAL_8250_CONSOLE) && !defined(MODULE)
> +#ifdef CONFIG_SERIAL_8250_CONSOLE
> static int __init early_mtk8250_setup(struct earlycon_device *device,
> const char *options)
> {
>
[toc] | [prev] | [next] | [standalone]
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-06-06 12:30 +0200 |
| Message-ID | <rGZXc-3zz-17@gated-at.bofh.it> |
| In reply to | #1414848 |
On Monday, June 6, 2016 6:40:59 PM CEST Masahiro Yamada wrote: > 1/4: keep earlycon symbols only when CONFIG_SERIAL_EARLYCON is defined > and the driver is built-in. > > 2/4 thru 4/4: driver clean-ups. > (partially reverts build fixes by Arnd Bergmann) > > > Looks good to me, Acked-by: Arnd Bergmann <arnd@arndb.de>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web