Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1414140 > unrolled thread

[PATCH] gpio: lpc18xx: convert GPIO_LPC18XX from bool to tristate

Back to article view | Back to linux.kernel

Contents

  [PATCH] gpio: lpc18xx: convert GPIO_LPC18XX from bool to tristate Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-05 20:30 +0200
    Re: [PATCH] gpio: lpc18xx: convert GPIO_LPC18XX from bool to tristate Linus Walleij <linus.walleij@linaro.org> - 2016-06-08 11:20 +0200

#1414140 — [PATCH] gpio: lpc18xx: convert GPIO_LPC18XX from bool to tristate

The Kconfig currently controlling compilation of this code is:

 config GPIO_LPC18XX
       bool "NXP LPC18XX/43XX GPIO support"

...meaning that it currently is not being built as a module by anyone.

When targeting orphaned modular code in non-modular drivers, this
came up.  Joachim indicated that the driver was actually meant to
be tristate but ended up bool by accident.  So here we make it
tristate instead of removing the modular code that was essentially
orphaned.

Cc: Joachim Eastwood <manabian@gmail.com>
Acked-by: Joachim Eastwood <manabian@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <gnurou@gmail.com>
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 drivers/gpio/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 92443817b1ae..03aaa2a1f431 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -249,7 +249,7 @@ config GPIO_LOONGSON
 	  driver for GPIO functionality on Loongson-2F/3A/3B processors.
 
 config GPIO_LPC18XX
-	bool "NXP LPC18XX/43XX GPIO support"
+	tristate "NXP LPC18XX/43XX GPIO support"
 	default y if ARCH_LPC18XX
 	depends on OF_GPIO && (ARCH_LPC18XX || COMPILE_TEST)
 	help
-- 
2.8.0

[toc] | [next] | [standalone]

#1417138

On Sun, Jun 5, 2016 at 8:23 PM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:

> The Kconfig currently controlling compilation of this code is:
>
>  config GPIO_LPC18XX
>        bool "NXP LPC18XX/43XX GPIO support"
>
> ...meaning that it currently is not being built as a module by anyone.
>
> When targeting orphaned modular code in non-modular drivers, this
> came up.  Joachim indicated that the driver was actually meant to
> be tristate but ended up bool by accident.  So here we make it
> tristate instead of removing the modular code that was essentially
> orphaned.
>
> Cc: Joachim Eastwood <manabian@gmail.com>
> Acked-by: Joachim Eastwood <manabian@gmail.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Alexandre Courbot <gnurou@gmail.com>
> Cc: linux-gpio@vger.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

Patch applied.

Yours,
Linus Walleij

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web